Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 17 Jun 2022 14:09:51 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     kernel test robot <lkp@intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org,
        linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
        linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        llvm@lists.linux.dev, kbuild-all@lists.01.org,
        Muchun Song <songmuchun@bytedance.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        James Houghton <jthoughton@google.com>,
        Mina Almasry <almasrymina@google.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        catalin.marinas@arm.com, will@kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/4] hugetlb: skip to end of PT page mapping when pte not
 present
Message-ID: <Yqztn/1skXZSNgW1@monkey>
References: <20220616210518.125287-2-mike.kravetz@oracle.com>
 <202206171929.ZIUrNg6p-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202206171929.ZIUrNg6p-lkp@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z4uTSQfDALWc/54A7i0H7EjCtw8MlpDlsjrCGTEc/tjgqNrn//1D6Yql9ruC?=
 =?us-ascii?Q?qhfVJMCWSMCpUFPZH5qRd2t0ip/7dJTQz3Q6K6ReyofGI4nVgM8Ca/MSjy/p?=
 =?us-ascii?Q?HndkerO+iNzQJvNnWFNFxuDvZR0qCu70+QcHLe4fHgmuiGA9F7PxJH/ty61e?=
 =?us-ascii?Q?wxWHaHNDGYd+iW7fKSq4QHar/v0wn+PlQ/k200QerJsSjlhpR6dQYGlZtITd?=
 =?us-ascii?Q?TqjgXwlrSrc3wf3pFyavy3xjoz/GItL04PNHlrUe4DeKgJXKZodY7kb0igHs?=
 =?us-ascii?Q?pLjQ6nnTjBKyvAb6CFQZwyhIpsjffsdU1r++7uE/RN+DYYcDuO6QzaUE7obB?=
 =?us-ascii?Q?RJBuBJXr0ObCpoGs6/An5kudOk4E+JiZZ78IoOV4vbqILhUwh3+E/vIcx7xK?=
 =?us-ascii?Q?oH8DPpSk88qzvNODQ0w10Ffbpwbzzfp0ccm7AqTxMmwav2DEYhYiLfDaF3Wj?=
 =?us-ascii?Q?aI5g5gqCVPXVhB8Y/Qe9sKi0SQSUcInm2rFMvOxiRX8AK0F7hLfRxaBpLg8+?=
 =?us-ascii?Q?0cIgkOifc6GPA014WQRQbJTYybDW/aHnNNfv7LBJ+50yIZjjZj/5x/hDTwak?=
 =?us-ascii?Q?VHl2U8FyFZ77Lqha4/BHm9lkoxVw1iSp8IM7ZysmW3BPcM+6eLcs0r4ie0I8?=
 =?us-ascii?Q?XpCTtHhoY87bcc3XYbQQmbGfKO0zX2JDXamGqHDcPyBuS7250G93CQ5D08MH?=
 =?us-ascii?Q?HXXhFPc/Gwwo+fq9wLyXTicwMDJ+JvYCNDqw2Ip4PggR/DoUYCNS1hfCpFMm?=
 =?us-ascii?Q?i/Wimptlx6fQvFPa0ZcLOFkA/z56WvNn29efkkMPNX96KCGgksPrKcdEOHus?=
 =?us-ascii?Q?Pzdd2IcX1+ve70FG+L5Ou2CnSOaOvhxI5O8prheATZuEy8rQnQK56Ms7CxQR?=
 =?us-ascii?Q?HM+mnRZK9viF2lP+LEVsua+ewsI+QounVZ9rMPhhXIzkT7O1Dl6hPbc2qeul?=
 =?us-ascii?Q?94F3dHF/EH4gLn2g6ZwbfRkg/+wqC+LE94l/LK9sUWeyqCdFn/CTKlYffc9u?=
 =?us-ascii?Q?qVTd1p7DY+psV4CYaLoNk8vcq/1NCsGat+NJA2Vz6mn/WpZh9ioL0y1TvSzT?=
 =?us-ascii?Q?AY8gwdEHS8pMwI3nRwvoBMVlVsIXddn5IbpKNou92xqxkKL1xiZ3cVrG/8s6?=
 =?us-ascii?Q?8N9wh/tH2wcYp0WbhRgy/a2/3XBIy18/xPx3RFCKJ3k+FzNYMcuBzSB5LVTS?=
 =?us-ascii?Q?yZN0Iuu++QSX1wA38glj5lDWOIIHBnAHCI3tg71w7Qy1WjGEHySGCwBF5rtJ?=
 =?us-ascii?Q?BNIoVvcCGmeg1R3BMXLAcCZvbb2jiwuUKtTGy2NJcflHMveuPdPZrK67sRKt?=
 =?us-ascii?Q?z05aGM35C3XqGqUHjJKhUYZpwPr/rFQUbtnqXkqTQr1CSMpTeTAjUpViQjGU?=
 =?us-ascii?Q?kn5btpKACAUItYzZ49hHm6CbUAXHdn0xH/IqYVDu+3yErR6UAWim/ikMOnb/?=
 =?us-ascii?Q?f4QdcIM+ko+ShKiB5X96FGVI1u8ihAFIayqVgzzrX5Rj20rLje7EaStW2w24?=
 =?us-ascii?Q?p1WCGco3xfX+ZIHL8XdSKHuk5H0LsOXM6Z3lIm7HFAUvTc9d2zRR7z++ZCoR?=
 =?us-ascii?Q?6Hk7Ty/SONNoMJ/vBM/vM1Po0XSXye/tp+NsjEkvVBHUVn6sjUHnzG9zx+d9?=
 =?us-ascii?Q?jJuF/rzYUgngiYuctosaG8WPRqEZzKI/Ree4307M0g5rc2fbIG84yarH56Ku?=
 =?us-ascii?Q?Dhdmtc8vUIlct+NDJsV420tyKhiCJ90ku2ixXrMQerRiEwvyrLz3otpPN/mk?=
 =?us-ascii?Q?zLNetIm5RoWewqg4MKvel5vaFnrakcQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed934ef0-3da4-43fc-d971-08da50a5ba68
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2022 21:09:55.7199
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LeLnEZkshajO69BDzI34H1BKqLRNvD18Q6EgQ2S9Ey6YMnR3VJBPNEv6L7OnxC7TeN19VjQQubhJpRmYpVq4ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5616
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-17_12:2022-06-17,2022-06-17 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206170091
X-Proofpoint-ORIG-GUID: ZclqbstJx_QuYZKOXZAU-BqqeLuvILuT
X-Proofpoint-GUID: ZclqbstJx_QuYZKOXZAU-BqqeLuvILuT
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/17/22 19:26, kernel test robot wrote:
> Hi Mike,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on soc/for-next]
> [also build test ERROR on linus/master v5.19-rc2 next-20220617]
> [cannot apply to arm64/for-next/core arm/for-next kvmarm/next xilinx-xlnx/master]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220617/202206171929.ZIUrNg6p-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project f0e608de27b3d568000046eebf3712ab542979d6)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/intel-lab-lkp/linux/commit/4c647687607f10fece04967b8180c0dadaf765e6
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Mike-Kravetz/hugetlb-speed-up-linear-address-scanning/20220617-050726
>         git checkout 4c647687607f10fece04967b8180c0dadaf765e6
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):

A couple of things here,

> 
> >> mm/hugetlb.c:6901:7: error: duplicate case value '4194304'
>            case PUD_SIZE:
>                 ^
>    include/asm-generic/pgtable-nopud.h:20:20: note: expanded from macro 'PUD_SIZE'
>    #define PUD_SIZE        (1UL << PUD_SHIFT)
>                            ^
>    mm/hugetlb.c:6899:7: note: previous case defined here
>            case P4D_SIZE:
>                 ^
>    include/asm-generic/pgtable-nop4d.h:13:19: note: expanded from macro 'P4D_SIZE'
>    #define P4D_SIZE                (1UL << P4D_SHIFT)

In the CONFIG_ARCH_WANT_GENERAL_HUGETLB case covered by this version of
hugetlb_mask_last_page, huge pages can only be PMD_SIZE or PUD_SIZE.
So, the 'case P4D_SIZE:' should not exist and can be removed.

>                                    ^
>    mm/hugetlb.c:6903:7: error: duplicate case value '4194304'
>            case PMD_SIZE:
>                 ^
>    include/asm-generic/pgtable-nopmd.h:22:20: note: expanded from macro 'PMD_SIZE'
>    #define PMD_SIZE        (1UL << PMD_SHIFT)
>                            ^

On i386 with CONFIG_PGTABLE_LEVELS=2, PUD_SIZE == PMD_SIZE.
Originally, I coded this as a if .. else if ... statement instead of a
switch.  If coded this way, the compiler does not complain about the
duplicate values.  The only other alternative I can think of is
something like '#if CONFIG_PGTABLE_LEVELS > 2' around the PUD_SIZE case.

I would prefer the if else if, unless someone can suggest something else?
-- 
Mike Kravetz