Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 2/2] selftests/x86/amx: Fix the test to avoid failure when
 AMX is unavailable
To:     "Chang S. Bae" <chang.seok.bae@intel.com>,
        linux-kselftest@vger.kernel.org, shuah@kernel.org,
        linux-kernel@vger.kernel.org
Cc:     dave.hansen@linux.intel.com, tglx@linutronix.de, bp@suse.de,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220401221014.13556-1-chang.seok.bae@intel.com>
 <20220401221014.13556-3-chang.seok.bae@intel.com>
 <aaab50d2-592c-69e4-58a6-0a0926669de3@linuxfoundation.org>
 <327cde12-daea-84ba-4b24-64fe12e89dea@intel.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <de61ffdb-638a-ca84-31b5-55f6a8616597@linuxfoundation.org>
Date:   Fri, 17 Jun 2022 16:29:28 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <327cde12-daea-84ba-4b24-64fe12e89dea@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/17/22 4:21 PM, Chang S. Bae wrote:
> On 6/16/2022 3:54 PM, Shuah Khan wrote:
>> On 4/1/22 4:10 PM, Chang S. Bae wrote:
>>>

>>
>> This should KSFT_SKIP for this to be reported as a skip. Returning 0
>> will be reported as a Pass.
> 
> I think that's a good point, thanks.
> 
> Now, along with the on-going documentation [1], this test code can be simplified like the below changes, instead of having those cpuid functions:
> 

Simplifying is always good. Send me v2 and I will review it.

thanks,
-- Shuah