Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp899897iog; Fri, 17 Jun 2022 16:57:21 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tyif+dlap1gQ72fFbSgFBUmhSMp7CT6Qxky1nDT7xnb0Sjz7U8nCDcgSR1BTORDSGm7DJ7 X-Received: by 2002:a17:902:c2ca:b0:168:db72:16a with SMTP id c10-20020a170902c2ca00b00168db72016amr12361243pla.171.1655510240776; Fri, 17 Jun 2022 16:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655510240; cv=none; d=google.com; s=arc-20160816; b=OCb32XHnZSUycLNPSXyOUGmJYWd7agyEcjjaJ27ldnFSJpFGxhBhaGWBKGiJJhKPBS 50EAXxgjG3uTjD8Dhjoxept0jsqLquRjYc//l/X6Uq4fbEEa2ZfDagl9T1SpEL+aCXJQ apZyfh98Ua3OSsMsXxLC9LvEC9NCHOsDa3HQIMv/HAK0hIyjuCs35KWytXhBH4t8/wBP zH8zYEN/vwL1UXWT4gfsmfbLPO8gnnSFf2338depOpCOKLZqolEz4mEfYvifRSEUGq5s scYmQiQLbnRz87dKNc1/8PtFjlzh5QLthSGtq6k2hTNE1xgDrOAXawgMtOEK1ke+IdtF sz0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=v+CtxF5jqTCvHtrkh/Tp3q/wyDmiOTtwUhSwgsvpJ3w=; b=Rh0yg8hsBI7d7gohoY8kcaPDP4fRL3G5hj6hOyYJA8nEoNSdUb+qxS+EXH4dS98oXl SvkF0cfAvuQrSZtELgC7g8WKX1dzFIdwShAa2JaASCo8FVRWz30zHCdzyIPSf5UbsXQ9 3yfGMwiv1MaeyBHCEYcSNdZRc5VDauu87ZDvVYeCoqPQLw/ux2/A/OmW7UOjUBnobco0 6VO/VFFif4cQ4exTnnbC+Y6fs5wMvJok6TM+XGVQ+9/JfYaYu1zMdMeno9052/K5VxaT M6k+qI0001yJozyM4e1lA3vJiB8+9/6Gu8//rYevwn+G0sJKr1KhJE3hfTCl1R88p/tn uvUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="YGI/OqaR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m2-20020a17090a71c200b001c73b8066e0si7312910pjs.74.2022.06.17.16.57.09; Fri, 17 Jun 2022 16:57:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="YGI/OqaR"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1380549AbiFQXqK (ORCPT + 99 others); Fri, 17 Jun 2022 19:46:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbiFQXqI (ORCPT ); Fri, 17 Jun 2022 19:46:08 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 935EC56C13 for ; Fri, 17 Jun 2022 16:46:04 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id p128so6016191iof.1 for ; Fri, 17 Jun 2022 16:46:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v+CtxF5jqTCvHtrkh/Tp3q/wyDmiOTtwUhSwgsvpJ3w=; b=YGI/OqaRkadQXXxsJnM8uGyOtjDZ6+A5GQjelvB1B3X6TwS5V3C66lWgNbx51CvUWU XgSrKKU9DJpc5ofYqMNNzNijwDz7Cwd7HiQ1xSTNhmQieX3/tAsb7n8oQTpgU1kOP7hR cHflRSYq3M56cSGCoG6//ypA+QjlZMq+AIONrdqck9QbHFG1+PBfZbEXvYZo5NeUnbSj g2hATSAaX/qsS7h9BFS3x3XNSS5hMAAPigWi8nUMDnL21PHTh4043HEssgBvTKaaIpeT QfdoAN1HGyHbpbC9hbw7N6fugvvOPBStQP9iMGtqvnOAdZsXHLT6VNM8VMy+RtkTDwGO LikQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v+CtxF5jqTCvHtrkh/Tp3q/wyDmiOTtwUhSwgsvpJ3w=; b=EArhITlOsdlZ/KPFCN+GcsUgpqrtSQvCcoJgcJwyhf2YC8Nwf0mmc3XxayTu8Lf4n1 cSTMd7HhiE6Ob+vE+u4cHkoDxA8LaYma4WyOCXg5e1WrMTE2qGuvZwHYIC4C28s9aPk6 aVtlKA1zVtVP7bdjctsWC/eerQHsMuNhZezWFU1Pbh4A69LSgXXV/kD9b0J72eSoANWg fkaN0ipK0gmA0/aqdZvvMUqdYU77zsakdK6dWvgwsrmIw3WgNoOd5++2UsWogVNJnQ/V ptbjvTO1HV8mdZjWXq2uUasQGnDiSWdYuNcv6zxA2WdcGfmSZU//eNn9k++LZGT8wai8 JCLg== X-Gm-Message-State: AJIora/O7VvqP5WzNXls2PH+op+1sA5Jr3WisUBUBv46U2SOW3ZhLkLm XWc65LhW0ylp3GMMK8ka5Knd6kvu/mE2WsVR3knBRw== X-Received: by 2002:a02:90ce:0:b0:32e:e2ce:b17c with SMTP id c14-20020a0290ce000000b0032ee2ceb17cmr6926427jag.268.1655509563773; Fri, 17 Jun 2022 16:46:03 -0700 (PDT) MIME-Version: 1.0 References: <20220617085435.193319-1-pbl@bestov.io> <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org> In-Reply-To: <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org> From: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= Date: Fri, 17 Jun 2022 16:45:52 -0700 Message-ID: Subject: Re: [PATCH v2] ipv4: ping: fix bind address validity check To: patchwork-bot+netdevbpf@kernel.org, stable@vger.kernel.org Cc: Riccardo Paolo Bestetti , Carlos Llamas , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel-team@android.com, Kernel hackers , Linux NetDev , Miaohe Lin Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 4:30 AM wrote: > > Hello: > > This patch was applied to netdev/net.git (master) > by David S. Miller : > > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote: > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses") > > introduced a helper function to fold duplicated validity checks of bind > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an > > unintended regression in ping_check_bind_addr(), which previously would > > reject binding to multicast and broadcast addresses, but now these are > > both incorrectly allowed as reported in [1]. > > > > [...] > > Here is the summary with links: > - [v2] ipv4: ping: fix bind address validity check > https://git.kernel.org/netdev/net/c/b4a028c4d031 > > You are awesome, thank you! > -- > Deet-doot-dot, I am a bot. > https://korg.docs.kernel.org/patchwork/pwbot.html I believe this [ https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031 ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so probably just 5.18)