Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp999725iog; Fri, 17 Jun 2022 20:22:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ubyBwZnzGuHzkuBnuCvPntba5d0WROORRZQ/LxjYpoH+kRjB5K+uOkKzMXsSB/tJWDyEce X-Received: by 2002:a63:604:0:b0:3fc:8830:a67c with SMTP id 4-20020a630604000000b003fc8830a67cmr11618779pgg.402.1655522552628; Fri, 17 Jun 2022 20:22:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655522552; cv=none; d=google.com; s=arc-20160816; b=lqSkUFAT5Q5ZZIj7ILhDTbHK6e+/qGUa4flHVh6iVZNsCPsBUCGyFzqexyeRWvjRN4 B4SF779MNBol/jOScmTutgUo2gtP810EbmIPzF0KR6Hq49+nsSBofIzfkVNq44Nv/zRF xI5osu2dak2ol7KQrDRrVxHZncAmwmxhtKQLEvFA0i/Tvuqn11qb8lpOuTlBHuWhdQoW Y4GoICY4DgaRoSzAQ3c7xFQLrog7zQO4qakoUKb5Q6NUyBIv+j3klStemTMmUnw64Afz qAxDbSwiTKA5rNRUhX2cpKlaEQhT7SlKiL/BFmpP42nVX5KBwz26XUVOAAy7kZBaq+9q bfDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=W6zJJ6EQSZHCEKng2q7HaAa8jhTaOwed4FF+XB+aC+A=; b=c0pI3rT2U5jDy3dEradWC4UWd7Bynwv8hQqmjyaEQnZWTyUNvaVQp4ezMGxLQ3QV20 BLXUg8zrbsuEL2pWnyKQxhoAi5tfs/r70G1m1G+wG0tektPRlJKITnbqVCWoJw6oN8CW /sX5i0CM43m1F8W1B03n7QMe+Z4l0pvmQXo4/aCkU8zDMw/WZbhTQS743o6GPSUYniyT gIsPB6mHYF7kMYxGTH6oJOExchfsUuCaP4f7GFWoFws7qUDkLr3b22JUqdpVZGQuKDXi ZEZBKQPO/hfcepYmo1zjqprYTfZFmGTYf03FdAZ9Nm1p7FeDSONc8fexbip6pKfhZdQt WODQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ee4WQPbj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o13-20020a056a0015cd00b0051bbb4fb4a0si9719820pfu.15.2022.06.17.20.22.21; Fri, 17 Jun 2022 20:22:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ee4WQPbj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237324AbiFRDBf (ORCPT + 99 others); Fri, 17 Jun 2022 23:01:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234141AbiFRDBd (ORCPT ); Fri, 17 Jun 2022 23:01:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16DD96C557; Fri, 17 Jun 2022 20:01:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6ACF61F43; Sat, 18 Jun 2022 03:01:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1A40C3411B; Sat, 18 Jun 2022 03:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655521292; bh=esT+EY763V71Pumcl+zfF4U16AJdmGYDqb7VxSEiijQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ee4WQPbj6nKJmFoN7a7/a3ju4zh6yvTSggpuAen/cp/vDNq3ujkMy1oJwiZg/jKgM UyDcYDCkv+KYvsEvk3ebnUz8kLk6dYBhUYh9pcKPo3unZ2oBiu6IzEeXIWoh4rkW9e vDEwSTOKlxM6WWUeB1f9zk8MZejW6z+5qDfmRbBNa6rUGIz8aQiWpOmv2dnEfWdRSu yvZWN1zLb6oICuUk/7XrBb2D0ryjrHX8EatJoi4MkGQ7Gh9rWrdU915H2QY8UvJns7 pLqVmpPkTnt4pLz4zwNERLzsGpKIQtUH2yJjCc2qlHgLmsoo4XdlSscg9qLydieeJD 4Ktn5pa9Q8U7A== Date: Fri, 17 Jun 2022 20:01:30 -0700 From: Jakub Kicinski To: HighW4y2H3ll Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fix buffer overflow in hinic_devlink.c:hinic_flash_fw Message-ID: <20220617200130.7ef96a66@kernel.org> In-Reply-To: <20220617050101.37620-1-huzh@nyu.edu> References: <20220617050101.37620-1-huzh@nyu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2022 01:01:02 -0400 HighW4y2H3ll wrote: > Subject: [PATCH v2] Fix buffer overflow in hinic_devlink.c:hinic_flash_fw > Date: Fri, 17 Jun 2022 01:01:02 -0400 > X-Mailer: git-send-email 2.35.1 > > Signed-off-by: zhenghao hu Please describe in the commit message what the buffer overflow is, so we don't have to reverse engineer your change. Also please add a Fixes tag pointing at a commit which introduced the bug.