Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1007897iog; Fri, 17 Jun 2022 20:41:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sS2D0NA1PPqiqGz2HaxbxKSibgoDfD0I+Of/5oEY/EGXFkfmn7Mlsu6+Yk7sKRRYJdTojv X-Received: by 2002:a05:6402:4396:b0:42f:b88e:5429 with SMTP id o22-20020a056402439600b0042fb88e5429mr16180427edc.298.1655523673819; Fri, 17 Jun 2022 20:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655523673; cv=none; d=google.com; s=arc-20160816; b=UJwdzjaot5GodlcGoudKtpakLSNv3EqHWAZLX56gR1WNRQtEZXxKKuRydk1zbuzSDd OuOXbVWHmDLN+8/ku8rY7a24AfJuhq5o25jZtlzw9qfJNr8nW4aOrV92AtPQL6kDMfkP KZilf33CNJfbnRvI14tK3kXCKJU2GjhhoA23vpRNYIHWjzG/xw4fs5ZTOgwl7bbLAMrs L6N08Mu/V3FXvHaCme8YDYyOs4R/tkZc5QbJGWfrsRbpOwihoh5udATe/JNZg3NjgmGj bHCtXaFvq2uvDntl6kjJS+VDWvHMDJX7YJ7DJ9qZh9/TwLv/6l49mV22TllXlIN9jwr7 Tdig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=BXJ4Qt5/PyjJoOqpc1bHzLvqH5CBikcfyO76fBJ5S0c=; b=hdL5l4nCbggJ40h+2Ti9+qx3+eCQW3vSQPF2ZxiHcG0OCX8fZT7MFpXHSjWVOJS+vJ HQk0cjoWkM84ZczJordW93c1Hq4NTcYMyWsFLAslgxoaRCFTOyDKG99heOy8xUX59FtX cabD3u3H2f+EU7/nzgaCEbtMpsKN8P265bW4H1k78jJnwMOed6GEN22O/Ab2xB3GM30A KcPq7VLr6kQ724wHeLiJYa4u57iE6go1MpqS1dFCDzHis04V9WsEr1lFfLpJ93gUN9rA ia2XEbvEstfY1WtTOS68H3TsGWpvv5eNmRZ74jfzagqUyq6NjSiUH/o+2GlQf2CHGYPs EVwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CoLBeiqn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a056402280c00b0042df64a5b1csi8915248ede.332.2022.06.17.20.40.49; Fri, 17 Jun 2022 20:41:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CoLBeiqn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236333AbiFRDaS (ORCPT + 99 others); Fri, 17 Jun 2022 23:30:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230500AbiFRDaQ (ORCPT ); Fri, 17 Jun 2022 23:30:16 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF4D469CF9; Fri, 17 Jun 2022 20:30:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A39BDB82D1F; Sat, 18 Jun 2022 03:30:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 5A959C3411E; Sat, 18 Jun 2022 03:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655523013; bh=imZHSh61aXEmeSuzVYB46shMBkAiRz4LBhIdGDei7uw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=CoLBeiqnMkQayAFQu3ZzfzaEuH3m4blvIILNipETVLBaypLpRYgn5evT9Mn8VMybd J0UDkztCvcoSCnksOAZ85vDdscjGA58k24cE1KTGRPfUj8SfaY6OZ2gZsLcQ0yBKTH 9aAoNTR08droCSO5ITuR5pbSZQkWbDO+iU/5QNK+eqG8zFDHK2kbNKW9qLxzIpn03T RhuRY8Ws65qljA/VaAEKxojWxKRByNmfN830YCiT4b/grpLYQBdM7WQdPjnfeo/IY8 z5fcabNRW3l54FzCIe9MhFA/XVXNfI5KN37rPm5kcXrWs/iyd3CCyx+wDgmNDmwZN6 gnzjVE/34hZNQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3CC99E7387A; Sat, 18 Jun 2022 03:30:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net] ethtool: Fix get module eeprom fallback From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165552301324.7046.10386873519636092978.git-patchwork-notify@kernel.org> Date: Sat, 18 Jun 2022 03:30:13 +0000 References: <20220616160856.3623273-1-ivecera@redhat.com> In-Reply-To: <20220616160856.3623273-1-ivecera@redhat.com> To: Ivan Vecera Cc: netdev@vger.kernel.org, mkubecek@suse.cz, idosch@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vladyslavt@nvidia.com, andrew@lunn.ch, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Thu, 16 Jun 2022 18:08:55 +0200 you wrote: > Function fallback_set_params() checks if the module type returned > by a driver is ETH_MODULE_SFF_8079 and in this case it assumes > that buffer returns a concatenated content of page A0h and A2h. > The check is wrong because the correct type is ETH_MODULE_SFF_8472. > > Fixes: 96d971e307cc ("ethtool: Add fallback to get_module_eeprom from netlink command") > Cc: Ido Schimmel > Signed-off-by: Ivan Vecera > > [...] Here is the summary with links: - [net] ethtool: Fix get module eeprom fallback https://git.kernel.org/netdev/net/c/a3bb7b63813f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html