Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1128666iog; Sat, 18 Jun 2022 01:12:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1t4paoexs7zNLwwxauDlAAMI6q78p8iFFshAKpu7Ucq1/zlL5B5rSToEqdL5nOpTovD2K7+ X-Received: by 2002:a62:7cca:0:b0:4fd:e594:fac0 with SMTP id x193-20020a627cca000000b004fde594fac0mr14058109pfc.79.1655539965121; Sat, 18 Jun 2022 01:12:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655539965; cv=none; d=google.com; s=arc-20160816; b=0RLR0w8+O0AlFCu791zrFTetPBbnmznOiQQKE1+/XrQFmAB6W2nFzmMOdhYPUy8jhs ClM4VA2zCUMJUqxTJTEK6pBQurwKjF/rJl7OU+wxqS4CvcFTBSpb6h7vfUc3q+HvxR3l INFfkwUw/ry3gXqMx6mc4XJdZ1PvPifgy6BDbnKqOvQRIoqVH53cZwqu8LY8TLGIlvWz Y+NVPz9Hr+uyE0o+jWm4sGUyf1wb01YpCybo2AmOMoSiGCf+1BzZb3ii/1xIu+vxWXFS C2ez/ZW6zwqzmwx2UXbVyHSAIFWS7IeXMxKMaHfs7cl+t0HZRH5t+xP8kma16VANVIq5 pxQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HY7SL91Dp2dwcjkDk2PgKRD2uPG9gAKpA9WqpsRDXao=; b=w05LHNZIniL4o5Izq+fQ8L7UHqc61OJ0yfE5z+C7W88fdLxD2o1+OWHLe4OSIOAyYv gsORECUYU8XgGPH6YJFMDnPBBx9XAX7PK6MQk85rDMkR8639jLJfIJ6IdOZHRHvCU0kJ /AJbskNLZOC2FSwNLTR0ZDJJt3cLQ7j1CSf2PVxeV6a40N18Wsm4GChKN0FljwdHwn/K NWpMKzkfA+0tfqM/DP2at/vkFPYVQEtTvZhnvki/WOsPElxf+/v/zE+MwMSjM7Kw3GdJ G7ZWnPBbIqv2P27EP9aM4d4/hEcs1ku43fTGkx4QleThZi/VjHX5BplCZkY28R+IkWcL 64pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=notICbNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u2-20020a17090282c200b00153ce7c9244si5982029plz.97.2022.06.18.01.11.57; Sat, 18 Jun 2022 01:12:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=notICbNh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbiFRH26 (ORCPT + 99 others); Sat, 18 Jun 2022 03:28:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234735AbiFRH2u (ORCPT ); Sat, 18 Jun 2022 03:28:50 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2FAAF27CC9 for ; Sat, 18 Jun 2022 00:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=HY7SL 91Dp2dwcjkDk2PgKRD2uPG9gAKpA9WqpsRDXao=; b=notICbNhFCVNQJ0z2cl5e XW1JCcxFY5dvE2TUNPIPc3h+HJQvvFtf+pSYLmv1lVca0tPxvvl+59QiNqwA81IL 6e4KMz2g/zyrN60htNL/J0sdx/eHTwGiXT9WnZWtZXBvHBwMdZ75sSARPZu0QpcU 59sDqQCn+z10Yes2yDW8gA= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp10 (Coremail) with SMTP id NuRpCgCH3HCVfq1iWx2cEw--.30404S2; Sat, 18 Jun 2022 15:28:22 +0800 (CST) From: Liang He To: tglx@linutronix.de, maz@kernel.org Cc: windhl@126.com, linux-kernel@vger.kernel.org Subject: [PATCH] irqchip: Fix refcount leak bug in irq-ls-extirq.c Date: Sat, 18 Jun 2022 15:28:20 +0800 Message-Id: <20220618072820.4059291-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NuRpCgCH3HCVfq1iWx2cEw--.30404S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr15Kr17ZFy3try5CrWxZwb_yoW3Crg_Cr 4IgFsrJF10vrsxGrsrXr9xXFyqyrykursY9rnavF98Xa48Jw1DGr1Y93y5Gw4kWF4jyFWk Cw4qvw18Aw13ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUS1vDUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi2hYkF1uwMOnVyAAAsQ X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ls_extirq_parse_map(), we need to keep refcount balance in the 'while' loop. For each of_find_node_by_phandle(), we need a paired of_node_put(). Signed-off-by: Liang He --- drivers/irqchip/irq-ls-extirq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-ls-extirq.c b/drivers/irqchip/irq-ls-extirq.c index 853b3972dbe7..82fffa37ee86 100644 --- a/drivers/irqchip/irq-ls-extirq.c +++ b/drivers/irqchip/irq-ls-extirq.c @@ -126,6 +126,7 @@ ls_extirq_parse_map(struct ls_extirq_data *priv, struct device_node *node) return -EINVAL; priv->map[hwirq].fwnode = &ipar->fwnode; ret = of_property_read_u32(ipar, "#interrupt-cells", &intsize); + of_node_put(ipar); if (ret) return ret; -- 2.25.1