Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Qiang1" <qiang1.zhang@intel.com>
To:     "paulmck@kernel.org" <paulmck@kernel.org>
CC:     "frederic@kernel.org" <frederic@kernel.org>,
        "rcu@vger.kernel.org" <rcu@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] rcu/nocb: Correct output rcuog/rcuop kthreads
 information
Thread-Topic: [PATCH v2] rcu/nocb: Correct output rcuog/rcuop kthreads
 information
Thread-Index: AQHYgnARx6MR9KNEikiHRs0ziSVaN61UlrqAgACHj+A=
Date:   Sat, 18 Jun 2022 12:49:26 +0000
Message-ID: <PH0PR11MB5880581A04571E129A07CA7BDAAE9@PH0PR11MB5880.namprd11.prod.outlook.com>
References: <20220617141519.1677119-1-qiang1.zhang@intel.com>
 <20220618044223.GK1790663@paulmck-ThinkPad-P17-Gen-1>
In-Reply-To: <20220618044223.GK1790663@paulmck-ThinkPad-P17-Gen-1>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7IsS1RiGT3n+K3gBwTEZW4NwEmGjjhWyG8Mn3wWfdf7a9ibbwLN8j6QT5AqB?=
 =?us-ascii?Q?Qxt5BnPjIOcfc74tc4rMVmZE6u5YdrQ69R5jMsPxUUWFigSgLIdYYqd9z9bR?=
 =?us-ascii?Q?CYBtDKsrvJnrCZVxjjUr0aru96oCF8w/KkDbwNPGG63UNgrxhbTG8Uk4CojY?=
 =?us-ascii?Q?bn/Yv0ArfvCvSEWmnVW4FuGS1MjX7FwOr/bhKpPito15BrKT7ctODnzo6d6W?=
 =?us-ascii?Q?7v4U2XSKIeT/VREmd7hDq+AWiDnrYTQxZgtOse6TffnAbcoHC/1L0sxADzTP?=
 =?us-ascii?Q?5S0A5z0w+M74PBBRxEQPDx5t2OhDsu/+JUtkBvJHN+YYTJxiT4x1AEmOuAVS?=
 =?us-ascii?Q?V4+rCpIK2CDxwklVdTD3w7xJ6qFO6Tq3ZUOPmpPeeqVG2M19RVB2cBY2FeW3?=
 =?us-ascii?Q?2RP0n7mZhNgaQsPqNwbCIdw69ACeCSHk6hRqM4RnYsPsZLuxd+ntSap7gnNA?=
 =?us-ascii?Q?4kpjIEw/zgdZ1z5BZwA2/TNrrlcIIy5Wmn62i6vRvVE6EUwZcnip3VEfS5Mr?=
 =?us-ascii?Q?N1R5rPXSq1Ep3qyPzOHR1nDUfSzg1C8ThVGW53o1j/ML8WsIVxQt62sLUjdr?=
 =?us-ascii?Q?oddf20YDItV+TqTiCDynI4uE9GH+6zsVkwUZBcuHc4oF0wK4xPA1Npt2JqM0?=
 =?us-ascii?Q?n2uQoctqGtGb3cMKNnEQDdQSs9BG29y1y/gtKj48P80NJV0L0hgwmgzPyG3X?=
 =?us-ascii?Q?SAsKmom2AubT82wALNnFTy0fwQA1hh7LnU4GB9+JSY9vDubb3dE4Ezp6mISH?=
 =?us-ascii?Q?2CN8lH9wIeos9NTm3hilvKLLXRoDtQqhjl6Mvc90NOopnvEAZA9aSgg7wG56?=
 =?us-ascii?Q?U4+piSzrMg08B0xhysIh+Ag+Y+CuiDDuOCC2DW8PjJcy3CgEkK5p0mrQf/Bq?=
 =?us-ascii?Q?ub1XHLWm10NZD4zfrE7DAAvTuJNDclwcoG666yCaB+B8mtxVPqyV+zpCjHb6?=
 =?us-ascii?Q?6nta4uIZULJQnMS1fmT++J32OuoME+smNiHWtStmdAK9ZZUmqLhypEaNeL2j?=
 =?us-ascii?Q?kMAOsulkX1e9dgpjyZx4wQYwNR1IY6X5G6jbn5YiRr+/cj29gWaPKwBB/FIa?=
 =?us-ascii?Q?mixMwCHJlmH28zXPNbyZObKlkzcK1TIe0KqflTQMcq6mt+jxE2CRf6AZLxBz?=
 =?us-ascii?Q?4b0FET6Y+4a+z6L+zYvh291CTs+y/r6DAoKYl8eUuKuCKkiCMAKQvq1+O5UD?=
 =?us-ascii?Q?SHHFErq3MLxPUTsxbWV/Vtl4q55G5VbyLi4YtwmCsE4Y5pSDGtxeA376f4N+?=
 =?us-ascii?Q?rLpTpS76vs30VWoKjYfsjWvDMsDFs46e5qjzkMWGHVtWVaA1oJODVlnQoaiH?=
 =?us-ascii?Q?tNdNmc2MXwL4i3RI7iBY0HBKPwYs1w5qfBRym735qUJvuwl0IiALbz3l9+W/?=
 =?us-ascii?Q?gKTIT2kwK9Vn3jvuInUTRzhs65qfVU85CB+frg/cZZPIru+dT5NXS10WNxsP?=
 =?us-ascii?Q?FyZ6DPdDCtGIKuiOX4fJg5UI8/fYKuo93c1DqWB6JL8I10tnu69vjbclW+ez?=
 =?us-ascii?Q?ok1dopnFOCSRFdhMZQcOJDIYvJ0zpgI8gGgckL2I8eKNc125HLpqG7g1CvUP?=
 =?us-ascii?Q?NP/5K+Of2Rj7fCWHkBZyLU8nq9jM55zZSoA7Ycn/3gyJq7l6XDHMw+5Bchj7?=
 =?us-ascii?Q?SZE9aB4Y6g3hOvyU7ULlXmWxf6ApAWxFziZMD7ibivQBFxiIxA58/SkydplG?=
 =?us-ascii?Q?Za9mX9hGfD5I+RkJgl2g94S+bKaoUy03ssysBYVSXnWUS8y/BgbZIBgAxXZh?=
 =?us-ascii?Q?vIUZtaLk4g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5880.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 875503eb-3682-407f-23ef-08da5128fa2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2022 12:49:26.3657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tYVb1v3+uOFsnZZI/bVeQS3gB3MJwM6gIs7cm+MiIFhgAlzoZ0OSpKaqdBWPgAdwOjNKtosTz9X/muO565Ei4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6374
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 17, 2022 at 10:15:19PM +0800, Zqiang wrote:
> This commit make rcuog and rcuop thread information output in the=20
> correct location.
>=20
> Signed-off-by: Zqiang <qiang1.zhang@intel.com>
>
>Good catch, queued for review and testing, thank you!
>
>Ditto for the "rcu: Avoid reporting strict QSes from NMI context"
>patch.

Hi Paul, please remove this patch, the preempt_count() imply in_nmi()

Thanks
Zqiang

>
>As always, I wordsmithed both commit logs, so please check to see if I mes=
sed something up.
>
>						Thanx, Paul
>
> ---
>  v1->v2:
>  Only change commit information, the v1 is  [PATCH] rcu: Fix incorrect=20
> judgment condition in show_rcu_nocb_state().
>=20
>  kernel/rcu/tree_nocb.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/kernel/rcu/tree_nocb.h b/kernel/rcu/tree_nocb.h index=20
> a8f574d8850d..f20aec4f4394 100644
> --- a/kernel/rcu/tree_nocb.h
> +++ b/kernel/rcu/tree_nocb.h
> @@ -1452,8 +1452,8 @@ static void show_rcu_nocb_gp_state(struct rcu_data =
*rdp)
>  		(long)rdp->nocb_gp_seq,
>  		rnp->grplo, rnp->grphi, READ_ONCE(rdp->nocb_gp_loops),
>  		rdp->nocb_gp_kthread ? task_state_to_char(rdp->nocb_gp_kthread) : '.',
> -		rdp->nocb_cb_kthread ? (int)task_cpu(rdp->nocb_gp_kthread) : -1,
> -		show_rcu_should_be_on_cpu(rdp->nocb_cb_kthread));
> +		rdp->nocb_gp_kthread ? (int)task_cpu(rdp->nocb_gp_kthread) : -1,
> +		show_rcu_should_be_on_cpu(rdp->nocb_gp_kthread));
>  }
> =20
>  /* Dump out nocb kthread state for the specified rcu_data structure.=20
> */ @@ -1497,7 +1497,7 @@ static void show_rcu_nocb_state(struct rcu_data =
*rdp)
>  		".B"[!!rcu_cblist_n_cbs(&rdp->nocb_bypass)],
>  		rcu_segcblist_n_cbs(&rdp->cblist),
>  		rdp->nocb_cb_kthread ? task_state_to_char(rdp->nocb_cb_kthread) : '.',
> -		rdp->nocb_cb_kthread ? (int)task_cpu(rdp->nocb_gp_kthread) : -1,
> +		rdp->nocb_cb_kthread ? (int)task_cpu(rdp->nocb_cb_kthread) : -1,
>  		show_rcu_should_be_on_cpu(rdp->nocb_cb_kthread));
> =20
>  	/* It is OK for GP kthreads to have GP state. */
> --
> 2.25.1
>=20