Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 18 Jun 2022 18:34:40 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     ChiYuan Huang <u0084500@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        cy_huang <cy_huang@richtek.com>,
        linux-iio <linux-iio@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: Add rtq6056 adc support
Message-ID: <20220618183440.121365d7@jic23-huawei>
In-Reply-To: <279cf4ef-8b41-5e92-73c3-416730038c56@linaro.org>
References: <1655458375-30478-1-git-send-email-u0084500@gmail.com>
        <1655458375-30478-2-git-send-email-u0084500@gmail.com>
        <7a9d3354-164b-e5e5-936b-95de4c4338f9@linaro.org>
        <CADiBU3_wyFLpoy3PU0a-EbGAKoQ9LZMprH5DWnzwo05-Gwa2=Q@mail.gmail.com>
        <279cf4ef-8b41-5e92-73c3-416730038c56@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, 18 Jun 2022 19:00:19 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

> On 18/06/2022 08:50, ChiYuan Huang wrote:
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> =E6=96=BC 2022=E5=
=B9=B46=E6=9C=8818=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=889:45=E5=AF=
=AB=E9=81=93=EF=BC=9A =20
> >>
> >> On 17/06/2022 02:32, cy_huang wrote: =20
> >>> From: ChiYuan Huang <cy_huang@richtek.com>
> >>>
> >>> Add the documentation for Richtek RTQ6056.
> >>>
> >>> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> >>> ---
> >>>  .../bindings/iio/adc/richtek,rtq6056-adc.yaml      | 57 ++++++++++++=
++++++++++
> >>>  1 file changed, 57 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/iio/adc/richtek=
,rtq6056-adc.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq605=
6-adc.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056-adc.=
yaml
> >>> new file mode 100644
> >>> index 00000000..6b4e0e0
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056-adc.y=
aml
> >>> @@ -0,0 +1,57 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/iio/adc/richtek,rtq6056-adc.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: RTQ6056 Bi-Directional Current and Power Monitor with 16-bit =
ADC
> >>> +
> >>> +maintainers:
> >>> +  - ChiYuan Huang <cy_huang@richtek.com>
> >>> +
> >>> +description: |
> >>> +  The RTQ6056 is a high accuracy current-sense monitor with I2C and =
SMBus
> >>> +  interface, and the device provides full information for system by =
reading
> >>> +  out the loading current and power.
> >>> +
> >>> +  The device monitors both of the drops across sense resistor and th=
e BUS
> >>> +  voltage, converts into the current in amperes, and power in watts =
through
> >>> +  internal analog-to-digital converter ADC. The programmable calibra=
tion,
> >>> +  adjustable conversion time, and averaging function are also built =
in for
> >>> +  more design flexibility.
> >>> +
> >>> +  Datasheet is available at
> >>> +  https://www.richtek.com/assets/product_file/RTQ6056/DSQ6056-00.pdf
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    const: richtek,rtq6056
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  "#io-channel-cells":
> >>> +    const: 1
> >>> +
> >>> +  richtek,shunt-resistor-uohm: =20
> >>
> >> Use standard properties, so "-micro-ohms". Drop the unit from
> >> description and drop the ref.
> >> =20
> > Use richtek.shunt-resistor-micro-ohms? =20
>=20
> Yes.
>=20
> > Or the prefix 'richtek,' can be removed? =20
>=20
> No, the vendor prefix must stay.

It's a standard generic binding used in a bunch of IIO and hwmon
drivers without vendor prefix.  Mind you I can't find a definition
in any of the top level binding files.  Probably wants to be in
adc.yaml for IIO.

Jonathan

=20
>=20
> Best regards,
> Krzysztof