Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c39a479d-4a3c-9789-7ce2-579ae3c778a6@infradead.org>
Date:   Sat, 18 Jun 2022 14:59:00 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3 13/16] pinctrl: Add AXP192 pin control driver
Content-Language: en-US
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, wens@csie.org, jic23@kernel.org,
        lee.jones@linaro.org, sre@kernel.org, broonie@kernel.org,
        gregkh@linuxfoundation.org, lgirdwood@gmail.com
Cc:     lars@metafoo.de, rafael@kernel.org, quic_gurus@quicinc.com,
        sebastian.reichel@collabora.com, andy.shevchenko@gmail.com,
        michael@walle.cc, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com>
 <20220618214009.2178567-14-aidanmacdonald.0x0@gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220618214009.2178567-14-aidanmacdonald.0x0@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/18/22 14:40, Aidan MacDonald wrote:
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f52960d2dfbe..a71e35de333d 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -113,6 +113,20 @@ config PINCTRL_AT91PIO4
>  	  Say Y here to enable the at91 pinctrl/gpio driver for Atmel PIO4
>  	  controller available on sama5d2 SoC.
>  
> +config PINCTRL_AXP192
> +	tristate "X-Powers AXP192 PMIC pinctrl and GPIO Support"
> +	depends on MFD_AXP20X
> +	depends on OF
> +	select PINMUX
> +	select GENERIC_PINCONF
> +	select GPIOLIB
> +	help
> +	  AXP PMICs provides multiple GPIOs that can be muxed for different

	            provide

> +	  functions. This driver bundles a pinctrl driver to select the function
> +	  muxing and a GPIO driver to handle the GPIO when the GPIO function is
> +	  selected.
> +	  Say Y to enable pinctrl and GPIO support for the AXP192 PMIC.

-- 
~Randy