Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1872496iog; Sun, 19 Jun 2022 00:42:28 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v5X2EfxlqVR1fLxrJ1XAMCT/SjU1VCEVCUf5EmJW3IJDYlz4wzTYie1FuYiZU0esOKSYb5 X-Received: by 2002:a17:906:9254:b0:708:cf8e:25a5 with SMTP id c20-20020a170906925400b00708cf8e25a5mr15105946ejx.119.1655624548593; Sun, 19 Jun 2022 00:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655624548; cv=none; d=google.com; s=arc-20160816; b=r2/oG1bbeU3WliTRChiJ4gsKVAlNDOJ9uC8hqJEQw/AmDF3GRUTQCOg3NUmv56jnE5 fOtkcivoE7wvq+WvIdodescmVPd88Pl1B+PU5lAMJhGmUNBJ1TYuMGkLi7IkYUqHn+SB 0pq9NJvP6suDGs97nQHJRmJIXfyNSpfiZU68fv1ClFxfhkw6aXp94R7zCUNI8APNqNPr E5EJ7t5U4iXdGNhDZxKhXoNC8FW6f7xl7RHAeqL+a6yNN8SbmdKz4sZXpYbDXddBXJcj B/p2oKdz3iBeouzPPAidSaNQUuga0k+2LKuuhhKbAoXjEbFnsZBwSb33nLBQTpY30MzL 2rrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B1gcfg6uWh2Ydy18lGJ3Uf96MEQ9OMrXAXzfxSAidlQ=; b=M/ZYekygZIRDIioxTE079/SPwUTtJ3Eg6GQk6l1nf8IeqILIFM+MXqcIa0AR4dj68p kvCo/Lauik4fFhqkycsBnw1k3U+vwFxbArt2hIc+WRKvXDn0YywXb4aqczBS8PnOYaUl H6YiqcDbvA8lbtOW5Z1v2oUl6a0ItTbSPsxfSzR6y8cETdtOxmCIjeFff98Qgup6h9QX mHGT8IeMkE94rIrEf37RK6PIk4yh3DpkMm61QL6RLrQoZ3Xfbyd6DEWstKGAFTjIDPtx Es+d2rjsfSX/oKo9WbTDkHiepO4ecWnGyauxmoEc98JJxGLpNoZAXKNv1G0R/rRwCRak ZrLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=NS7T67Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg25-20020a170907971900b00718d02b47cesi9608181ejc.668.2022.06.19.00.42.03; Sun, 19 Jun 2022 00:42:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=NS7T67Pf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234566AbiFSHan (ORCPT + 99 others); Sun, 19 Jun 2022 03:30:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232443AbiFSHam (ORCPT ); Sun, 19 Jun 2022 03:30:42 -0400 Received: from mail-m964.mail.126.com (mail-m964.mail.126.com [123.126.96.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0E59FB1FD for ; Sun, 19 Jun 2022 00:30:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=B1gcf g6uWh2Ydy18lGJ3Uf96MEQ9OMrXAXzfxSAidlQ=; b=NS7T67PfHb3EfxrOk4hKM yiY3bYY7uhsTCxBQF0RnCkNcSGjfCKAcybHhfbD1Omw635Ffs10cOe1CfX6kS+oa hI//73I0bIlfqXc6Z9cHMHutTnnMZOtFM8NWzBQpyTO7Bg32wyo5FpO9bzsCVBTS 56avT8vTqgcIGFE6OsRWZU= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp9 (Coremail) with SMTP id NeRpCgBHEcad0K5iLak4FA--.119S2; Sun, 19 Jun 2022 15:30:37 +0800 (CST) From: Liang He To: dmitry.torokhov@gmail.com Cc: windhl@126.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] input/serio: Fix refcount leak bug in i8042-sparcio Date: Sun, 19 Jun 2022 15:30:36 +0800 Message-Id: <20220619073036.4067872-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NeRpCgBHEcad0K5iLak4FA--.119S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XFWkCrW7JFW3Cw4fJF1UZFb_yoWkZrX_ur Wkur97JFWkC3Zay3Z2yr4Sq390yw4vgayFqrySqr4a9a4ayr9xtryrZr97Aw47Wr9avryj krsxGrWFkw4UCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUUkhL7UUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi7R0lF1pEAOvxsgAAs0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In i8042_platform_init() and i8042_platform_exit(), we need call of_node_put() to keep refcount balance. Signed-off-by: Liang He --- drivers/input/serio/i8042-sparcio.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/input/serio/i8042-sparcio.h b/drivers/input/serio/i8042-sparcio.h index fce76812843b..a2a9db9220d7 100644 --- a/drivers/input/serio/i8042-sparcio.h +++ b/drivers/input/serio/i8042-sparcio.h @@ -108,6 +108,8 @@ static int __init i8042_platform_init(void) struct device_node *root = of_find_node_by_path("/"); const char *name = of_get_property(root, "name", NULL); + of_node_put(root); + if (name && !strcmp(name, "SUNW,JavaStation-1")) { /* Hardcoded values for MrCoffee. */ i8042_kbd_irq = i8042_aux_irq = 13 | 0x20; @@ -139,6 +141,8 @@ static inline void i8042_platform_exit(void) struct device_node *root = of_find_node_by_path("/"); const char *name = of_get_property(root, "name", NULL); + of_node_put(root); + if (!name || strcmp(name, "SUNW,JavaStation-1")) platform_driver_unregister(&sparc_i8042_driver); } -- 2.25.1