Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1875893iog; Sun, 19 Jun 2022 00:50:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vuIkRI1Y5qU62yLpcqxaoqFRZWp/yhCX/YIElUv4yHv4ISuFIEVuAltKOLemXC4sCzeXWf X-Received: by 2002:a17:903:187:b0:166:4360:a4fa with SMTP id z7-20020a170903018700b001664360a4famr18158981plg.87.1655625031677; Sun, 19 Jun 2022 00:50:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655625031; cv=none; d=google.com; s=arc-20160816; b=fRjoOuR78IGDkVObVuXom/SRZBayj1an3z2pjRooG2kbyzXDKbHaRyFYiEWBj8JQhS bsYQmj/bpYHcC1HAD409u/EKtAoTsW1pGO6mQjmHnwSNj4IAPvHsws99xi10kRGYAGHy zjOW5/BG0wPNDt0wOkLam6aK0VaKKalSqjfuivAKA/bG9RgelHcBur0i3aLxLUdSMtJS 5RbPoZWWmBYr8u+hlFYkFJPl7kSbvGp+dYv3RYJd1I+JOEYQMPB5neEd1PXqbXsienZz BOcMmYLeRIx1vaTYLzQIAuCjuppTJ7HLRwYo2vFZjQkLAFJye0wT7ewQ0OSVgq2osDJI jB4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2PsZdjyzRgibkKcfmt7102zdLXKY1lTTAZOE+Is/NfY=; b=gMhT10K7cAObcQEKKrnT6+UPkL/JwRIoxmQm6zmtOpHQhm9Np5k9qllxkwKZaUn7NM lMCQclUx4DpX2EYkHLdJm5WRojqcZxfvtLJvQKWesmEx4Avvr2pGbsLvZr4nInuXmV8O tHx9cthnpihcoKkXYjQ4PS89tU9YKxfMe30AiOM/+Rbz1Ooq7AedJod0YpWoHthVT5iw TAogynVP+Nc7yeeZzqHo23PF0yX31+LKfI1O5CAbXuqQng9EB/HpYfcEfPg7kQXzrLHM Z5NrhCJ0T8uOWq62xZsd1B/S8NpyhARc+2PrTNHZKd+GudDsTCgF0mRts0ceGpf6UKJN 2M4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=ZyWnJKg7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v10-20020a63610a000000b0040ca7c79d76si629943pgb.591.2022.06.19.00.50.19; Sun, 19 Jun 2022 00:50:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b=ZyWnJKg7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232977AbiFSHJY (ORCPT + 99 others); Sun, 19 Jun 2022 03:09:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234395AbiFSHJV (ORCPT ); Sun, 19 Jun 2022 03:09:21 -0400 Received: from mail-m965.mail.126.com (mail-m965.mail.126.com [123.126.96.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 10C83E0D3 for ; Sun, 19 Jun 2022 00:09:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=2PsZd jyzRgibkKcfmt7102zdLXKY1lTTAZOE+Is/NfY=; b=ZyWnJKg7i1LydfgwR3+bX MNsMFfGXnbaZ7KS+9bc1/zxhMeBq5mz1r8yYeO9454ZjuWxCrztVu0YMGJl+xDnu aSrxAvzk2JrYfb1kHZqz/omBY+HsyGRVrz5OxEPWviADSfqnHQAdgtKZJxYtylHH Qnd4CV/0jesR6dFybCeDkE= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp10 (Coremail) with SMTP id NuRpCgBnf4Bcy65ipKfMEw--.65437S2; Sun, 19 Jun 2022 15:08:12 +0800 (CST) From: Liang He To: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, christophe.leroy@csgroup.eu, npiggin@gmail.com Cc: windhl@126.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] powerpc: kernel: Fix refcount bug in legacy_serial.c Date: Sun, 19 Jun 2022 15:08:11 +0800 Message-Id: <20220619070811.4067215-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NuRpCgBnf4Bcy65ipKfMEw--.65437S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF17ArWUZr1UuF4xAFW8WFg_yoW3uwb_J3 s7Wr12kr1UWr4YvwnakFW5Gr4Yywn7Wa4FqFyq9343Ga4DKFsxGF17tFyqqr1DZws8JFZ3 CF93JF97Jw4v9jkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjFdyUUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbiuBwlF2JVj7Po9gAAsD X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In find_legacy_serial_ports(), of_find_node_by_path() will return a node pointer with refcount incremented. We should use of_node_put() when it is not used anymore. Signed-off-by: Liang He --- arch/powerpc/kernel/legacy_serial.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c index 5c58460b269a..f048c424c525 100644 --- a/arch/powerpc/kernel/legacy_serial.c +++ b/arch/powerpc/kernel/legacy_serial.c @@ -471,6 +471,8 @@ void __init find_legacy_serial_ports(void) } #endif + of_node_put(stdout); + DBG("legacy_serial_console = %d\n", legacy_serial_console); if (legacy_serial_console >= 0) setup_legacy_serial_console(legacy_serial_console); -- 2.25.1