Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com> <20220618214009.2178567-13-aidanmacdonald.0x0@gmail.com>
In-Reply-To: <20220618214009.2178567-13-aidanmacdonald.0x0@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Sun, 19 Jun 2022 13:02:52 +0200
Message-ID: <CAHp75VfgeCExmPto-9-Yfe1W=KfUdv=h+PK9vajp+aQ17vCGPg@mail.gmail.com>
Subject: Re: [PATCH v3 12/16] power: supply: axp20x_usb_power: Add support for AXP192
To:     Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Rafael J. Wysocki" <rafael@kernel.org>, quic_gurus@quicinc.com,
        Sebastian Reichel <sebastian.reichel@collabora.com>,
        Michael Walle <michael@walle.cc>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jun 18, 2022 at 11:40 PM Aidan MacDonald
<aidanmacdonald.0x0@gmail.com> wrote:
>
> The AXP192 is mostly the same as the AXP202 but has a different
> current limit.

...

> +       int ret = regmap_read(power->regmap, AXP20X_VBUS_IPSOUT_MGMT, &v);
> +
> +       if (ret)
> +               return ret;

Please, split assignment, so it will be like

  int ret;

  ret = ...
  if (ret)

...

> +static int axp192_usb_power_set_current_max(struct axp20x_usb_power *power,
> +                                           int intval)
> +{
> +       int val = AXP192_VBUS_CLIMIT_EN;
> +       const int mask = AXP192_VBUS_CLIMIT_EN | AXP192_VBUS_CLIMIT_100mA;
> +
> +       switch (intval) {
> +       case 100000:
> +               val |= AXP192_VBUS_CLIMIT_100mA;

> +               fallthrough;

It's harder to part and error prone, can't you simply call a
regmap_update_bits with different arguments?

With this suggestion consider the defaults like these:

      const int mask = AXP192_VBUS_CLIMIT_EN | AXP192_VBUS_CLIMIT_100mA;
      int val = mask;

Then use  val & ~AXP192_VBUS_CLIMIT_100mA in the below case.

> +       case 500000:
> +               return regmap_update_bits(power->regmap,
> +                                         AXP20X_VBUS_IPSOUT_MGMT, mask, val);
> +       default:
> +               return -EINVAL;
> +       }
> +}

-- 
With Best Regards,
Andy Shevchenko