Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 19 Jun 2022 13:44:43 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Shreeya Patel <shreeya.patel@collabora.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>, Zhigang.Shi@liteon.com,
        krisman@collabora.com, linux-iio <linux-iio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Collabora Kernel ML <kernel@collabora.com>,
        alvaro.soliverez@collabora.com, Dmitry Osipenko <digetx@gmail.com>,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v6 2/2] iio: light: Add support for ltrf216a sensor
Message-ID: <20220619134443.23874255@jic23-huawei>
In-Reply-To: <CAHp75VeU9oSJmMdyT_0BZDuG5WMiuJiCPv5So4DWG05EEDKrhw@mail.gmail.com>
References: <20220615135130.227236-1-shreeya.patel@collabora.com>
        <20220615135130.227236-3-shreeya.patel@collabora.com>
        <CAHp75VeU9oSJmMdyT_0BZDuG5WMiuJiCPv5So4DWG05EEDKrhw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk


> 
> > +       /* reset sensor, chip fails to respond to this, so ignore any errors */
> > +       ltrf216a_reset(indio_dev);
> > +
> > +       ret = pm_runtime_set_active(&client->dev);
> > +       if (ret)
> > +               goto error_power_down;  
> 
> Why do you need to power down here?
> 
> > +       pm_runtime_enable(&client->dev);

We now have devm_pm_runtime_enable() which will also deal
with disabling use_autosuspend for you and should help you
sort out some of the ordering.


> > +       pm_runtime_set_autosuspend_delay(&client->dev, 5000);
> > +       pm_runtime_use_autosuspend(&client->dev);
> > +
> > +       ltrf216a_set_power_state(data, true);  
> 
> The below code suggests that you are mixing badly devm_ with non-devm_
> APIs, don't do this. You have to group devm_ first followed by
> non-devm_ calls.
> 
> ...
> 
> > +static int ltrf216a_remove(struct i2c_client *client)
> > +{
> > +       struct iio_dev *indio_dev = i2c_get_clientdata(client);
> > +
> > +       iio_device_unregister(indio_dev);
> > +       pm_runtime_disable(&client->dev);
> > +       pm_runtime_set_suspended(&client->dev);
> > +       ltrf216a_disable(indio_dev);
> > +
> > +       return 0;  
> 
> I believe the ordering of freeing resources and reverting state is not
> in reverse. See above why.

In particular you are calling disable there which is already handled
by devm_ unwinding.
> 
> > +}  
>