Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220618214009.2178567-1-aidanmacdonald.0x0@gmail.com>
 <20220618214009.2178567-12-aidanmacdonald.0x0@gmail.com>
 <20220619121315.203a709b@jic23-huawei>
From:   Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, wens@csie.org,
        lee.jones@linaro.org, sre@kernel.org, broonie@kernel.org,
        gregkh@linuxfoundation.org, lgirdwood@gmail.com, lars@metafoo.de,
        rafael@kernel.org, quic_gurus@quicinc.com,
        sebastian.reichel@collabora.com, andy.shevchenko@gmail.com,
        michael@walle.cc, linux-gpio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 11/16] iio: adc: axp20x_adc: Add support for AXP192
Date:   Sun, 19 Jun 2022 16:11:51 +0100
In-reply-to: <20220619121315.203a709b@jic23-huawei>
Message-ID: <9VAa62XhSlCMAJF7vdE7bHGSg95FKyr6@localhost>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Jonathan Cameron <jic23@kernel.org> writes:

> On Sat, 18 Jun 2022 22:40:04 +0100
> Aidan MacDonald <aidanmacdonald.0x0@gmail.com> wrote:
>
>> The AXP192 is identical to the AXP20x, except for the addition of
>> two more GPIO ADC channels.
>> 
>> Signed-off-by: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>
> Hi Aidan,
>
> Looking at this again, I'd have a slight preference for doing the switch to
> adc_en2_mask as a precursor patch.

I might as well, it's a bit cleaner that way.

>
> Still, not a big thing (and I should have raised it earlier!) so up to you.
> Either way
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Thanks,
>
> Jonathan