Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2225440iog; Sun, 19 Jun 2022 10:54:09 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vKnnITC70cIGSNySVW4j3KeYpuoja55wVNmqYxogLmy1a66cMtmxaq8O+YuhEBeBXSE1a8 X-Received: by 2002:a17:907:7fa9:b0:711:d214:36cd with SMTP id qk41-20020a1709077fa900b00711d21436cdmr17293480ejc.600.1655661249066; Sun, 19 Jun 2022 10:54:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655661249; cv=none; d=google.com; s=arc-20160816; b=khN/XiSdIR/KIQpIkSTdL/5B8TtMvUkvA8usLunkQiiliL2lWVOwepr5mWoM652e/4 TZtoX1jygfFeg7G4Y3MCotQiUmj9aXE4cbpTGZYPnmYW72tmtKWWkplsuOJ4ZOEnniAJ bKOem5gJ3Y4qum1qm+T41wHCOGm+1xekbbQL3hqxqxuz9xna078VSLGI8+MxoI3bO13z jl/iavDBrP6yHPUa5Nwp7wSFCysmBWKRwg4nGa+Ql0L2q6NqE2GO2vsUAr3x3L8tyNL1 JaEBhb9chZSO68UN+def3i+szSdy0nyVXPvBiJGM4bvfu0pjwvg1hWj4DzE92pSMwo/d jnoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:to:from:subject:cc :message-id:date:content-transfer-encoding:mime-version; bh=0XJXG/EY8ljJTTO/QrQK1xfZt0d9TSDguyon3yECYtE=; b=ayhRUPOivVU4GKJPjTwLjr7FnVcXwJzP3YxJyDk61ZiOQZesI/oKSbbX/bJQV79eXk Ex2kpEkIrlOkY+h41NYF90R8WG7+SNxNJzj4EAelcd15Zk8hToeDUdoqXmMKesJX73FU sy1IX5WdLMMvDQTxsG3HDTr0I9sW0JHM9J6eItY2fHjN/ifAXQ7oFEZTMT8CBw2267Oh O2V8MltWpaxtv/O7M+GICXJvB+RUXZUmv6/Nng/pxseeMXtPElIqAXVHD5unH/Ot79b9 HUXC6cd958rKzLB669Z4iRpM6Ey1VDk5bTWiLbEcubuwQ1FeJLAFIO4XvBWwLym9S8Sm nOmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a170906518800b0070cf41be558si7964723ejk.376.2022.06.19.10.53.44; Sun, 19 Jun 2022 10:54:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235253AbiFSQpA convert rfc822-to-8bit (ORCPT + 99 others); Sun, 19 Jun 2022 12:45:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbiFSQo6 (ORCPT ); Sun, 19 Jun 2022 12:44:58 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 586F8D119; Sun, 19 Jun 2022 09:44:57 -0700 (PDT) Received: (Authenticated sender: pbl@bestov.io) by mail.gandi.net (Postfix) with ESMTPSA id AEBAA1BF209; Sun, 19 Jun 2022 16:44:52 +0000 (UTC) Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset=UTF-8 Date: Sun, 19 Jun 2022 18:44:51 +0200 Message-Id: Cc: , , , , , , , , , Subject: Re: NEEDS FIXING - Was: Re: [PATCH v2] ipv4: ping: fix bind address validity check From: "Riccardo Paolo Bestetti" To: "Jakub Kicinski" X-Mailer: aerc 0.9.0 References: <20220617085435.193319-1-pbl@bestov.io> <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org> <20220617195816.53a2f2cf@kernel.org> In-Reply-To: <20220617195816.53a2f2cf@kernel.org> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat Jun 18, 2022 at 4:58 AM CEST, Jakub Kicinski wrote: > On Sat, 18 Jun 2022 02:32:55 +0200 Riccardo Paolo Bestetti wrote: > > I receompiled the kernel from the net tree to do some more manual testing > > on the patch and I have two things to disclose. Sorry for the caps in > > the subject. > > > > TL;DR: I noticed that one of the regressions tests is (correctly) > > failing, but for the wrong reasons; and the patch I sent contains a > > mistake, and unfortunately it has already been applied to the tree as > > commit b4a028c4d0. > > > > Long version below. > > > > 1) If you run regression tests with -v, the (correct -- see below) ICMP > > tests for broadcast and multicast binding do not fail with > > EADDRNOTAVAIL, but with ACCES, but only when run through fcnal-test.sh. > > This is also true for one of the additional (commented out) tests you > > can find in my patch following this email. I'm not sure why this > > happens; however I'm reasonably convinced it is a quirk or a consequence > > of the testing methodology/setup. Can anyone offer any insights? > > > > 2) My patch is faulty. I had a complete and tested patch, including code > > fixing the regression. Instead of sending it, however, I decided to > > adapt it to preserve Carlos Llamas' version of ping.c, since they posted > > their patch first. In doing so I used a work branch which contained a > > faulty version (wrong flags) of the regression tests. The resulting > > faulty patch is, unfortunately, currently in the tree. > > > > At this point, due to the unfortunate combination of (1) and (2), it > > might be worth reverting the patch altogether and just applying the v1 > > (i.e. without the regression tests) to the tree and to the relevant LTS > > versions. > > IIUC only the test is faulty / unreliable, correct? > > We have until Thursday before this patch hits Linus's tree so should > be plenty of time to figure the problem out and apply an incremental > fix. I see you posted an RFC already, thanks! I followed that up with a v2 [1] that looks good to me. Fixes the fulty tests covering the regression, adds a couple more tests similar to what I added back in November (but for different code paths). As an additional note, if the regression fix (b4a028c4d0) is candidate for the LTS, then this patch should probably be as well. Riccardo P. Bestetti [1]: https://patchwork.kernel.org/project/netdevbpf/patch/20220619162734.113340-1-pbl@bestov.io/ > > > After that, a more proper discussion can be had about (1), and the > > regression tests can be fixed. I'm sending a demonstrative patch for > > that as a response to this message.