Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2297881iog; Sun, 19 Jun 2022 13:17:03 -0700 (PDT) X-Google-Smtp-Source: AGRyM1viVfPoZBDPb39u4rHb6nNYRGa6bsmlXnqCe/lBdJVJ8fVDeoKqtTYLfTOz1XfXEE5TuXrR X-Received: by 2002:a17:90b:2688:b0:1ec:8d19:1da5 with SMTP id pl8-20020a17090b268800b001ec8d191da5mr8880459pjb.114.1655669823124; Sun, 19 Jun 2022 13:17:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655669823; cv=none; d=google.com; s=arc-20160816; b=L78yLvQrLa+ch/1GhM91nemu33AOzbm0WVxWsMfsFelEh9xxiyMV7IHoZkhxeg1u1c VLbN0V9IGTBt3yq3sGbNgf6WmgkEJVG9Klmg1T0JopksLlKOfL8sZEQXHI/6NvdcXKrg A8anPdQkfc/DwjMhsW1eNtJ6oU/PXbx6SQyL+Bcki2QDEPatE6s6G9UAnSnc95LUg064 86HCSLNUVsUF7ZESfU+wQp1mP7ub/3luybwcDUc6sf2uxhHm6kaqOCCxlJDnjUpWj6L5 tA2nrGjA2fGr47YmbES7VOSregffMiqNkuZ77uMftrnb0uzhcOD0rm7PZ9i4EQ0VPouX mIOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1QG1QV5jcE/qCLfJfakMMrZfmCDBIgHiC1TqIeZ6eiw=; b=aQdoLaBbOvwWOXkE/hwNCJ4F1EQSMRsHZOa5CPR4JUdfKcpNNORusFSk90PdS79n+A 9U7y5GPbHUC4gN4/hiMwBxpKw9SmfaccPW9fOj23BSqkt/lj4czGDhZEvShMtfyGWqnb 4MAO6787k876F4Z1D9kG0yhTbyrR6sCct1D4iK08zcLhz/0zvMqZNx8XplTSls3lqria q6aCyaEP6XkwKj0kDTcIrO3L/Mj3VftEd8zJ8sql1RpwkFEOhumIRgg1QOLAOLNaKIB7 7cqgi2p49l9/3Udd4ZjBfVsrDdrof27sVNb2Ur9bDV4lP4p10C02uXp7h1IJfgXo6b5n ZIBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Bg5wNP2v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z15-20020a65610f000000b00407d7650523si13978035pgu.455.2022.06.19.13.16.51; Sun, 19 Jun 2022 13:17:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Bg5wNP2v; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235877AbiFSTnM (ORCPT + 99 others); Sun, 19 Jun 2022 15:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234744AbiFSTnB (ORCPT ); Sun, 19 Jun 2022 15:43:01 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 686076350 for ; Sun, 19 Jun 2022 12:43:00 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id s185so2738733pgs.3 for ; Sun, 19 Jun 2022 12:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1QG1QV5jcE/qCLfJfakMMrZfmCDBIgHiC1TqIeZ6eiw=; b=Bg5wNP2vtH4T5PvHSN81HgF4Uq+0i1xgkp7/rVE1jy1X7tSe1mgVoMRU34u5KY6iMP XMYUI5pRSUiHRzHyYcXZyP+5PmaKwWlA/owFceB9cXDNkWntzekvzSDCpbvFqaJcNyhp zzvYj/jDCf9PbS7McbEgvyEgSf7afOhu+tZXwFWQIPocHx720KDHhGMpDvcwRvfosY7s uWNdPZtMOGsKtT1bqJZdSqwBaPi5IMvm/6flXaE8T7hPaSRf5hHMVZg570GWmcXmWQD7 H1yLXbefH6NIGPYxYyr959h/+CJjY8H0EfikLjQLkCqUd2VCgm15pCkrLSglyi0Y38vg Qs0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1QG1QV5jcE/qCLfJfakMMrZfmCDBIgHiC1TqIeZ6eiw=; b=InLt9nsLbGKyPPBeJAb0T+PsPNTeXqvSOeHsCVUz1vdgUo3QzCK+/A36DXyQNBspNg IP0IjzsyJSb1/UVLntNOzC86AkEt5g04Di5qFCkhLTd5MCFNpjsFtCLjMvtaXVZiJVkC 1wQSHNiTyIbr5GoqSc006AP5hNgIEvmTT4M3GV2KsvI3/DA4uw/CVvLFlyNeiM09GUPK vmQzsBRZFIpbQs5fN60LrksvctqqepLl+4Pr4objtZdR7SwmBlYjqBVnY+nOayOkD5LN UI0fk9VBEmTC1qCQcQaj4K8+qPCfG6gV3Sli2P7fggQxVzdmGbQUZMdnBhMCk4017ZgJ V7qg== X-Gm-Message-State: AJIora+fyGWyUyTOzJOHD+3d8PqdWz2ZBRfK29dzkC7fkL+g5tGs53ZZ //r7Dqq+sCrGSeDAPEnBKeE= X-Received: by 2002:a63:7d44:0:b0:40c:8cb1:eeaa with SMTP id m4-20020a637d44000000b0040c8cb1eeaamr6450551pgn.597.1655667779852; Sun, 19 Jun 2022 12:42:59 -0700 (PDT) Received: from localhost (c-67-180-87-133.hsd1.ca.comcast.net. [67.180.87.133]) by smtp.gmail.com with ESMTPSA id i185-20020a626dc2000000b0051bf9159d2dsm7406414pfc.208.2022.06.19.12.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 12:42:59 -0700 (PDT) From: Chang Yu To: Larry.Finger@lwfinger.net, paskripkin@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Chang Yu Subject: [PATCH v2 5/5] Staging: r8188eu: core: rtw_xmit: Fixed a coding style issue Date: Sun, 19 Jun 2022 12:42:31 -0700 Message-Id: X-Mailer: git-send-email 2.36.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moved the constant ETH_P_IP to the right hand side of the comparison as per checkpatch.pl Signed-off-by: Chang Yu --- drivers/staging/r8188eu/core/rtw_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/core/rtw_xmit.c b/drivers/staging/r8188eu/core/rtw_xmit.c index 6797335f7855..943422141c8b 100644 --- a/drivers/staging/r8188eu/core/rtw_xmit.c +++ b/drivers/staging/r8188eu/core/rtw_xmit.c @@ -443,7 +443,7 @@ static s32 update_attrib(struct adapter *padapter, struct sk_buff *pkt, struct p pattrib->pktlen = pktfile.pkt_len; - if (ETH_P_IP == pattrib->ether_type) { + if (pattrib->ether_type == ETH_P_IP) { /* The following is for DHCP and ARP packet, we use cck1M to tx these packets and let LPS awake some time */ /* to prevent DHCP protocol fail */ u8 tmp[24]; -- 2.36.1