Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763148AbXEXF3G (ORCPT ); Thu, 24 May 2007 01:29:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758517AbXEXF2y (ORCPT ); Thu, 24 May 2007 01:28:54 -0400 Received: from shawidc-mo1.cg.shawcable.net ([24.71.223.10]:42384 "EHLO pd4mo1so.prod.shaw.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758447AbXEXF2x (ORCPT ); Thu, 24 May 2007 01:28:53 -0400 Date: Wed, 23 May 2007 23:28:50 -0600 From: Robert Hancock Subject: Re: [PATCH] [scsi] Remove __GFP_DMA In-reply-to: To: Alan Cox Cc: "Salyzyn, Mark" , James Bottomley , Aubrey Li , Christoph Lameter , Bernhard Walle , linux-scsi@vger.kernel.org, Andrew Morton , linux-kernel@vger.kernel.org Message-id: <46552292.3090207@shaw.ca> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit References: User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 31 Alan Cox wrote: > On Wed, 23 May 2007 15:17:08 -0400 > "Salyzyn, Mark" wrote: > >> The 31 bit limit for some of these cards is a problem, we currently only >> do __GFP_DMA for bounce buffer sg elements allocated for user supplied >> references in ioctls. >> >> I figure we should be using pci_alloc_consistent calls for these >> allocations to more accurately acquire memory within the 31 bit limit if >> necessary, we could switch to these to remove the need for the __GFP_DMA >> flag in the aacraid driver? > > That didn't used to work right on the AMD boards when I tried it last as > we ended up with a buffer that was mapped by the IOMMU for some reason > and that was not below 2GB. The physical address you mean? If that is still happening then it needs to get fixed. The allocation should not succeed if it can't provide memory that's inside the DMA mask for the device.. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/