Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 09:34:24 +1000
From:   Stephen Rothwell <sfr@canb.auug.org.au>
To:     David Miller <davem@davemloft.net>
Cc:     Networking <netdev@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: linux-next: build failure after merge of the net-next tree
Message-ID: <20220620093424.0615a374@canb.auug.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/4DCfUCSlQH8GtJ8aX_cx.qX";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Precedence: bulk

--Sig_/4DCfUCSlQH8GtJ8aX_cx.qX
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

net/ipv4/raw.c: In function 'raw_icmp_error':
net/ipv4/raw.c:266:9: error: ISO C90 forbids mixed declarations and code [-=
Werror=3Ddeclaration-after-statement]
  266 |         struct hlist_nulls_head *hlist;
      |         ^~~~~~
cc1: all warnings being treated as errors

Introduced by commit

  ba44f8182ec2 ("raw: use more conventional iterators")

I have applied the following patch for today.

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 20 Jun 2022 09:21:01 +1000
Subject: [PATCH] raw: fix build error

The linux-next x86_64 allmodconfig build produced this error:

net/ipv4/raw.c: In function 'raw_icmp_error':
net/ipv4/raw.c:266:9: error: ISO C90 forbids mixed declarations and code [-=
Werror=3Ddeclaration-after-statement]
  266 |         struct hlist_nulls_head *hlist;
      |         ^~~~~~
cc1: all warnings being treated as errors

Fixes: ba44f8182ec2 ("raw: use more conventional iterators")
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 net/ipv4/raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index d28bf0b901a2..b3b255db9021 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -262,7 +262,7 @@ static void raw_err(struct sock *sk, struct sk_buff *sk=
b, u32 info)
=20
 void raw_icmp_error(struct sk_buff *skb, int protocol, u32 info)
 {
-	struct net *net =3D dev_net(skb->dev);;
+	struct net *net =3D dev_net(skb->dev);
 	struct hlist_nulls_head *hlist;
 	struct hlist_nulls_node *hnode;
 	int dif =3D skb->dev->ifindex;
--=20
2.35.1

--=20
Cheers,
Stephen Rothwell

--Sig_/4DCfUCSlQH8GtJ8aX_cx.qX
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmKvsoAACgkQAVBC80lX
0GwhXQgAgW6VnNxSLdSjFSsZxN2oozgsu0RTviMHE7u2sKOO72cj8BOOiSen6QyO
UF9a0iHDjIJoJ9QuhPiqeUfsVdQge4HlzKdIkOOI9/lkbDPscZowD23UEKnjhmP6
+nlOSGQ1kusToP+RfGh+ust+0Jza9B5BWYaNoaCSpnXE6V12nfXt43rhvdRV9FE4
SqUztSK+YZuwRGUg/axsFbsxaPWjyEQyZ0eHFD/4r2koWhbtFPSrU+uWKCE9CDfo
pf/EtnvwK90mMStRjx5Q9Ko4kwzDpQ7CvNP0D2g1X7k3SvjE5KSJ504s92KFqdEb
InH/tFb8SzNKNr/Ss/24xSW43ajZUQ==
=Whmj
-----END PGP SIGNATURE-----

--Sig_/4DCfUCSlQH8GtJ8aX_cx.qX--