Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1655288134-14083-1-git-send-email-shengjiu.wang@nxp.com>
 <1655288134-14083-2-git-send-email-shengjiu.wang@nxp.com> <20220620004116.GP254723@dragon>
In-Reply-To: <20220620004116.GP254723@dragon>
From:   Shawn Guo <shawnguo@kernel.org>
Date:   Mon, 20 Jun 2022 08:45:18 +0800
Message-ID: <CAJBJ56Lop+_NxOWeQB7y6ODJe=-hV3pC1+M6JPr=9-kXSpGR+Q@mail.gmail.com>
Subject: Re: [PATCH 1/3] arm64: dts: imx8mm-evk: add bt-sco sound card support
To:     Shengjiu Wang <shengjiu.wang@nxp.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org, shengjiu.wang@gmail.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 20, 2022 at 8:41 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Wed, Jun 15, 2022 at 06:15:32PM +0800, Shengjiu Wang wrote:
> > Add bt-sco sound card, which supports wb profile as default
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 43 +++++++++++++++++++
> >  1 file changed, 43 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > index c42b966f7a64..d99b562bb00e 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> > @@ -75,6 +75,11 @@
> >               linux,autosuspend-period = <125>;
> >       };
> >
> > +     bt_sco_codec: bt_sco_codec {
>
> Generic node name, maybe 'audio-codec'?

I see.  There is already an 'audio-codec' node for wm8524.  Maybe
'audio-codec-bt-sco'?  In any case, hyphen is more recommended than
underscore in node names.

Shawn

> > +             #sound-dai-cells = <1>;
> > +             compatible = "linux,bt-sco";
> > +     };
> > +
> >       wm8524: audio-codec {
> >               #sound-dai-cells = <0>;
> >               compatible = "wlf,wm8524";
> > @@ -107,6 +112,25 @@
> >                       clocks = <&clk IMX8MM_CLK_SAI3_ROOT>;
> >               };
> >       };
> > +
> > +     sound-bt-sco {
> > +             compatible = "simple-audio-card";
> > +             simple-audio-card,name = "bt-sco-audio";
> > +             simple-audio-card,format = "dsp_a";
> > +             simple-audio-card,bitclock-inversion;
> > +             simple-audio-card,frame-master = <&btcpu>;
> > +             simple-audio-card,bitclock-master = <&btcpu>;
> > +
> > +             btcpu: simple-audio-card,cpu {
> > +                     sound-dai = <&sai2>;
> > +                     dai-tdm-slot-num = <2>;
> > +                     dai-tdm-slot-width = <16>;
> > +             };
> > +
> > +             simple-audio-card,codec {
> > +                     sound-dai = <&bt_sco_codec 1>;
> > +             };
> > +     };
> >  };
> >
> >  &A53_0 {
> > @@ -346,6 +370,16 @@
> >       status = "okay";
> >  };
> >
> > +&sai2 {
> > +     #sound-dai-cells = <0>;
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&pinctrl_sai2>;
> > +     assigned-clocks = <&clk IMX8MM_CLK_SAI2>;
> > +     assigned-clock-parents = <&clk IMX8MM_AUDIO_PLL1_OUT>;
> > +     assigned-clock-rates = <24576000>;
> > +     status = "okay";
> > +};
> > +
> >  &sai3 {
> >       pinctrl-names = "default";
> >       pinctrl-0 = <&pinctrl_sai3>;
> > @@ -494,6 +528,15 @@
> >               >;
> >       };
> >
> > +     pinctrl_sai2: sai2grp {
> > +             fsl,pins = <
> > +                     MX8MM_IOMUXC_SAI2_TXC_SAI2_TX_BCLK      0xd6
> > +                     MX8MM_IOMUXC_SAI2_TXFS_SAI2_TX_SYNC     0xd6
> > +                     MX8MM_IOMUXC_SAI2_TXD0_SAI2_TX_DATA0    0xd6
> > +                     MX8MM_IOMUXC_SAI2_RXD0_SAI2_RX_DATA0    0xd6
> > +             >;
> > +     };
> > +
> >       pinctrl_sai3: sai3grp {
> >               fsl,pins = <
> >                       MX8MM_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC     0xd6
> > --
> > 2.17.1
> >