Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH v10 2/8] fork/vm: Move common PF_IO_WORKER behavior to new flag
Date:   Sun, 19 Jun 2022 20:13:51 -0500
Message-Id: <20220620011357.10646-3-michael.christie@oracle.com>
In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com>
References: <20220620011357.10646-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4D2/6Muc6qz14E2uZE1mktqlHGVRTlU+oH9gMFqEiDAcpOeJnrtq0EQdm1fK?=
 =?us-ascii?Q?aLzDkaGoAdVJGYqDFqsI3HB0yGR8QrokoJSWCYVLegl+oGZPSqoqXNBeG4YC?=
 =?us-ascii?Q?mHc6YXtLNlARsHl9pyrqodH6NK5ioL4hMsmGsCJUv381yar5TOLvOMi/F8rH?=
 =?us-ascii?Q?e43AlmE07nBQ19BqdT/YWfZXCcEo2Khj5LZfAdfTrVfbObOYuxl2uthrJ7Z4?=
 =?us-ascii?Q?c0hXmUG3mpDCbeykvH5tgP1wm0goTPSob61Y0yQbfHCh6aEjnb5uJI8VW4iP?=
 =?us-ascii?Q?ZFntralY7M4GitDZVU6Km04xcnFMKkv+BRldA09Q4x4iii32slJWpVaQAiae?=
 =?us-ascii?Q?Q97PJB5NNWiemOxkFa5SzCfnYQfjHuQTRiQDNziTMIFE3pLDC6ftYKSNQ62u?=
 =?us-ascii?Q?jsoRjRU5INNfQbjGv8ABJp/0vQ/fUD/vCgTip0JtSRZ0t8Ggly9oBEkdOxz0?=
 =?us-ascii?Q?hhTaoRMnWBr5C/zBpJbQeKlKwdJmNeJ4/jwUhr36gdKUqvEHmmCzUQQIKyDs?=
 =?us-ascii?Q?LgbbA6InPLlAbRmpwoleLkwd3IPZCnu9TsRRpMAbWRRAlSAHHHO8TPEoM680?=
 =?us-ascii?Q?EhG35loSuyaAtw1a5NLkzZPjYC3IzKUJtMKC33DKS4bZ5X1lQ21LDO0oi7LU?=
 =?us-ascii?Q?E+vXCBawbUVvNuGYv+DG3kzw4LK4Ka+1w3e5qIp7AynaK/kdQ2/HYKIiEade?=
 =?us-ascii?Q?RQMXG3zjDUDhVZycf2/elfH4p6H3QWshTsFHRiIm5/D0kgavNPVW2PKP0Eq+?=
 =?us-ascii?Q?YjdXFvyIXDcYax7tgRi25ixFk8eCGCj2xtsBwvHvvv/nCdFZXFUc9TWpBIRA?=
 =?us-ascii?Q?aWnkYvlzihbSiVQpcyoJp9s9hY9AOZ+uNYv0Kq7vclvYdriFCu9JoM7U58lD?=
 =?us-ascii?Q?Ii8h3HrRXVS5wWz+stN/ZuZXKZUtjWDN+/d3fVO+i4BhPem1HxxpL255d69a?=
 =?us-ascii?Q?EJ3CMNB6HBqwjUMddcGTA0d3B6PnZJKzP7Vm7tzqnFNKwktuBjAw5P8OerFk?=
 =?us-ascii?Q?kGX+45eCnegj7Xmz7baxUefiUdNRLMPc0IhRiLlo5iw2aYUz5aOLRdCJnjBH?=
 =?us-ascii?Q?gIFMpRqk14k3VDz1Zm1jpkbP4cx772aWlM9rFsr6oLF43/x9EoM6sgwR1phk?=
 =?us-ascii?Q?UYZ2/duCBkRFifAiy2u9Y+Z3zuV0zm08J8DMepxsyzOL7W77XLAhfnoqGny3?=
 =?us-ascii?Q?ONWOkLFB2vehTFQrUKRVTQ8GWIyOxjaXQIfE1Zki/m7in5R7MxFDfttxlrtc?=
 =?us-ascii?Q?TsoCQSwrLZDvxiAKrhS+9bHaMRoi0oODmVC/0+hCy7xZNGJoSi1iLcB9Munw?=
 =?us-ascii?Q?CCyvQM/jzQhaamyp+cQcPh0pPNzzVWnxSoQYyq0foNP1ed07uPanCLOrdVi+?=
 =?us-ascii?Q?a73TPEmoIy0Wyj3TeyllJ6Uk4ZsKTy/+w2IejdN1CFSht5lJRaiOpS60r62V?=
 =?us-ascii?Q?vRUOyRLEe5tsxGOf9vm7L1aluk/TD2LBFwG3RbN2IHXkUTaQJpwxj+U9zqDX?=
 =?us-ascii?Q?sGV10frtv4nEJEQ99f8hyhaQQhWMKj1VZBrthwDavSfQ1nPAxObJjSjJvKrT?=
 =?us-ascii?Q?Ll7a55KVGzdRhYI725BAvN/IEQ949XYIt1R9pYtLDyqp0T0YkOTUSmt8aAYV?=
 =?us-ascii?Q?gTyaye2+AXSA4EZ8ZpUubohq7bSCSpqtXXEz1LgXUNRs+ytKLo5mR+Pxr5ha?=
 =?us-ascii?Q?vpcCbJY620pshvGAL0x1JXpJ7i11WfaBWTxvOkkAWTEgJ4x3Vcft4YM8QkRa?=
 =?us-ascii?Q?ipyp0XFr3yE92ppbeP2JLa4ugoZVvoY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9b2048f-d58e-4898-3a7b-08da525a2c28
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:06.9433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OCpsKHrCnA0zFwVV3sk6jfFkAJnxw1fIGIO/nXiG0+K20kD0Y+fJkUzeMgehc/LYtdZdicDbOpZ+gcC25VK8FTEGKOsyxw7+1WMsIS2DkR4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1466
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206200004
X-Proofpoint-ORIG-GUID: ez-tNgAa_x1YxVB3b2LdxdCSHElmsmCI
X-Proofpoint-GUID: ez-tNgAa_x1YxVB3b2LdxdCSHElmsmCI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This adds a new flag, PF_USER_WORKER, that's used for behavior common to
to both PF_IO_WORKER and users like vhost which will use a new helper
instead of create_io_thread because they require different behavior for
operations like signal handling.

The common behavior PF_USER_WORKER covers is the vm reclaim handling.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/sched.h      | 1 +
 include/linux/sched/task.h | 3 ++-
 kernel/fork.c              | 4 ++++
 mm/vmscan.c                | 4 ++--
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index c46f3a63b758..d7cd2037430b 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1701,6 +1701,7 @@ extern struct pid *cad_pid;
 #define PF_MEMALLOC		0x00000800	/* Allocating memory */
 #define PF_NPROC_EXCEEDED	0x00001000	/* set_user() noticed that RLIMIT_NPROC was exceeded */
 #define PF_USED_MATH		0x00002000	/* If unset the fpu must be initialized before use */
+#define PF_USER_WORKER		0x00004000	/* Kernel thread cloned from userspace thread */
 #define PF_NOFREEZE		0x00008000	/* This thread should not be frozen */
 #define PF_FROZEN		0x00010000	/* Frozen for system suspend */
 #define PF_KSWAPD		0x00020000	/* I am kswapd */
diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index b0a9d6c75bcc..9e20fa18c41f 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -18,7 +18,8 @@ struct css_set;
 /* All the bits taken by the old clone syscall. */
 #define CLONE_LEGACY_FLAGS 0xffffffffULL
 
-#define USER_WORKER_IO		BIT(0)
+#define USER_WORKER		BIT(0)
+#define USER_WORKER_IO		BIT(1)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 49fedb79925b..604c7f3cdde8 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2074,6 +2074,10 @@ static __latent_entropy struct task_struct *copy_process(
 	p->flags &= ~PF_KTHREAD;
 	if (args->kthread)
 		p->flags |= PF_KTHREAD;
+
+	if (args->worker_flags & USER_WORKER)
+		p->flags |= PF_USER_WORKER;
+
 	if (args->worker_flags & USER_WORKER_IO) {
 		/*
 		 * Mark us an IO worker, and block any signal that isn't
diff --git a/mm/vmscan.c b/mm/vmscan.c
index f7d9a683e3a7..6d771d8a3a4a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1047,12 +1047,12 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan_throttle_state reason)
 	DEFINE_WAIT(wait);
 
 	/*
-	 * Do not throttle IO workers, kthreads other than kswapd or
+	 * Do not throttle user workers, kthreads other than kswapd or
 	 * workqueues. They may be required for reclaim to make
 	 * forward progress (e.g. journalling workqueues or kthreads).
 	 */
 	if (!current_is_kswapd() &&
-	    current->flags & (PF_IO_WORKER|PF_KTHREAD)) {
+	    current->flags & (PF_USER_WORKER|PF_KTHREAD)) {
 		cond_resched();
 		return;
 	}
-- 
2.25.1