Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mike Christie <michael.christie@oracle.com>
To:     hch@infradead.org, stefanha@redhat.com, jasowang@redhat.com,
        mst@redhat.com, sgarzare@redhat.com,
        virtualization@lists.linux-foundation.org, brauner@kernel.org,
        ebiederm@xmission.com, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>,
        Christoph Hellwig <hch@lst.de>
Subject: [PATCH v10 3/8] fork: add USER_WORKER flag to not dup/clone files
Date:   Sun, 19 Jun 2022 20:13:52 -0500
Message-Id: <20220620011357.10646-4-michael.christie@oracle.com>
In-Reply-To: <20220620011357.10646-1-michael.christie@oracle.com>
References: <20220620011357.10646-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cH/3LCZBNvT60eeuYwMlc4QL6dIMXqs/4qCk/yK+vHJ+tj7RELRHD7KGt6fj?=
 =?us-ascii?Q?oh0sMm0+3jgDmCj2KeLXCK+zZyE14aVAupovDUw0I5ppCgtVGllcx+u6wdki?=
 =?us-ascii?Q?jpQu7ytmXwjAYg5eET4Soj5CiSbBIYjtVIuVtAe8BkxF0usTm5S5Q7XbhZfX?=
 =?us-ascii?Q?0JQtTFEdhiWwvAgEc2794HcG09fa200+O9KkRUyj8KymJZ9q4tL7/Rn/IduD?=
 =?us-ascii?Q?7CTmro543+oF5ifrastow4ZXfnoaWLwhXIvSAHMTKymo+9elsHtTd2TsanB0?=
 =?us-ascii?Q?+Y8Cx+nb8A6phi7oldiiQLjTnDtbbyTm3X+NdaB7hm+H/RCJO/W3aXPG5tKg?=
 =?us-ascii?Q?v/YxJlMifEGmqUNCkDMzPgL7O721qTB58dlmW1p9kanlksj3HEdL1hKud8R1?=
 =?us-ascii?Q?BGY6q3I+zuifNnHAJZ9Tl+LVjqOZmbGL2ekjGn7A79D6jVHp6PvCwBLI7R26?=
 =?us-ascii?Q?Pi6pxtVLbxTKlzf/VVT/XdXZ1eu5/2Dw7MxfRxHeRWAap/TjY48s1xjrCdDF?=
 =?us-ascii?Q?gJ3kl3AK+TnqFvht1P2dl6dJTZzD6BW23IayArx7TW+4wxa1J/MhbqkwDgCU?=
 =?us-ascii?Q?XuzibZrK9mhFkseqr8ncd/E4iBg58Lk2FUl2fQv4zK4KbHZy8MZNasnPXY77?=
 =?us-ascii?Q?tFmn6MbA3R+m/kd/qevIkQ+Aj3rNKNmvnwpfY7CIfx+NmKseMhAyw+WXTQRW?=
 =?us-ascii?Q?Yt4RYcEyc79kizoeQPt1vTFFsz4hMz/hkBlzgtXvBr2Xu+nOdDq40SdQvqjt?=
 =?us-ascii?Q?aFm1K4EdGkwfjlzOxyaC8b991cM5FcKm9zYcx8ywSI0BXjenB89rJB78rK3Q?=
 =?us-ascii?Q?TNmGzHWeyQqXUGGoSWTNIHFpDx3gvyO9fTbbICtyhtTXlegHnuTh5F5MGlNB?=
 =?us-ascii?Q?hRQtT2WGV3/AI2LTWvfIKMsobEL9VGZDUifrlUfNyzEsz77crTDCPu1D393Y?=
 =?us-ascii?Q?aiFWLAFov6jLWjsbi3qPS5QAZc5RKZAUZDfb1s6cy4P/IepF9FQ9ucreT1FT?=
 =?us-ascii?Q?7UwVtOSGUAcUO0/dKmwgl6IrFrDTgJ3+tyWar1ZY3V8K1dZ//tgbMA0AqGTQ?=
 =?us-ascii?Q?T0vVpoUOwapAszH+6JERT+dk2HTi6hOyO3mNG25yP+4asw9nm26gCaz1s3Ht?=
 =?us-ascii?Q?9/gR6dKIGM2iqxB/TYyBoW77HQyVzTGDFZ5hPV00WTubNqYGex+v0AQeRq8h?=
 =?us-ascii?Q?9gHAZr5PNUkUggQ7izyx1fIkCZKqo5bpapkwRaPtQNZU7CV+JnmH8xYkpDhf?=
 =?us-ascii?Q?7MBsnjtYuumJ1nGfd5FNb8ucAxVVRmwtHRmCq9PtxyWTIPH9B3Lt8AHWgmVY?=
 =?us-ascii?Q?jn5HAhNemvwztf2vLnryOAmwnQae8hKouw9AD/MEt9HBUNdlgiHAZ02K9eOp?=
 =?us-ascii?Q?GG5W76upRCjOae1+frUJLRUrLATA9XMKvZ95GExZYFYEw9JJIrtMFNN2aym3?=
 =?us-ascii?Q?Y0voLYfwzDqjQJMAo4jRvWbxg0rTetcfY2ozeS4PXQ9fASXQFLqpJl0yhqbo?=
 =?us-ascii?Q?t5PM+rb+sdeS7VwosxrOBg/CI3ju50t0fkOSlrBni7SOJdHPL5/yZxn39IE/?=
 =?us-ascii?Q?VZm2eR8uf/Jvu3yrerUOM5n66MkjVM7kwhp4ldVw4iaTxfkrkVXEIqLwDU6v?=
 =?us-ascii?Q?w8tPZXfOWw5S5RNqx68r5PyejEk7MAaJqUSYkOfZ35RXNugVUmV6vGKhwkDG?=
 =?us-ascii?Q?SkjgwG+LzONtj6M7xF8s9riLXyILSfarMPPTUov55kdm8v/pzJW/uYsQ1UVB?=
 =?us-ascii?Q?aRtWGmO8RZqMM+hncHeG6NevR1z/sbw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7302b176-7ffb-4468-1db1-08da525a2cb0
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 01:14:07.8338
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wgS0cAfjZXxSP3Z/7L81xh+BomidWCbWLiz7hcCEgmitVJkr8wWI7OFnSQvf2dOod2zjAABuaCOGblfmE8h4MHibJi9Rm45qpd7ne6V4ywk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1466
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-19_12:2022-06-17,2022-06-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0
 mlxscore=0 phishscore=0 suspectscore=0 malwarescore=0 mlxlogscore=844
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206200004
X-Proofpoint-ORIG-GUID: ZicX-J59G5UDImycJ2GqruC7eRyfUr6E
X-Proofpoint-GUID: ZicX-J59G5UDImycJ2GqruC7eRyfUr6E
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Each vhost device gets a thread that is used to perform IO and management
operations. Instead of a thread that is accessing a device, the thread is
part of the device, so when it creates a thread using a helper based on
copy_process we can't dup or clone the parent's files/FDS because it
would do an extra increment on ourself.

Later, when we do:

Qemu process exits:
        do_exit -> exit_files -> put_files_struct -> close_files

we would leak the device's resources because of that extra refcount
on the fd or file_struct.

This patch adds a no_files option so these worker threads can prevent
taking an extra refcount on themselves.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Acked-by: Christian Brauner <brauner@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/linux/sched/task.h |  1 +
 kernel/fork.c              | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h
index 9e20fa18c41f..7f6364e5aa1a 100644
--- a/include/linux/sched/task.h
+++ b/include/linux/sched/task.h
@@ -20,6 +20,7 @@ struct css_set;
 
 #define USER_WORKER		BIT(0)
 #define USER_WORKER_IO		BIT(1)
+#define USER_WORKER_NO_FILES	BIT(2)
 
 struct kernel_clone_args {
 	u64 flags;
diff --git a/kernel/fork.c b/kernel/fork.c
index 604c7f3cdde8..0313aa9ead89 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -1603,7 +1603,8 @@ static int copy_fs(unsigned long clone_flags, struct task_struct *tsk)
 	return 0;
 }
 
-static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
+static int copy_files(unsigned long clone_flags, struct task_struct *tsk,
+		      int no_files)
 {
 	struct files_struct *oldf, *newf;
 	int error = 0;
@@ -1615,6 +1616,11 @@ static int copy_files(unsigned long clone_flags, struct task_struct *tsk)
 	if (!oldf)
 		goto out;
 
+	if (no_files) {
+		tsk->files = NULL;
+		goto out;
+	}
+
 	if (clone_flags & CLONE_FILES) {
 		atomic_inc(&oldf->count);
 		goto out;
@@ -2229,7 +2235,8 @@ static __latent_entropy struct task_struct *copy_process(
 	retval = copy_semundo(clone_flags, p);
 	if (retval)
 		goto bad_fork_cleanup_security;
-	retval = copy_files(clone_flags, p);
+	retval = copy_files(clone_flags, p,
+			    args->worker_flags & USER_WORKER_NO_FILES);
 	if (retval)
 		goto bad_fork_cleanup_semundo;
 	retval = copy_fs(clone_flags, p);
-- 
2.25.1