Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 09:12:06 +0300 (EEST)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     "Chen, Rong A" <rong.a.chen@intel.com>
cc:     Joe Perches <joe@perches.com>, kernel test robot <lkp@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-serial <linux-serial@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        kbuild-all@lists.01.org, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [kbuild-all] Re: [PATCH] MAINTAINERS: Update DW 8250 UART
 maintainership
In-Reply-To: <7c01c4f8-1826-8769-c3d3-309a9d23f113@intel.com>
Message-ID: <e87a53b4-6fd1-f4a5-76c-37d8e61bf087@linux.intel.com>
References: <be58b398-71ff-7c12-1bf1-a09181d9c80@linux.intel.com> <202206180451.ZfYLcA43-lkp@intel.com> <7690845ccf9597e8cdc560a674a1b8e79a10f680.camel@perches.com> <7c01c4f8-1826-8769-c3d3-309a9d23f113@intel.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323329-1334455863-1655703831=:2433"
Content-ID: <f54532f8-7340-26d9-5cbd-c152b6c7aab0@linux.intel.com>
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1334455863-1655703831=:2433
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Content-ID: <634e449a-1471-c9d5-fd5-9b2a9087c286@linux.intel.com>

On Mon, 20 Jun 2022, Chen, Rong A wrote:
> On 6/18/2022 4:17 AM, Joe Perches wrote:
> > On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
> > > Hi "Ilpo,
> > > 
> > > Thank you for the patch! Yet something to improve:
> > > 
> > > [auto build test ERROR on linus/master]
> > > [also build test ERROR on v5.19-rc2 next-20220617]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > > 
> > > url:
> > > https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > 47700948a4abb4a5ae13ef943ff682a7f327547a
> > > reproduce: make htmldocs
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid
> > > > > continuation byte
> > 
> > ?
> > 
> > false positive?

This is correctly identified problem, however, the problem is lkp's end.
It seemingly fails to handle non-UTF8 encoded emails correctly and just 
goes to assume the input is UTF8 encoded (w/o checking the Content-Type 
header).

> I tried to apply the patch, and I can reproduce the error by 'make htmldocs':
> 
> $ wget -q -O -
> https://lore.kernel.org/lkml/be58b398-71ff-7c12-1bf1-a09181d9c80@linux.intel.com/raw
> | git apply -v
> $ git --no-pager diff
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f52543aedd61e..3d64756814f09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19247,8 +19247,9 @@ F:
> Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
>  F:     drivers/gpio/gpio-creg-snps.c
> 
>  SYNOPSYS DESIGNWARE 8250 UART DRIVER
> +M:     Ilpo Jrvinen <ilpo.jarvinen@linux.intel.com>
>  R:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> -S:     Maintained
> +S:     Supported
>  F:     drivers/tty/serial/8250/8250_dw.c
>  F:     drivers/tty/serial/8250/8250_dwlib.*
>  F:     drivers/tty/serial/8250/8250_lpss.c
> 
> It seems the special character '?' in name 'Ilpo J?rvinen' was parsed wrongly.

The original file was UTF-8 (0xc3 0xa4). The email is correctly encoded 
ISO 8859-15 as can be see e.g. by downloading this (with a single 0xe4 
char):
  https://marc.info/?l=linux-kernel&m=165545870203513&q=raw

When saving patch/exporting email, MUA/exporter should do ISO 8859-15 -> 
UTF-8 conversion. If I export email I sent, I get it back to UTF-8 just 
fine (as per the locale I've in use).

Just in case, I've attached the original patch file.

I thought git's toolchain these days handles these things fine but 
it seems not.


-- 
 i.
--8323329-1334455863-1655703831=:2433
Content-Type: text/x-diff; NAME=maint.patch
Content-Transfer-Encoding: BASE64
Content-ID: <f57e3f35-a418-9262-d9e4-18a18ec84dc@linux.intel.com>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME=maint.patch

RnJvbTogSWxwbyBKw6RydmluZW4gPGlscG8uamFydmluZW5AbGludXguaW50
ZWwuY29tPg0KU3ViamVjdDogW1BBVENIXSBNQUlOVEFJTkVSUzogVXBkYXRl
IERXIDgyNTAgVUFSVCBtYWludGFpbmVyc2hpcA0KDQpBZGQgbXlzZWxmIGFz
IG1haW50YWluZXIgZm9yIERXIDgyNTAgVUFSVCBhbmQgdXAgaXQgdG8gU3Vw
cG9ydGVkLg0KDQpTaWduZWQtb2ZmLWJ5OiBJbHBvIErDpHJ2aW5lbiA8aWxw
by5qYXJ2aW5lbkBsaW51eC5pbnRlbC5jb20+DQoNCi0tLQ0KIE1BSU5UQUlO
RVJTIHwgMyArKy0NCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCsp
LCAxIGRlbGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9NQUlOVEFJTkVSUyBi
L01BSU5UQUlORVJTDQppbmRleCBhNmQzYmQ5ZDJhOGQuLjZjOTA0ODRmMzk1
YiAxMDA2NDQNCi0tLSBhL01BSU5UQUlORVJTDQorKysgYi9NQUlOVEFJTkVS
Uw0KQEAgLTE5MjMwLDggKzE5MjMwLDkgQEAgRjoJRG9jdW1lbnRhdGlvbi9k
ZXZpY2V0cmVlL2JpbmRpbmdzL2dwaW8vc25wcyxjcmVnLWdwaW8udHh0DQog
RjoJZHJpdmVycy9ncGlvL2dwaW8tY3JlZy1zbnBzLmMNCiANCiBTWU5PUFNZ
UyBERVNJR05XQVJFIDgyNTAgVUFSVCBEUklWRVINCitNOglJbHBvIErDpHJ2
aW5lbiA8aWxwby5qYXJ2aW5lbkBsaW51eC5pbnRlbC5jb20+DQogUjoJQW5k
eSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5j
b20+DQotUzoJTWFpbnRhaW5lZA0KK1M6CVN1cHBvcnRlZA0KIEY6CWRyaXZl
cnMvdHR5L3NlcmlhbC84MjUwLzgyNTBfZHcuYw0KIEY6CWRyaXZlcnMvdHR5
L3NlcmlhbC84MjUwLzgyNTBfZHdsaWIuKg0KIEY6CWRyaXZlcnMvdHR5L3Nl
cmlhbC84MjUwLzgyNTBfbHBzcy5jDQoNCi0tIA0KdGc6ICg2NTUzNDczNmQ5
YTUuLikgZHcvbWFpbnRhaW5lciAoZGVwZW5kcyBvbjogdHR5LW5leHQpDQo=

--8323329-1334455863-1655703831=:2433--