Date: Thu, 24 May 2007 09:56:01 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cliff Wickman <cpw@sgi.com>, linux-kernel@vger.kernel.org,
       Paul Jackson <pj@sgi.com>, Christoph Lameter <christoph@lameter.com>,
       Paul Menage <menage@google.com>, Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset
Message-ID: <20070524075601.GB21138@elte.hu>
References: <4651FC58.mailxOWT1QTGD9@eag09.americas.sgi.com> <20070523104315.6b9089dc.akpm@linux-foundation.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070523104315.6b9089dc.akpm@linux-foundation.org>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1027
Lines: 27


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > When a cpu is disabled, move_task_off_dead_cpu() is called for tasks 
> > that have been running on that cpu.
> 
> So I still have these three patches in the pending queue but I was 
> rather hoping that the scheduler, sched-domains and cpuset people 
> could take a look at them, please.
> 
> They hit sched.c and cpuset.c mainly, and they might trash Ingo's CFS 
> patch (I haven't checked).

The patch looks good to me. It applies cleanly ontop of CFS and it 
builds and boots fine with and without CONFIG_CPU_HOTPLUG (although i 
havent tried to explicitly stress the codepath in question). We are a 
bit paranoid in this codepath but it's not performance-critical 
normally.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/