Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2621614iog; Mon, 20 Jun 2022 00:38:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u7opFHJZVq0MuRb4LVkwykW3LfgZOYUjnzhuiO8dqcMX9X9ThiFlzQqpCX7PF24scrx6lD X-Received: by 2002:a17:906:74cb:b0:712:2210:c951 with SMTP id z11-20020a17090674cb00b007122210c951mr19378307ejl.166.1655710694844; Mon, 20 Jun 2022 00:38:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655710694; cv=none; d=google.com; s=arc-20160816; b=ND5Iko2/qIwtd9E0LBDU4hHbo6+cBUzLswrt+I0Fj96c5BM8/Tj8AobRUyI85BC8u1 s39fkENK+UsI84ygUVPeSUNd5fssQX6CYjbK3/9968/CjEchcyMPzjj8y2tdXp5w+hgB O2WkPBVsqIFifVeu6z9wKqY0xXrAe90orTvu3v8Sb2vcnhAIb1NVQNr73Y7pWsnJu13i lZ7eq4AvrQkqk2cpgIwJDXIpIP+M61JR7chFYLNsJfJPvVOKmGeasjLkykt4zfmbizTl ZMY1zLgb9WzfOr/yn8ZZmHVNMLSiJp2bXtlrHU0Ar/c0kMxp6/VTJba4UGMcHG3xL/ks t1ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=M7viZKPAV4Udgzu930yRnMV9UFvypFU/FwQw+uEjxc4=; b=xARfBRHyh1R0/kjDzBMO4wz3iQY4xigsGFPKAmKH85bXI0rArZ16pByGE3TtPfIl3n fF0tKweNK/DIl+AVCrkQZPFbP11XlQsW58gHP7VeBHSGFWHrggd48wXZPAlirF9nJXaK 7SXTAyt0v5gviU0a3unxKsFhaXukzBN3LokBgp1dm+U7j2K1kRfR7XrbNvtMDFNWNMqy 7TJfsypawUwPJSP+VgUHf+Sxsp6b3vdnDvbybDz9w4fnYxmZuhuuC5Zq/1dPzfW9LPnK NnxgKo1CkbQT+noWep3kR6qjhiu3MiVViu4ib2JhpplZrl8hTXaGraVwkNslbf13ROLz Yukw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=eVmT7ZV+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga11-20020a1709070c0b00b00711d84d041dsi16283300ejc.640.2022.06.20.00.37.48; Mon, 20 Jun 2022 00:38:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ionos.com header.s=google header.b=eVmT7ZV+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ionos.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238034AbiFTGxP (ORCPT + 99 others); Mon, 20 Jun 2022 02:53:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235762AbiFTGxN (ORCPT ); Mon, 20 Jun 2022 02:53:13 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92E8DFF1 for ; Sun, 19 Jun 2022 23:53:12 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id z11so7549938edp.9 for ; Sun, 19 Jun 2022 23:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ionos.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M7viZKPAV4Udgzu930yRnMV9UFvypFU/FwQw+uEjxc4=; b=eVmT7ZV+vM2II32DTtz5GqubTfh3OndN6nOFEooR0Kf91HSg1bUq5g6LKqo6OGrf65 1RyBEaxsOyjajY5ncLzu2E5cFg4vjEXyqj/A/4iXxmokDVwjmlTpIyP7l64t8E1aJiIh Q939pmf4PKCf+YJgTzMstsfQaQNe25FUknT6U7exaNMRU4FtS9zwQh48UeCcWv7ZOe6k cy4Y373g0yoLzxg/Cu+r16/0U7sqYAeBe/xex5pMRDx2aTNMDyqyGZLXctR9CfEkTduc cwHnFhfvD2dVHwmUcDI5qK7yBGK0o4Qzbxst+rb9fkUI9CBwdrGgCrT7meKWRQsLK+sL /2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M7viZKPAV4Udgzu930yRnMV9UFvypFU/FwQw+uEjxc4=; b=sDo6ZcCRzhGoSaqN6coRPpSMZ8gm1KDaYeDcmIv2fnCrx55ux+ZT/QkVYTGq9ISIEj bZhyl8S9ttZyxSr19NecUw+PfiDNhkznKuSbmE74b0gl0Ir/GMsZ+WkjRW31sew7tS6I wblto4QGbsR4ZPUn+Lz7PiyQVvNWOd4IS5zHxBz5vaJ9km9aRVdQY4ZvChTe1DV3tZYy g1WeKeFDF+9DmizIRQDUNyBnimCXDoj33g9hH4BnDqYhzdnBBiiwQKApEodqyms/Y095 bbfIrqHX8fCePPbx1MHq/QkuJTFehlg6qF1TwZtqg1j9Gyl6hyCqPfdY1ZboqJBDyten bUww== X-Gm-Message-State: AJIora/GmdBlE9rT2tKLMnGjsOlcJeSNm9hm0l1x/QRN4tH2XOWdJuLM LNGvCAE5vhow6p3djpjpam+YxVWlZvtxjjZYZ+st8g== X-Received: by 2002:a05:6402:3688:b0:42d:d3ba:4725 with SMTP id ej8-20020a056402368800b0042dd3ba4725mr28112661edb.212.1655707991145; Sun, 19 Jun 2022 23:53:11 -0700 (PDT) MIME-Version: 1.0 References: <1654879602-33497-1-git-send-email-john.garry@huawei.com> <1654879602-33497-4-git-send-email-john.garry@huawei.com> <303bbfad-edde-1197-679e-4a09175fb1f3@suse.de> <594ac0c9-a55b-bec7-77e3-a6c7e9525f6b@opensource.wdc.com> In-Reply-To: <594ac0c9-a55b-bec7-77e3-a6c7e9525f6b@opensource.wdc.com> From: Jinpu Wang Date: Mon, 20 Jun 2022 08:53:00 +0200 Message-ID: Subject: Re: [PATCH 3/4] scsi: pm8001: Use non-atomic bitmap ops for tag alloc + free To: Damien Le Moal Cc: Hannes Reinecke , John Garry , jinpu.wang@ionos.com, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Ajish.Koshy@microchip.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > After the patch, spinlock guarantees atomicity for both alloc and free. > > Not sure there is any gain from this. +1