Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2645630iog; Mon, 20 Jun 2022 01:22:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vGQOvX0yBqxp/LSJdtJbAqIIQF6tu34T4vjx8CzD8PwVOK7b+c1fqcsC9iRoOEl9HjD2zt X-Received: by 2002:a17:90b:1bc7:b0:1e8:317d:6b3b with SMTP id oa7-20020a17090b1bc700b001e8317d6b3bmr25242426pjb.136.1655713357789; Mon, 20 Jun 2022 01:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655713357; cv=none; d=google.com; s=arc-20160816; b=F6AjD8cr/0eKZgMvYQtAwxm+sbbMRcjvx3MfbZqowxNDliHPS7TLuLRD36uqOJoVXs RuljhBWU64kU9EwpCcNLgsKu43goamAhtAOcXoL1qPGoCR8zB2xQRMv2IC9hOWNcAC3F EqpFrP6E0ldwqB7H6H8FE+m5KI+tfNRdVjrnFzIEY35HwTVhGYZSXBhlvcS0Kt2Fh5+p KR8NQcqEOhSmpySp7fuRPnXNJeq4bjGioqM/oPUiTDGVaZFfsOvjjomBpmN8yiTRKZmX 5gAhXRuMwrHupdkkqU/cTYmysIyVwIFO790vyy3WNM00i9nkvKsIKE6GlR+d5B12EivD 9xEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=/lF+2vHNxw1LBJbnivmo5EeTjM0p7dEQpvJr4URLk5M=; b=fqCBRKo9kdDSuWKOlst2ZDuXVkRYY0f9T4PwWHORAi+oywxmagLUe/ukPLjFPt61xV dSy7GxD8ScQNFFKEFFeEI5ABAwsNob4hre0u10Kdy1TdYmMMYR4RfTaO32SbT6SBM0UR JTTudgOmHC0T8lMGZ+OVnsH4O8XA0ficP7KqxzcKUtb+WUxcIyNxkMbIZXo2+AIf+P7c 1p0GwDEhwyuCr5Gyh+oNeMPHEKvWw3NBcLADUQxCzP3VonmtIPsWFuCySTEKXDvfKjqR usuE7uUbOc6zAgr8Dd6hgBh38IZnrj/h2cy2RuXefqBgEGIbROE+BkMknp4x0MMD1vxv JctQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a635710000000b0040c8a3cab3esi7633183pgb.638.2022.06.20.01.22.24; Mon, 20 Jun 2022 01:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239409AbiFTHhf (ORCPT + 99 others); Mon, 20 Jun 2022 03:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231954AbiFTHhc (ORCPT ); Mon, 20 Jun 2022 03:37:32 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28E30EE32; Mon, 20 Jun 2022 00:37:31 -0700 (PDT) Received: from fraeml708-chm.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LRLzF1D8vz6H6l9; Mon, 20 Jun 2022 15:35:37 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml708-chm.china.huawei.com (10.206.15.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 09:37:28 +0200 Received: from [10.195.35.72] (10.195.35.72) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 08:37:26 +0100 Message-ID: Date: Mon, 20 Jun 2022 08:37:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 1/5] scsi: core: Remove reserved request time-out handling To: Christoph Hellwig CC: , , , , , , , , , , , , , , , , , References: <1655463320-241202-1-git-send-email-john.garry@huawei.com> <1655463320-241202-2-git-send-email-john.garry@huawei.com> <20220620055828.GA10192@lst.de> From: John Garry In-Reply-To: <20220620055828.GA10192@lst.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.35.72] X-ClientProxiedBy: lhreml744-chm.china.huawei.com (10.201.108.194) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/06/2022 06:58, Christoph Hellwig wrote: > On Fri, Jun 17, 2022 at 06:55:16PM +0800, John Garry wrote: >> The SCSI code does not currently support reserved commands. As such, >> requests which time-out would never be reserved, and scsi_timeout() >> 'reserved' arg should never be set. >> >> Remove handling for reserved requests and drop wrapper scsi_timeout() as >> it now just calls scsi_times_out() always. > > Please rename scsi_times_out to scsi_timeout so it still matches the > method name. > ok, note that some code comments and Documentation reference scsi_times_out() so I will need to fix them up also. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig > > . Cheers, John