Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 10:15:19 +0200
From:   Vincent Whitchurch <vincent.whitchurch@axis.com>
To:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        Jonathan Corbet <corbet@lwn.net>
CC:     kernel <kernel@axis.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v2] mm/smaps: add Pss_Dirty
Message-ID: <20220620081518.GA26066@axis.com>
References: <20220620081251.2928103-1-vincent.whitchurch@axis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220620081251.2928103-1-vincent.whitchurch@axis.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Mon, Jun 20, 2022 at 10:12:50AM +0200, Vincent Whitchurch wrote:
> Pss is the sum of the sizes of clean and dirty private pages, and the
> proportional sizes of clean and dirty shared pages:
> 
>  Private = Private_Dirty + Private_Clean
>  Shared_Proportional = Shared_Dirty_Proportional + Shared_Clean_Proportional
>  Pss = Private + Shared_Proportional
> 
> The Shared*Proportional fields are not present in smaps, so it is not
> always possible to determine how much of the Pss is from dirty pages and
> how much is from clean pages.  This information can be useful for
> measuring memory usage for the purpose of optimisation, since clean
> pages can usually be discarded by the kernel immediately while dirty
> pages cannot.
> 
> The smaps routines in the kernel already have access to this data, so
> add a Pss_Dirty to show it to userspace.  Pss_Clean is not added since
> it can be calculated from Pss and Pss_Dirty.
> 
> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com>
> ---

I forgot to include the changelog:

  v2:
  - Update Documentation/ABI/testing/procfs-smaps_rollup and
    Documentation/filesystems/proc.rst.
  - Move Pss_Dirty next to Pss so that the location is consistent between
    non-rollup and rollup (since the later has some extra Pss* fields).