Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Matthew Wilcox' <willy@infradead.org>
CC:     'Kent Overstreet' <kent.overstreet@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "pmladek@suse.com" <pmladek@suse.com>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "enozhatsky@chromium.org" <enozhatsky@chromium.org>,
        "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>
Subject: RE: [PATCH v4 00/34] Printbufs - new data structure for building
 strings
Thread-Topic: [PATCH v4 00/34] Printbufs - new data structure for building
 strings
Thread-Index: AQHYhD6oUJ9HZdIC7US1XHhH4yp3Qa1XsEIg///6OQCAAEQQIA==
Date:   Mon, 20 Jun 2022 08:00:50 +0000
Message-ID: <576df7d75e3745cbacd3d265349d1a4a@AcuMS.aculab.com>
References: <20220620004233.3805-1-kent.overstreet@gmail.com>
 <0a5901f8460f452a89c9b0cda32fb833@AcuMS.aculab.com>
 <Yq/9mHZ4opmz+df9@casper.infradead.org>
In-Reply-To: <Yq/9mHZ4opmz+df9@casper.infradead.org>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Matthew Wilcox
> Sent: 20 June 2022 05:55
> 
> On Mon, Jun 20, 2022 at 04:19:31AM +0000, David Laight wrote:
> > I really think that is a bad idea.
> > printk() already uses a lot of stack, anything doing a recursive
> > call is just making that worse.
> > Especially since these calls can often be in error paths
> > which are not often tested and can already be on deep stacks.
> 
> You made this complaint last time and I challenged you to provide data.
> You have not, as yet, provided data.

There is already an issue with printk() needing 2k of stack and
'blowing' the stack in the stack overflow check.
This is with KASAN, but that that probably doesn't make
a massive difference - especially since it has more stack
to play with.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)