Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2665004iog; Mon, 20 Jun 2022 01:53:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tgZlZkJ5oJkIa+VNzj1STTWSMNWGI7M3AcMhHu8aX5+4rMVqLVysSvQghhxX3L1a3arg2H X-Received: by 2002:a17:907:8d0b:b0:711:ca5e:5b11 with SMTP id tc11-20020a1709078d0b00b00711ca5e5b11mr20406706ejc.395.1655715194147; Mon, 20 Jun 2022 01:53:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655715194; cv=none; d=google.com; s=arc-20160816; b=K8f7hWp1f1Y7gGbdG5jGHdut28vuRlV8EhUxPaq8CBLO6vYsjQ18+bKa/9EzY9tNyZ gfHAxWid0gcSOInNfg/IvH2YepudRiX8knod0BhplY7gyE44FlqBYCRxQx9rOVY0U5yn CekONG0VrZuaP4Wq0Gp1Z9t6qGrhNNUSZVSt2kl7ZPnMYTeMMJQA1bExzSmLFELiEVXj ZXtwOVIQk6Iurk2A/5LKrJLOQoapn8I9n4j3tWk54FaMAsBtUoDXd0afIrt7f1THFLXw TdWwZtbi8HoaJ6kPbxZXhhsyzoKwc0K0QUNcZzX9i58SivXlUl7HA6WdAg51Vn0wYMge rxRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=wJ9gvm5yVYygROM0LUuOxnJ8hHI/2DXABHep65saXqE=; b=kpkdidCxhYpLIH2KqkMNgMqGefZkzvvtZET34v2JZ+O/+xYASdzEJq8PglFbzfJ4Fm 3WfIq7Cx2JpW0X7KpNbT1P9JY3iJBKhLclBalo4fzeJAZnUyMPH7AXLjWaJUCGkLrB4L B7u3wqHFaU3iI7CWu4trvlIMhIeS41KIeJUDPcku7Y34FgGvaNbmI+7EBXn4bZRPDVXH 6CHZsa5vzhGtGOKrZTjqfACZe6sE3q3m9B0d9rS2pzUFXs5CmrWKDWRb4Xj3ailwMZhs D5GuAM8zJRRxS4ORl76WK6MS8I4xynZH8aRbPxjqQzt2dydV4pHhYyKzO/d+a0G2YX7W VE4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a17090629cb00b007064dc53a88si11432957eje.619.2022.06.20.01.52.48; Mon, 20 Jun 2022 01:53:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239990AbiFTIqZ convert rfc822-to-8bit (ORCPT + 99 others); Mon, 20 Jun 2022 04:46:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239620AbiFTIqX (ORCPT ); Mon, 20 Jun 2022 04:46:23 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5442BE9A for ; Mon, 20 Jun 2022 01:46:21 -0700 (PDT) Received: from kwepemi100013.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LRNVQ5NBzzhYYG; Mon, 20 Jun 2022 16:44:14 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by kwepemi100013.china.huawei.com (7.221.188.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 16:46:19 +0800 Received: from dggpemm500006.china.huawei.com ([7.185.36.236]) by dggpemm500006.china.huawei.com ([7.185.36.236]) with mapi id 15.01.2375.024; Mon, 20 Jun 2022 16:46:19 +0800 From: "chenjun (AM)" To: Peter Zijlstra CC: "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "will@kernel.org" , "xuqiang (M)" Subject: Re: [PATCH 1/1] lockdep: pass curr_inner to print_lock_invalid_wait_context Thread-Topic: [PATCH 1/1] lockdep: pass curr_inner to print_lock_invalid_wait_context Thread-Index: AQHYgk0/9VHjoiftGU6cvzdp/UjhBQ== Date: Mon, 20 Jun 2022 08:46:18 +0000 Message-ID: <233a8820e3df4c8ca594c4a78fdb0fb9@huawei.com> References: <20220616134042.130002-1-chenjun102@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.178.43] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2022/6/17 21:22, Peter Zijlstra 写道: > On Thu, Jun 16, 2022 at 01:40:42PM +0000, Chen Jun wrote: >> Same information (task_wait_context(curr)) is printed twice. > > Yes, because at that point the inner and outer context are the same. > >> curr_inner in check_wait_context is what we need. > > IIRC it simply prints the task_wait_context as a starting point, the > lockdep_print_held_locks() should include the contexts for each of > those, after which you can compute the resulting value. > > IOW, the information is complete. > > > Thanks for pointing this out. -- Regards Chen Jun