Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 11:49:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     martyn@welchs.me.uk, manohar.vanga@gmail.com,
        gregkh@linuxfoundation.org, alexandre.belloni@bootlin.com,
        rafael@kernel.org, mathieu.poirier@linaro.org,
        u.kleine-koenig@pengutronix.de, arnd@arndb.de,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        Kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] vme: Added NULL check for bridge
Message-ID: <20220620084949.GG16517@kadam>
References: <20220619070645.100947-1-jrdr.linux@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220619070645.100947-1-jrdr.linux@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hvoRPbaCmmcAqLciS09xgSnJp6DV5UcS8CwY55mEoFRd76Mc8O6AL22cE3PC?=
 =?us-ascii?Q?Hb6iZ2KzDK1vwOb7A+p0OG/LdtBE3vNg1PzEDB62PIpv30CnruoiiHKQExxG?=
 =?us-ascii?Q?KRn7ajG8AY9Wz/wo+TUICFeR3YG5BpW+pSoT182Y2suMwLFJPd2wjS/E37Hs?=
 =?us-ascii?Q?UcsVKxMh8EgOkQq6/JapQSoEBH2gR6aWVIW0EToaUtz/JencwRtWSeuxRShN?=
 =?us-ascii?Q?Daff8Lyiae7PlZa6x9Yu9fnJhXsBlvT0emzdLWd2lDdWbAadoTZPz97K0d1W?=
 =?us-ascii?Q?5RqZQ02Y+LlGxT+P/zvqigb41TZWSL1S4EiqWrwF7HoQ7lMvvm7+B1eqLUEp?=
 =?us-ascii?Q?37VzXR2AsdFkx4DcpnlyytK05mtdZ91V9i6xJaY8SISy/1nRty7a2ywiM/6d?=
 =?us-ascii?Q?Ly+v50wTWS1Y5iVtkCXNDqmQ47jVc8smGeCMZ2nGLBvLUHUU64GRCP8MiQuI?=
 =?us-ascii?Q?8uCthOIIMYcmpAX08KBLgHmpmXAGp/ZW1pAzWaAnJ9aXrTK/UKT4wZ1sdAHO?=
 =?us-ascii?Q?1MZI6eEIkFixEX8vyUAYbS3J5VjW5h4fKdL4zkh41aVUWeEZW7bzpce5Il4O?=
 =?us-ascii?Q?KOR2J2vF4uSjUdnShNzsPGCn2Lh7tYxKIppLrnZdlT7+vCdkFRfLPYy8O7UY?=
 =?us-ascii?Q?GAZM+Vog56tYieyobdN9GA6Tw1OHSzMRveBC0K0MDMvH/uWtXekUeiAp0+cP?=
 =?us-ascii?Q?HNZhOoB2l6BWVwohrVfgnuzg/MV3jF4F/tN/y8gz0cUXrr9vktjyiBtrIAqs?=
 =?us-ascii?Q?hbR4VboNDPgPy5MDJ8JV73D1+E1Ar3cmKgwPs1vmupFmC6G0Pv9yC6Tx51yu?=
 =?us-ascii?Q?IJht7Q2v1A2rqP1a4HCcU8KLHIcra5r/CUersDSQhNLh/HjrGa9ML1AziFGq?=
 =?us-ascii?Q?5rAzNOGdbYKFqCZJZiNpsp28/s2rNJVLONNHxV5sdsQ/mtLFXowoUJPplimw?=
 =?us-ascii?Q?fbijqS4FZ8Q4OYJxobgFSK7iDsZJBmakNmiWsh+/3+m3w84+REpHB6y5j9xx?=
 =?us-ascii?Q?8VXA85v+x7VTOAwmikYuULEIrzEKX5cyLNgdkFspiP9iOT//U104T2Zw0Tob?=
 =?us-ascii?Q?0Zk61LMQf58VkD8xRCVgfuXOK+2p02o+bH4Nr6skEhi68VDVMA4dCLbTvhuQ?=
 =?us-ascii?Q?xFpn8HddZIvQgXh2xDHelJ64/31trVr8qj6z6TF0b1/dDDK3fGlmdfn/s+5J?=
 =?us-ascii?Q?IYxCqAhG2T+MNV+U/Oi0Z9iqGcOCnIGfYQzz5s1otVR5h9uG9mgRqpFualpe?=
 =?us-ascii?Q?txwg4CJE774ehMHqlVoYqFqj4wq+ic5B/lEI9KL0MrvumL4KzPDaYsnDlB1t?=
 =?us-ascii?Q?6M0wSazx0XY7kvibHmuW6rglMT3RkCZ6ZtPfjwkB+KSA2jd7SlOGLd1BQOA6?=
 =?us-ascii?Q?6Jnu1XnNtKUJa4qRJnHr23SKekgSmRokYpBV/VV3o7zKV/eOrpGyM9mfTDnL?=
 =?us-ascii?Q?IF2cBYEgixLnW6F8HOb4Yv+cPeiWwh8co7n/B9jkfxOOkCWEXxJvfjsjyBXk?=
 =?us-ascii?Q?5YKAnsVyV+McbwMmvreKKOVA1TV9AxEMBrqz/wscjzMFrRYukAe5Ixd0jfjV?=
 =?us-ascii?Q?2K7FKOqfM4qORSf9DDGJsSCjZEWd5YiluIxBtX7Ob3dwVC6Y2FIXJSl7t+93?=
 =?us-ascii?Q?NlSjW32I2b/Vr0WMC7zqz86fTa1/xGoLdaxmMKKOtlHvbdm5eEtACZGpp3SI?=
 =?us-ascii?Q?rbkBTtcEKdicrDL9dzO0f043pw7FxC5+i4GoEnIuuEy2PXQs36UHGE2Rsgh8?=
 =?us-ascii?Q?r8wsVo3fDdu3BpuRWbCGNGzNsJTEaos=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e0ce2b1b-2fce-494d-5760-08da5299e25f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 08:50:11.3187
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QnAv1WjpkbJavfYKv4qyynePLE8kquKeodImfR+duZqU6dm+MQNyyKEpQvDXaa3MbyciYKaNBP2MfQL6ouIuWKkRm6gSwKHYi7E6Mqffsow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2710
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-06-20_04:2022-06-17,2022-06-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206200041
X-Proofpoint-GUID: 21V1oU1jxoLQS2XaqJQ7eD4DDMHUMi-L
X-Proofpoint-ORIG-GUID: 21V1oU1jxoLQS2XaqJQ7eD4DDMHUMi-L
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 19, 2022 at 12:36:45PM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@gmail.com>
> 
> Kernel test robot throws below warning ->
> drivers/staging/vme_user/vme.c:662:20: warning: dereference
> of NULL 'bridge' [CWE-476] [-Wanalyzer-null-dereference]
> 
> Added a NULL check.
> 
> Reported-by: Kernel test robot <lkp@intel.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
> ---
>  drivers/staging/vme_user/vme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c
> index b5555683a069..ede774f2fe5a 100644
> --- a/drivers/staging/vme_user/vme.c
> +++ b/drivers/staging/vme_user/vme.c
> @@ -659,7 +659,7 @@ ssize_t vme_master_read(struct vme_resource *resource, void *buf, size_t count,
>  	struct vme_master_resource *image;
>  	size_t length;
>  
> -	if (!bridge->master_read) {
> +	if (bridge && !bridge->master_read) {

This patch does not help anything.  If "bridge" is NULL here then the
kernel will just crash later in the function.  Smatch complains about it
now:

drivers/staging/vme_user/vme.c:688 vme_master_read() error: we previously assumed 'bridge' could be null (see line 666)

However, I don't believe that bridge can actually be NULL here.  We do
not write code just to silence that static checker false positives.  Fix
the checker instead.

regards,
dan carpenter