Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 12:01:07 +0300
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, paul.elder@ideasonboard.com, marex@denx.de,
        aford173@gmail.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] arm64: dts: imx8mp: correct clock of pgc_ispdwp
Message-ID: <YrA3Uxtmfce2jQBs@pendragon.ideasonboard.com>
References: <20220620032044.4093226-1-peng.fan@oss.nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220620032044.4093226-1-peng.fan@oss.nxp.com>
Precedence: bulk

Hi Peng,

Thank you for the patch.

On Mon, Jun 20, 2022 at 11:20:44AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> The deprecated DIV clk is previously part of the ISP composite clk, but
> there is still one child clk(IMX8MP_CLK_MEDIA_ISP_ROOT) sourcing from
> IMX8MP_CLK_MEDIA_ISP( previously IMX8MP_CLK_MEDIA_ISP_DIV)
> 
> So IMX8MP_CLK_MEDIA_ISP_ROOT should be used, not IMX8MP_CLK_MEDIA_ISP_DIV.
> 
> Fixes: 9d89189d5227 ("arm64: dts: imx8mp: Add MEDIAMIX power domains")

Oops, my bad.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index b2f4a5f1f73c..2f970d458f80 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -595,7 +595,7 @@ pgc_hsiomix: power-domains@17 {
>  					pgc_ispdwp: power-domain@18 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_MEDIAMIX_ISPDWP>;
> -						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_DIV>;
> +						clocks = <&clk IMX8MP_CLK_MEDIA_ISP_ROOT>;
>  					};
>  				};
>  			};

-- 
Regards,

Laurent Pinchart