Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy
Reply-To: wangseok.lee@samsung.com
Sender: Wangseok Lee <wangseok.lee@samsung.com>
From:   Wangseok Lee <wangseok.lee@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
        "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
        "lars.persson@axis.com" <lars.persson@axis.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "kw@linux.com" <kw@linux.com>,
        "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
        "kernel@axis.com" <kernel@axis.com>
CC:     Moon-Ki Jun <moonki.jun@samsung.com>,
        Sang Min Kim <hypmean.kim@samsung.com>,
        Dongjin Yang <dj76.yang@samsung.com>,
        Yeeun Kim <yeeun119.kim@samsung.com>
In-Reply-To: <4b4b08af-887b-89e9-b4a5-93e7d8a03222@kernel.org>
Message-ID: <20220620083821epcms2p57a65984523a0f2a3815e4873e8bfc6df@epcms2p5>
Date:   Mon, 20 Jun 2022 17:38:21 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <4b4b08af-887b-89e9-b4a5-93e7d8a03222@kernel.org>
        <20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
        <20220614012916epcms2p5cf8d55e7420dea10bb4a05d91aaf99dd@epcms2p5>
        <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p5>
Precedence: bulk

On=C2=A017/06/2022=C2=A007:59,=C2=A0Krzysztof=20Kozlowski=20wrote:=0D=0A>=
=20On=C2=A013/06/2022=C2=A018:29,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=0A>=
>=C2=A0Add=C2=A0description=C2=A0to=C2=A0support=C2=A0Axis,=C2=A0ARTPEC-8=
=C2=A0SoC.=0D=0A>>=C2=A0ARTPEC-8=C2=A0is=C2=A0the=C2=A0SoC=C2=A0platform=C2=
=A0of=C2=A0Axis=C2=A0Communications=0D=0A>>=C2=A0and=C2=A0PCIe=C2=A0phy=C2=
=A0is=C2=A0designed=C2=A0based=C2=A0on=C2=A0SAMSUNG=C2=A0PHY.=0D=0A>=20=0D=
=0A>=20No=C2=A0improvements=C2=A0here.=C2=A0On=C2=A0v2=C2=A0I=C2=A0gave=C2=
=A0you=C2=A0link=C2=A0pointing=C2=A0to=C2=A0specific=0D=0A>=20paragraph=C2=
=A0of=C2=A0our=C2=A0documentation=C2=A0which=C2=A0you=C2=A0need=C2=A0to=C2=
=A0apply=C2=A0-=C2=A0wrong=C2=A0wrapping.=0D=0A>=20Is=C2=A0there=C2=A0somet=
hing=C2=A0unclear=C2=A0here?=0D=0A>=20=0D=0A>=20Please=0D=0A>=20do=0D=0A>=
=20not=0D=0A>=20wrap=0D=0A>=20in=0D=0A>=20different=0D=0A>=20style.=0D=0A>=
=20=0D=0A>=20=0D=0A=0D=0AI=20think=20i=20misunderstood=20your=20review=20co=
mment.=0D=0AI=20will=20modify=20it=20as=20below.=0D=0As/SAMSUNG=C2=A0PHY/Sa=
msung=20phy=0D=0APlease=20let=20me=20know=20if=20there=20is=20anything=20I=
=20missed.=0D=0A=0D=0A>>=C2=A0=0D=0A>>=C2=A0Signed-off-by:=C2=A0Wangseok=C2=
=A0Lee=C2=A0<wangseok.lee=40samsung.com>=0D=0A>>=C2=A0---=0D=0A>>=C2=A0v2->=
v3=C2=A0:=0D=0A>>=C2=A0-modify=C2=A0version=C2=A0history=C2=A0to=C2=A0fit=
=C2=A0the=C2=A0linux=C2=A0commit=C2=A0rule=0D=0A>>=C2=A0-remove=C2=A0'Devic=
e=C2=A0Tree=C2=A0Bindings'=C2=A0on=C2=A0title=0D=0A>>=C2=A0-remove=C2=A0clo=
ck-names=C2=A0entries=0D=0A>>=C2=A0-change=C2=A0node=C2=A0name=C2=A0to=C2=
=A0soc=C2=A0from=C2=A0artpec8=C2=A0on=C2=A0excamples=0D=0A>>=C2=A0=0D=0A>>=
=C2=A0v1->v2=C2=A0:=0D=0A>>=C2=A0-'make=C2=A0dt_binding_check'=C2=A0result=
=C2=A0improvement=0D=0A>>=C2=A0-Add=C2=A0the=C2=A0missing=C2=A0property=C2=
=A0list=0D=0A>>=C2=A0-Align=C2=A0the=C2=A0indentation=C2=A0of=C2=A0continue=
d=C2=A0lines/entries=0D=0A>>=C2=A0---=0D=0A>>=C2=A0=C2=A0.../bindings/phy/a=
xis,artpec8-pcie-phy.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=7C=C2=A073=C2=A0++++++++++++++++++++++=0D=0A>>=C2=A0=C2=A01=C2=A0file=C2=
=A0changed,=C2=A073=C2=A0insertions(+)=0D=0A>>=C2=A0=C2=A0create=C2=A0mode=
=C2=A0100644=C2=A0Documentation/devicetree/bindings/phy/axis,artpec8-pcie-p=
hy.yaml=0D=0A>>=C2=A0=0D=0A>>=C2=A0diff=C2=A0--git=C2=A0a/Documentation/dev=
icetree/bindings/phy/axis,artpec8-pcie-phy.yaml=C2=A0b/Documentation/device=
tree/bindings/phy/axis,artpec8-pcie-phy.yaml=0D=0A>>=C2=A0new=C2=A0file=C2=
=A0mode=C2=A0100644=0D=0A>>=C2=A0index=C2=A00000000..316b774=0D=0A>>=C2=A0-=
--=C2=A0/dev/null=0D=0A>>=C2=A0+++=C2=A0b/Documentation/devicetree/bindings=
/phy/axis,artpec8-pcie-phy.yaml=0D=0A>>=C2=A0=40=40=C2=A0-0,0=C2=A0+1,73=C2=
=A0=40=40=0D=0A>>=C2=A0+=23=C2=A0SPDX-License-Identifier:=C2=A0GPL-2.0-only=
=C2=A0OR=C2=A0BSD-2-Clause=0D=0A>>=C2=A0+%YAML=C2=A01.2=0D=0A>>=C2=A0+---=
=0D=0A>>=C2=A0+=24id:=C2=A0https://protect2.fireeye.com/v1/url?k=3D84f6a8c0=
-e57dbdd9-84f7238f-74fe485cbfec-e81bd79bfd1ff442&q=3D1&e=3D6739af06-730c-48=
db-aef8-026a9aaee1b4&u=3Dhttp%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Faxis=
%2Cartpec8-pcie-phy.yaml%23=0D=0A>>=C2=A0+=24schema:=C2=A0https://protect2.=
fireeye.com/v1/url?k=3Db4f1a4ba-d57ab1a3-b4f02ff5-74fe485cbfec-7f885cbe82dc=
7860&q=3D1&e=3D6739af06-730c-48db-aef8-026a9aaee1b4&u=3Dhttp%3A%2F%2Fdevice=
tree.org%2Fmeta-schemas%2Fcore.yaml%23=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+title:=
=C2=A0ARTPEC-8=C2=A0SoC=C2=A0PCIe=C2=A0PHY=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+mai=
ntainers:=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0Jesper=C2=A0Nilsson=C2=A0<jesper=
.nilsson=40axis.com>=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+properties:=0D=0A>>=C2=A0=
+=C2=A0=C2=A0compatible:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0const:=C2=A0=
axis,artpec8-pcie-phy=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+=C2=A0=C2=A0reg:=0D=0A>>=
=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PHY=C2=A0registers.=0D=0A>>=C2=A0+=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PHY=C2=A0codin=
g=C2=A0sublayer=C2=A0registers.=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+=C2=A0=C2=A0re=
g-names:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>>=C2=A0+=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0const:=C2=A0phy=0D=0A>>=C2=A0+=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=C2=A0const:=C2=A0pcs=0D=0A>>=C2=A0+=0D=0A>>=
=C2=A0+=C2=A0=C2=A0=22=23phy-cells=22:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=
=A0const:=C2=A00=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+=C2=A0=C2=A0clocks:=0D=0A>>=
=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0items:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0-=C2=A0description:=C2=A0PCIe=C2=A0PHY=C2=A0reference=C2=A0c=
lock=0D=0A=0D=0Arefer=20to=20sample-schema.yaml,=20even=20if=20the=20clock=
=20item=20is=20single,=0D=0Ait=20seems=20to=20be=20used=20as=20follows.=0D=
=0A=0D=0Aclocks:=0D=0A=20=20maxItems:=201=0D=0A=0D=0Aclock-names:=0D=0A=20=
=20items:=0D=0A=20=20=20=20-=20const:=20ref=0D=0A=0D=0AIf=20only=20=22clock=
s:=22=20are=20define=20and=20clock-names=20are=20not=20define,=0D=0Athe=20f=
ollowing=20warning=20occurs.=0D=0A=22'clock-names'=20does=20not=20match=20a=
ny=20of=20the=20regexes=22=0D=0A=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+=C2=A0=C2=A0n=
um-lanes:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0const:=C2=A02=0D=0A>>=C2=A0=
+=0D=0A>>=C2=A0+=C2=A0=C2=A0lcpll-ref-clk:=0D=0A>>=C2=A0+=C2=A0=C2=A0=C2=A0=
=C2=A0const:=C2=A01=0D=0A>=20=0D=0A>=20Unknown=C2=A0field...=C2=A0custom=C2=
=A0properties=C2=A0need=C2=A0vendor=C2=A0(axis,),=C2=A0type=C2=A0(boolean)=
=0D=0A>=20and=C2=A0description.=0D=0A>=20=0D=0A=0D=0A=22lcpl-ref-clk=22=20h=
as=20an=20enum=20type=20value,=20so=20i=20will=20modify=20it=20as=20below.=
=0D=0A=0D=0A=0D=0Aaxis,lcpll-ref-clk:=0D=0A=20=20description:=0D=0A=20=20=
=20=20select=20the=20reference=20clock=20of=20phy=20and=20initialization=20=
is=20performed=0D=0A=20=20=20=20with=20the=20reference=20clock=20according=
=20to=20the=20selected=20value.=0D=0A=20=20=24ref:=20/schemas/types.yaml=23=
/definitions/uint32=0D=0A=20=20enum:=20=5B=200,=201,=202,=203,=204=20=5D=0D=
=0A=0D=0A>>=C2=A0+=0D=0A>>=C2=A0+required:=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=
=A0compatible=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0reg=0D=0A>>=C2=A0+=C2=A0=C2=
=A0-=C2=A0reg-names=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0=22=23phy-cells=22=0D=
=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0clocks=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0cloc=
k-names=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0samsung,fsys-sysreg=0D=0A>=20=0D=
=0A>=20Same=C2=A0problem=C2=A0as=C2=A0in=C2=A0patch=C2=A0=231.=0D=0A>=20=0D=
=0A=0D=0AI=20will=20add=20the=20following=20items=20to=20the=20property.=0D=
=0A=0D=0Asamsung,fsys-sysreg:=0D=0A=20=20description:=0D=0A=20=20=20=20Phan=
dle=20to=20system=20register=20of=20fsys=20block.=0D=0A=20=20=24ref:=20/sch=
emas/types.yaml=23/definitions/phandle=0D=0A=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=
=A0num-lanes=0D=0A>>=C2=A0+=C2=A0=C2=A0-=C2=A0lcpll-ref-clk=0D=0A>>=C2=A0+=
=0D=0A>>=C2=A0+additionalProperties:=C2=A0true=0D=0A>=20=0D=0A>=20No,=C2=A0=
this=C2=A0must=C2=A0be=C2=A0false.=0D=0A>=20=0D=0A=0D=0Ayes,=20i=20miss=20i=
t.=20I=20will=20fix=20this.=0D=0A=0D=0A>=20Best=C2=A0regards,=0D=0A>=20Krzy=
sztof=0D=0A=0D=0AThank=20you=20for=20kindness=20reivew.=0D=0A=0D=0ABest=20r=
egards,=0D=0AWangseok=20Lee