Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2696635iog; Mon, 20 Jun 2022 02:41:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vlW6+BUMU6rwUVCqT07r/txe/G/RvMzW3t7Ml4O6lvnnMoM0ybXXt6mUrQl8so3uj5j9w7 X-Received: by 2002:a17:906:1193:b0:70d:cf39:a4db with SMTP id n19-20020a170906119300b0070dcf39a4dbmr20286418eja.44.1655718097787; Mon, 20 Jun 2022 02:41:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655718097; cv=none; d=google.com; s=arc-20160816; b=uQIr9i0nwCABnjsrfA253bHmLz4A18LXFgHCcRXr1fAUMHYXieOVY6b/hsEBIVu5/u SbpsU05k4ZX1IWvQp9z0GqPaqxod+QxC7Rif+jFx2mhQvjtMqPrdWBN3CUBu74kxgVTp DQJiEZV5dqCowaq7LA/kJfWmxVZc4eY1jVSdu9qR4Bf1YIpWSzqOWVjJ8LXMoD+xIBF6 jhLKXaLjoKIWVNQ4D51s2QhTse+HA6hmArDyvvVEw6KuOAH4Mcl+deYoy2VRrNuiyf7X 4o1iwcpCp4ywjEMlepvXmFiPMVD7G00f3gDaZj+Jxw8cwZoKX7p/xXtCZVon/Sgttsru UyKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=LVfZztcjw9QzEygx8YebB5L5Bqbt6JDKZ0Sk2eQLuSj8KDfR7i56I7rdLlvoif5oXi pn+A5VKQ9Jgf/cwP6EdtkemtblNAoQIFHvlfpAuv8yWp9m129waOoxjsUmk0qFz9xgYw adpzHXKmGgBWZZfuwSGowc2Rmhi22oQKj9SSWX/g1QjN1H1OX1XdnVVqTHqXLv1vQos6 PjkVrDDwLRDxo2gcP7qXyIKf4DTIYhz3dGACrMJNCDNN69I7cRT9kQobh1e/NuODXMn3 VtWy/RluvAB/M2EMVSWG4T3jCbjsFmbP98QSHOFB6Kdjeflpu3U2DNXbyS6x5L4WaLoQ xbrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y8J3adRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn15-20020a17090794cf00b00711c9e20c40si14694184ejc.243.2022.06.20.02.41.11; Mon, 20 Jun 2022 02:41:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=y8J3adRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240698AbiFTJat (ORCPT + 99 others); Mon, 20 Jun 2022 05:30:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240925AbiFTJa3 (ORCPT ); Mon, 20 Jun 2022 05:30:29 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BACAF13D1D for ; Mon, 20 Jun 2022 02:30:28 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id w6so2538596pfw.5 for ; Mon, 20 Jun 2022 02:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=y8J3adRTFx0+l7qiCljpvacMAoRZTzljC86NoPhyp7A6KhE8XkrV0+sskJHqS20FLL BpONFh3dOC9GLQOJpXXVYb0yPcVg5Gq0zOBXmwGZpzuIQeH4cuYfKlz7Stserhxa/EB1 Jh2U1u9GHn/IzcxV+n7J2gpdqOrQzsQ3hKW9/gHb3u12mXOWLugUUHVGqmT37GFO0HZq ILx3qoOZf8pv74pLSxVLMSRM9BccxcafW/yTft1bKmZLSGv67wBXpVY37Ly1DGv9kyQd 2LDbYhY9L+lr15OjynwD3yrR+X9k1POcN5WAd3KtVluZftfpe6xUuF9i80PrI3roS9Gt pJ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F9FMzgZGjtkVq9AbputYdTQEVUZao0adrAEgaXfcxrA=; b=YENwSA3EBznE/191UYcaJySYQ+6Sz/9j+yYGMNtI209zmxl4Y1+XDOwsnybDBmArPm RfqA0Z+DprQb7okEH7H1AjFmHFD1ikyE5mMgHNAihHxuPM8Rv4Tlau7xXfgHVarwzA+P fLL45+qfpZTu1XtaEa0Lr/nLv2YAc7nGQBe0sOnL3cJMGaODdcu23jNhdXi0y9lT3kqM aWf0Yf55R8wubZhH59fqe1XDBYjPYj/Lpzr6qxbclso3ZDCin/NZAEaI4ESE3KflDVi9 Z5sLAw61Yq9I/qwuAUlr5OqR199KHqhCgArcF+lrDvVVjBVegmU7ML8PvxMLtSx1SRzx /VSQ== X-Gm-Message-State: AJIora/HlST0T29bOZUVjT/PN3fyv5N11JrgRftZ5iJAFKWDHFHmLg0x SZJu9oAtztJ8cakN1YQDXN4aX/gPevNM1SgkYs4= X-Received: by 2002:a65:4501:0:b0:3fc:4895:283b with SMTP id n1-20020a654501000000b003fc4895283bmr21219274pgq.231.1655717428290; Mon, 20 Jun 2022 02:30:28 -0700 (PDT) Received: from localhost ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id y188-20020a62cec5000000b00525286c7847sm990754pfg.216.2022.06.20.02.30.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 02:30:27 -0700 (PDT) Date: Mon, 20 Jun 2022 17:30:23 +0800 From: Muchun Song To: Miaohe Lin Cc: akpm@linux-foundation.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] mm/swap: remove swap_cache_info statistics Message-ID: References: <20220608144031.829-1-linmiaohe@huawei.com> <20220608144031.829-4-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608144031.829-4-linmiaohe@huawei.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 08, 2022 at 10:40:31PM +0800, Miaohe Lin wrote: > swap_cache_info are not statistics that could be easily used to tune system > performance because they are not easily accessile. Also they can't provide > really useful info when OOM occurs. Remove these statistics can also help > mitigate unneeded global swap_cache_info cacheline contention. > > Suggested-by: David Hildenbrand > Signed-off-by: Miaohe Lin Reviewed-by: Muchun Song Thanks.