Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2721809iog; Mon, 20 Jun 2022 03:21:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vLUAaef1AGLEWZ/ELubqtpeLG5xMIx4NS70mZyfYJfr1qQMlD/25EGiZeYjB+OxG7IEZkT X-Received: by 2002:a05:6402:516b:b0:435:8f7b:b6f7 with SMTP id d11-20020a056402516b00b004358f7bb6f7mr402108ede.291.1655720491401; Mon, 20 Jun 2022 03:21:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655720491; cv=none; d=google.com; s=arc-20160816; b=C4YP2shiTdcQagIF3L2WNAqYpS5GDjZv2H5FcDQ075h2InbjeGgKw17EBx7eGG+MwV 64WLasR3YkX7z7JWzhk1XgBsLY3U54lasXrIgHnJ1EinJVjqcsqJBqM74Ol6vlRLKBRi sA7Fk6+GikuMQJHgisxZwL2PjsCAJmNETu+qsXbq1p2SGV9Mr/vdI05dTznFzhgz5g6D 00ua0EKvzhI4PchqJTD1tDGbATmO3XwZS1X6LvrQXWQk+WVt0mxfNcO1QZUCjlJcaTQJ toy9d8VxbmTekmPjyomxldkXGoKDmh0BfPF4gd91Wr6aZsIi6VgTDQHj7J263K/dJPJ6 +qiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=JXCWE4QVRE062byG1F9Sh5rqyhPnhT2TnxokzvlpgLE=; b=qum5VTKALFLbNOJYjs9H4Rcd3+Jo0lUdvqkQsAdvhjCrn+kCcP/07+r/asYpZrqen2 2UO8j1rbdczvrm2Tjwvt2mMbRxoImdR/HrVsMOyPZk62SXzENI2EY//Pas+oFKGrjY3q IaDmFkVoURwgPHMR273v7uboM1w3XGV6XA+Q4tFJoSXxlLscdiQ5C31ihAETgjR0giG/ Y7ZnGcH0t3j+3AvXE4SP8IhrLQXuw+UeB8QMkMqzWFiZYpSm6I0oT8YLMCfgWEc9J+H6 asZO4RkhaH/UbIyLftWxi5DjxpQcBIi/kU6SIH5IQZzmHZiVpZvR/nGPPpK+0IgZ0R0c YO5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nD5iFamu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e19-20020a056402191300b004316c7b2879si7914201edz.237.2022.06.20.03.21.05; Mon, 20 Jun 2022 03:21:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nD5iFamu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240935AbiFTKLn (ORCPT + 99 others); Mon, 20 Jun 2022 06:11:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240916AbiFTKLk (ORCPT ); Mon, 20 Jun 2022 06:11:40 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E12A19B; Mon, 20 Jun 2022 03:11:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 2639ECE115D; Mon, 20 Jun 2022 10:11:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 009CAC341C4; Mon, 20 Jun 2022 10:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655719895; bh=NycXRGtWzRHMAKOaSFn4Y7wy/Pe7R05IJTr1+bbd6wY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nD5iFamu9CMt0ZPhWlLPV37Zv37vTeRlCApGx4IWqy0k2SY32DaZNPaNHlaa9b4Ci fdjel+34lG/EP1LqcIarf2Mn0PFmHLnO+EK0MbsMJnA2XlXoyI6y+yN2zZfXQbYu+d l12NU6O73zsZkJ7TH8sti6XQqoooBB9POVngkP4g= Date: Mon, 20 Jun 2022 12:11:32 +0200 From: Greg KH To: Maciej =?utf-8?Q?=C5=BBenczykowski?= Cc: patchwork-bot+netdevbpf@kernel.org, stable@vger.kernel.org, Riccardo Paolo Bestetti , Carlos Llamas , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , kernel-team@android.com, Kernel hackers , Linux NetDev , Miaohe Lin Subject: Re: [PATCH v2] ipv4: ping: fix bind address validity check Message-ID: References: <20220617085435.193319-1-pbl@bestov.io> <165546541315.12170.9716012665055247467.git-patchwork-notify@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2022 at 04:45:52PM -0700, Maciej Żenczykowski wrote: > On Fri, Jun 17, 2022 at 4:30 AM wrote: > > > > Hello: > > > > This patch was applied to netdev/net.git (master) > > by David S. Miller : > > > > On Fri, 17 Jun 2022 10:54:35 +0200 you wrote: > > > Commit 8ff978b8b222 ("ipv4/raw: support binding to nonlocal addresses") > > > introduced a helper function to fold duplicated validity checks of bind > > > addresses into inet_addr_valid_or_nonlocal(). However, this caused an > > > unintended regression in ping_check_bind_addr(), which previously would > > > reject binding to multicast and broadcast addresses, but now these are > > > both incorrectly allowed as reported in [1]. > > > > > > [...] > > > > Here is the summary with links: > > - [v2] ipv4: ping: fix bind address validity check > > https://git.kernel.org/netdev/net/c/b4a028c4d031 > > > > You are awesome, thank you! > > -- > > Deet-doot-dot, I am a bot. > > https://korg.docs.kernel.org/patchwork/pwbot.html > > I believe this [ > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=b4a028c4d031 > ] needs to end up in 5.17+ LTS (though I guess 5.17 is eol, so > probably just 5.18) 5.17 is end-of-life, sorry. And this needs to hit Linus's tree first. thanks, greg k-h