Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2779011iog; Mon, 20 Jun 2022 04:45:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uS0Ui82Kkxz+ES6N0BY2bMvw41grTNrcFEDPTdoekrlTkKliD8EBHMwvBxdPgYGVhpc36x X-Received: by 2002:a05:6402:40d6:b0:42e:3d4:4406 with SMTP id z22-20020a05640240d600b0042e03d44406mr29106831edb.387.1655725558203; Mon, 20 Jun 2022 04:45:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655725558; cv=none; d=google.com; s=arc-20160816; b=GquGhGAals9XLQ7x8msE3pWNrYOtoIW6koc4Vc3mlyvhW7T36uH1gVVIa/tVt7zR+2 Xc+vH8ibxN047FA5px/e4XzwJAZB+vOsAfvK5gbstZPs6dcjPGswPthFnn0zt1F7wu/p tYL1v8kdES8AX2rozk8ODEj512b8qxXJkeHqJX7vHvUyImXbtHUtSvX5o88kUhr96pkz Ju1RzRm/jYue3T1NE83tVYxLeiARNXBlHypBEx1yTL6zwBRfzlU0iaTfgm30WyfFOKzm OzfMyoCTNdYnbfbC6TEuQWz5pqJG02Bxsyq+RKFZgkHwio+AzFe5uYSjUnZa8YCDwr/e oPxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=GUOWxAfzMBIz5nz9gtnOWVRzb+80w1ByvIZjYYJM9YQ=; b=PK1umvc0q1nqfHLLe95JRouejRzjxCPX/8p0aUc7+LOIcpzp691KgYEFItoPIU9yHv wFejFFi+6YwZO1V3kaDhqz7qf0wpK4icfP8uifvQ6IXkTd92+Hv8wYGFr0eoHF6g2nEE UQwh+Hz6gu17GLFyUi6amo4ruCOk/sojPF3dZv5r8gtxerA/MzojxhWj64KHWQTwmlXl /nZMK9cCSJLWBLnrn0ZhQHl6zvGO5goUg25POvuvZTiODt2CYiOWw/0SuXKoqLI8eXL9 YFH5RjkZpNOBbpGtINr/XknR2BTChdEQxBQSvxNV6zwOzaUsqYQIWIAP5nyYcdDu6gkM y7Fg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hr21-20020a1709073f9500b006fe10d6262bsi14564713ejc.500.2022.06.20.04.45.32; Mon, 20 Jun 2022 04:45:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241293AbiFTLOp (ORCPT + 99 others); Mon, 20 Jun 2022 07:14:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241874AbiFTLO1 (ORCPT ); Mon, 20 Jun 2022 07:14:27 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D562175A9; Mon, 20 Jun 2022 04:13:17 -0700 (PDT) Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LRRlt2yjBz6H6lq; Mon, 20 Jun 2022 19:11:06 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Mon, 20 Jun 2022 13:12:58 +0200 Received: from [10.195.35.72] (10.195.35.72) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 20 Jun 2022 12:12:57 +0100 Message-ID: Date: Mon, 20 Jun 2022 12:12:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 5/5] blk-mq: Drop 'reserved' member of busy_tag_iter_fn To: Bart Van Assche , , , , , , , , , CC: , , , , , , , , References: <1655463320-241202-1-git-send-email-john.garry@huawei.com> <1655463320-241202-6-git-send-email-john.garry@huawei.com> <017cae1e-b45f-04fd-d34c-22ae736b28e5@acm.org> From: John Garry In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.195.35.72] X-ClientProxiedBy: lhreml744-chm.china.huawei.com (10.201.108.194) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/06/2022 17:55, Bart Van Assche wrote: >> >> It's not totally necessary. Since local variable 'reserved' would now >> only be used once I thought it was better to get rid of it. >> >> I can keep it if you really think that is better. > > I'd prefer that these changes are either left out or that these are > moved into a separate patch. I think that will make this patch series > easier to review. Personally I think that this is a trivial change and does not merit a separate patch. Other reviewers seem to agree. Anyway, if you feel strongly about this then I can put in another patch. Thanks, John