Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a632d2f314b525a54045ce2395ebfa09edc3e71.camel@nxp.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: phy: Add Freescale i.MX8qm Mixel
 LVDS PHY binding
From:   Liu Ying <victor.liu@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com
Date:   Mon, 20 Jun 2022 20:10:06 +0800
In-Reply-To: <ca5834ea-701f-2260-da2a-84b22d4033db@linaro.org>
References: <20220620034533.4108170-1-victor.liu@nxp.com>
         <20220620034533.4108170-3-victor.liu@nxp.com>
         <ca5834ea-701f-2260-da2a-84b22d4033db@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXZrYmVKd0UyMmpzcWlqWFdVYVhiOEpEUlpNenZMTzFCRTlIZE9PVFlsTita?=
 =?utf-8?B?ZXREYmcrQmNQNzJZa0N6N3psbDM0eFFHNW1UQnhIYURMOU82N1F6eEpUck4r?=
 =?utf-8?B?dy9yS0lxQzd0ZWtuR0dzeHFlbGIzZERwU2pUbG1ET0syd1JEVnBqTW01T0VG?=
 =?utf-8?B?WjQzN2VvNndBNDhVSGROQStUb25ySHJYS3ozRDFjVXZwcWIxdDFvUVlqOXEw?=
 =?utf-8?B?SStOUDhJUnVBc0UwU0NXVzBKd0J2dHdjTEx6aCtKWWNkMkZDTlc0NFFSNVV6?=
 =?utf-8?B?akw2VmdJcEI1dno2NVFaTUZrZ0d4WU1FK1ZyYjF6QzJaVTZ3bmJpVjYvZWYr?=
 =?utf-8?B?MURXZ09JRVhZM2xMTEs1eHZ3Nmp0YWNncWFtWmM1ejVPd0VVTTZKaUdQTzl6?=
 =?utf-8?B?amMvN1JYcWlXVW4rQklTNmFvdkFlbWMxL25JUTM4UGVXRDNZZDNyWUFMbmxy?=
 =?utf-8?B?cnRVUC9DYWx5ZmtCMkFuVGdCU2JIUjVha2E3Z2toMDBQVGFxSndIWmxLSkNr?=
 =?utf-8?B?Snk3UW43UlJuOHl3VWdWVXUyTHpkMU5ZYjQ3N0VDdlZ0Vmk0Uno0aTBHN3hv?=
 =?utf-8?B?RE5iWEY4d0VLK3BBUjFCelBGVXgyZFRhY2JjU3lNNXVPTTRwUjJIMllseU9l?=
 =?utf-8?B?TnZncjVxRVN1THltY09WeGlxTEtSMjcrb3F4RVpzZ2x1ZklEMEZzZzR2Um4w?=
 =?utf-8?B?NWdkMHE3eUFGQVdPQjcwNm5zeC9VTitYa2IyTE90T0JkVUNBU0ZmVTdhNENv?=
 =?utf-8?B?d2lQL0Fkc3NLTUZnU2Y5THd5Qkd5dkRxRmcycFFibUs3dHl1alE5U2ZnNjF1?=
 =?utf-8?B?Mlc2U1FYTHhLNTIrWGJXNlpqWFFYM3ZGaUc1MFdBT1V6dEJHZW9JbjlWZDFr?=
 =?utf-8?B?OERJQmt2NEdnQUJ1MTZKNnB5ODk5STZ6UnhvblB3V1VnRDRpTldtLzV0WWRV?=
 =?utf-8?B?eWc2dnduQitVcnVxQlpiallHWjIxbkVaQjRGZ2psQlEycHZjazV5VXhyVitz?=
 =?utf-8?B?d2N1RCtwdFczalV2SUo2ZFA0MDg3YmFSSVM4Y1BBa2JwSVE2MzgzNW52c1BF?=
 =?utf-8?B?T1IyN0djN2ZFWVJYdTJuSHd5WE1PaXA2bldwYUpSNG9RWWs4Z1RHZEJReDYw?=
 =?utf-8?B?TlhmdXh1UHBCVlhQTTh1bitjM3Jta3RoazQ1OCtUVUhFZGF0YTRSMnZMdS9m?=
 =?utf-8?B?Vk8yUXc5QngyNmIvaE1ickJVS3VkcjhwM3AxTVZXOThyQ1RJVzRaakEyQ3lj?=
 =?utf-8?B?YnlJR1E5aWM2N0xhYmh0OEMvRzcvL1paeUZsR2p2dmsxZFFNUjVYakNUd0FX?=
 =?utf-8?B?K25OU25xU1dIb0pwNUhoNUxPYTBWYTBLUzkwS3VxSkZURmY1RWoxZi9XZGY4?=
 =?utf-8?B?eVIra3U3NUVIYjRudUZINGxUbDNSekRuT2RYNkNGdGhzZjBmUFhZL2FMeWNy?=
 =?utf-8?B?K0w1dUdVUWF4bVFMalhOVUpXTjEyd3Z0K3pPVktuV1MxVDc0Z29DaVowVnkx?=
 =?utf-8?B?WW9CK0lpQnlFaFpwYk9RSnl5YjNHREpONWdkeDMrTHJkRms0T200MXkyZC9T?=
 =?utf-8?B?d2lveEZzWmE5T2Z5L0xEMGt5bUhId0dhd3c1bHoyZXV0aG84OE9wcEQyOERH?=
 =?utf-8?B?K3JEUng3Qk44amZYUTRmblh2N3R1Uzh1TG9JblpCYkVlSSt1NCtUUTVmRGJi?=
 =?utf-8?B?YnQ0QlpQT1hDOG1uZSs5RDM5dGp2MmRWS1dvRThPYVFiclJTN241ZjRoR3N1?=
 =?utf-8?B?d1IwMXFseDg2SnAraFlhQzByQm1sZ1Q0eHJpQzN5UXNLckZLcjVMbUhzREF5?=
 =?utf-8?B?dkZNT095alhrVituNERTL1Y1SUZKWUhyZHh1aStWekl4aENOUTV6ZXZtb2Vo?=
 =?utf-8?B?Y1pPL01qQ3NjY2o1enNZdGtsNW1ISHFYY1FMU3VYV21CUnR0QWcxQm1XYnJF?=
 =?utf-8?B?WGJNSEM5Wnc5UTRkcGdubDFDU3hHTGJTaWtVdXQreVRuR25Ud01pRFZqM0Ez?=
 =?utf-8?B?K01zZUlQck1OckhaSTBDdnM1cXZGTDNrOFE1MVAzQSt3YWZvWXJxYk5za20x?=
 =?utf-8?B?d0c5RzhiMjNrUzJNZmNWM3B1aDZrdUgwcys2ZkY4b01lM3d4c2hvbkZUZXp2?=
 =?utf-8?B?TXZnU0pmV0dEU2NWS1ZxVUx2WVBSWi9ucjM1TGc3c2NEdjdLUklTM0pWWTBq?=
 =?utf-8?B?VEpycVp0TjdCSDNmakx4MlUvQnJlUVhqaVRSYWJtVCtyaWJIV1lGdUNuRlFB?=
 =?utf-8?B?b0F3UjYxUGhRZ2llRHY2Rk9GeHl4cWZBK2p0dVkwZ0pmUllTR3lYUHg2ajdt?=
 =?utf-8?B?U2lJMzBJTVJHS25PbVpQZXNSalA2b1hTMzZYTE40NDlaQ0xYaHlFdz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f5046ee-8e01-4b0f-309c-08da52b5d5f1
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2022 12:10:15.9664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6O7G6w5+sU42GvK30VWId58QjFj2uTf+TKgaeyZX/qstX34/mxfJ7d7C6etZdeEgZALLnKscm1SHyaQZS36l9A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6274
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2022-06-20 at 12:32 +0200, Krzysztof Kozlowski wrote:
> On 20/06/2022 05:45, Liu Ying wrote:
> > Add bindings for Mixel LVDS PHY found on Freescale i.MX8qm SoC.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v1->v2:
> > * Set fsl,imx8qm-lvds-phy' and 'mixel,lvds-phy' as compatible's
> > enum. (Krzysztof)
> > * Skip 'clock-names' property. (Krzysztof)
> > * Drop 'This patch' from commit message. (Krzysztof)
> > 
> >  .../bindings/phy/mixel,lvds-phy.yaml          | 61
> > +++++++++++++++++++
> >  1 file changed, 61 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/mixel,lvds-
> > phy.yaml b/Documentation/devicetree/bindings/phy/mixel,lvds-
> > phy.yaml
> > new file mode 100644
> > index 000000000000..4bfcc0dd987f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml
> 
> Name the file fsl,imx8qm-lvds-phy.yaml

Will do.

> 
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Fmixel%2Clvds-phy.yaml%23&amp;data=05%7C01%7Cvictor.liu%40nxp.com%7C8141f62511ab4e19e50708da52a835dc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637913179660099686%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=467HslkQFKI%2FQxOyEpP2io%2BMeogqOTeArcq%2B2hS8W6Q%3D&amp;reserved=0
> > +$schema: 
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cvictor.liu%40nxp.com%7C8141f62511ab4e19e50708da52a835dc%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637913179660099686%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=v9tffg9QmyP150hLYv%2FLikQJNY%2FW51ViZsUKku2yTMs%3D&amp;reserved=0
> > +
> > +title: Mixel LVDS PHY for Freescale i.MX8qm SoC
> > +
> > +maintainers:
> > +  - Liu Ying <victor.liu@nxp.com>
> > +
> > +description: |
> > +  The Mixel LVDS PHY IP block is found on Freescale i.MX8qm SoC.
> > +  It converts two groups of four 7/10 bits of CMOS data into two
> > +  groups of four data lanes of LVDS data streams. A phase-locked
> > +  transmit clock is transmitted in parallel with each group of
> > +  data streams over a fifth LVDS link. Every cycle of the transmit
> > +  clock, 56/80 bits of input data are sampled and transmitted
> > +  through the two groups of LVDS data streams. Together with the
> > +  transmit clocks, the two groups of LVDS data streams form two
> > +  LVDS channels.
> > +
> > +  The Mixel LVDS PHY found on Freescale i.MX8qm SoC is controlled
> > +  by Control and Status Registers(CSR) module in the SoC. The CSR
> > +  module, as a system controller, contains the PHY's registers.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx8qm-lvds-phy
> > +      - mixel,lvds-phy
> 
> This is not specific enough compatible.

Will use mixel,28fdsoi-lvds-1250-8ch-tx-pll.

Thanks,
Liu Ying