Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758786AbXEXNKa (ORCPT ); Thu, 24 May 2007 09:10:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756718AbXEXNKX (ORCPT ); Thu, 24 May 2007 09:10:23 -0400 Received: from khc.piap.pl ([195.187.100.11]:47854 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756686AbXEXNKW (ORCPT ); Thu, 24 May 2007 09:10:22 -0400 To: "Satyam Sharma" Cc: "Robert P. J. Day" , "Adrian Bunk" , "Linux Kernel Mailing List" Subject: Re: any value to "NORET_TYPE" macro? References: <20070522135927.GA2098@stusta.de> <20070522161951.GC2098@stusta.de> From: Krzysztof Halasa Date: Thu, 24 May 2007 15:10:20 +0200 In-Reply-To: (Satyam Sharma's message of "Wed, 23 May 2007 19:16:24 +0530") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 22 "Satyam Sharma" writes: > Actually there's another thing :-) The __attribute__((xxx)) must go with the > function _declarations_ (and not the implementations/definitions). I noticed > after my previous mail that most of the double annotations are actually in > the case of the _declarations_ of these non-returning functions, whereas > most of the single-occurrences of NORET_TYPE were in the function > definitions, which means your patch that simply got rid of NORET_TYPE > actually ended up doing exactly the right thing that we wanted :-) Only half of it. Half of right thing is (here) a bad thing. NORET_TYPE does not do any harm. Removing it removes pointers to attrib((noreturn)) candidates. Simple. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/