Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760201AbXEXN1t (ORCPT ); Thu, 24 May 2007 09:27:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757047AbXEXN1j (ORCPT ); Thu, 24 May 2007 09:27:39 -0400 Received: from [216.16.235.2] ([216.16.235.2]:37121 "EHLO rubicon.netdirect.ca" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1757258AbXEXN1i (ORCPT ); Thu, 24 May 2007 09:27:38 -0400 X-Originating-Ip: 99.246.112.70 Date: Thu, 24 May 2007 09:25:31 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Krzysztof Halasa cc: Satyam Sharma , Adrian Bunk , Linux Kernel Mailing List Subject: Re: any value to "NORET_TYPE" macro? In-Reply-To: Message-ID: References: <20070522135927.GA2098@stusta.de> <20070522161951.GC2098@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Net-Direct-Inc-MailScanner-Information: Please contact the ISP for more information X-Net-Direct-Inc-MailScanner: Found to be clean X-Net-Direct-Inc-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-36.396, required 5, autolearn=not spam, ALL_TRUSTED -1.80, BAYES_00 -15.00, DRUGS_ANXIETY 0.40, INIT_RECVD_OUR_AUTH -20.00) X-Net-Direct-Inc-MailScanner-From: rpjday@mindspring.com Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 35 On Thu, 24 May 2007, Krzysztof Halasa wrote: > "Satyam Sharma" writes: > > > Actually there's another thing :-) The __attribute__((xxx)) must go with the > > function _declarations_ (and not the implementations/definitions). I noticed > > after my previous mail that most of the double annotations are actually in > > the case of the _declarations_ of these non-returning functions, whereas > > most of the single-occurrences of NORET_TYPE were in the function > > definitions, which means your patch that simply got rid of NORET_TYPE > > actually ended up doing exactly the right thing that we wanted :-) > > Only half of it. Half of right thing is (here) a bad thing. > > NORET_TYPE does not do any harm. > Removing it removes pointers to attrib((noreturn)) candidates. > Simple. everybody take a valium -- i asked andrew to drop that patch from the mm-tree until i get the time to go back and take a closer look. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/