Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2930325iog; Mon, 20 Jun 2022 07:43:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1suoW4nluNwUw3XjLOxVatvKan2PbnfdviUOFE+RaY5ygSa9gQ186G5yWEEp+q+HE/VxJiD X-Received: by 2002:a05:6402:516b:b0:435:8f7b:b6f7 with SMTP id d11-20020a056402516b00b004358f7bb6f7mr1739807ede.291.1655736192176; Mon, 20 Jun 2022 07:43:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655736192; cv=none; d=google.com; s=arc-20160816; b=VdVto4NShTCvZvRWe92S4tgEvghveKazezvdB5PWSk363qXRnGB++lqHTKnHyEvRZx lg2+cUv+nTpHeBNyh/oKGfaIxwuGI5Aw3nWOHH2WUqnMnD1uYwohUjy/CehH6u/R5l9P gn4vNgQOFEajh+/XdL6Rb3+xhYeJYV+Rb9jqqqVkPySa/YHmc5zRuCvbxMblNc61v5MJ 7DEyZIUWFWilCx9kY/OS2JUkOw+5n0YR988RDt1pBf7cuAMZljjqCjU9iCpgIaBiWfrl jmo9OFcLXbVv7rEQ3MYqAmvb9m1dhvYFWJX1aG/b7jpzfOCMTZS1AP4RDe1tq3xs9KKM XAAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lJBNtAV1yA+i/MK0Jq7WKInZAR7i0m0M50bWdQivyEo=; b=o6WYCODMFXRgOP9nCj8k2Db7pcn5L4aVXT8MlpMkAjssiNselwI6G1pDnm559M62uR WUZCNLGt2ft22krUBad4q/fgPqOklX0CFQDSKf3LImOH29HZw6S6COdL52FE7165i6p6 XFODys8WWzo0ss5toKk6hmySw7MWi67lLGs3KqG4MnD9oVGOFlrl0fkosxIDspAARqKb hL/VH7O6m7pz4T5R59RBxzJuMoHzKCCFUttDFbnv2BIJvxow1TMOw3EI95vXP6LswSnN Op8W6/9jrW6NSuHQaiYFeID1/KmvzTuqf7Av948MRJ6jD84A7VAJVbVE6uw3pQHl9qZY rMuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vZigrrZe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw12-20020a170906478c00b006f3c6ceb0efsi12000698ejc.51.2022.06.20.07.42.45; Mon, 20 Jun 2022 07:43:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=vZigrrZe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347851AbiFTNnX (ORCPT + 99 others); Mon, 20 Jun 2022 09:43:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347784AbiFTNmj (ORCPT ); Mon, 20 Jun 2022 09:42:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3202D2AE27; Mon, 20 Jun 2022 06:15:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 46330B811E4; Mon, 20 Jun 2022 13:10:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98716C3411B; Mon, 20 Jun 2022 13:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655730624; bh=ftUnPMZU24MRLwfpOo4vc5NlxqKsBXuHxgkiser/BO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vZigrrZeRu92leowhXfssfTljZvpKHldadOmgv1Q7TVi+7sa8KcbNDhs1iBFKPmsf C2l8h80MjAXBhcrgmczrf/CapLuHGs5PxlmrLOwcFN97p4E8KcX/pHSfVzae9xSXie BAWaGpZ1eq/5rwNWXluf5ur08bL5Eqm6bCRWkgc4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable , Dan Carpenter , Gregory CLEMENT , Tony Lindgren Subject: [PATCH 5.15 092/106] tty: n_gsm: Debug output allocation must use GFP_ATOMIC Date: Mon, 20 Jun 2022 14:51:51 +0200 Message-Id: <20220620124727.113002706@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220620124724.380838401@linuxfoundation.org> References: <20220620124724.380838401@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tony Lindgren commit e74024b2eccbb784824a0f9feaeaaa3b47514b79 upstream. Dan Carpenter reported the following Smatch warning: drivers/tty/n_gsm.c:720 gsm_data_kick() warn: sleeping in atomic context This is because gsm_control_message() is holding a spin lock so gsm_hex_dump_bytes() needs to use GFP_ATOMIC instead of GFP_KERNEL. Fixes: 925ea0fa5277 ("tty: n_gsm: Fix packet data hex dump output") Cc: stable Reported-by: Dan Carpenter Reviewed-by: Gregory CLEMENT Signed-off-by: Tony Lindgren Link: https://lore.kernel.org/r/20220523155052.57129-1-tony@atomide.com Signed-off-by: Greg Kroah-Hartman --- drivers/tty/n_gsm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -454,7 +454,7 @@ static void gsm_hex_dump_bytes(const cha return; } - prefix = kasprintf(GFP_KERNEL, "%s: ", fname); + prefix = kasprintf(GFP_ATOMIC, "%s: ", fname); if (!prefix) return; print_hex_dump(KERN_INFO, prefix, DUMP_PREFIX_OFFSET, 16, 1, data, len,