Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2932052iog; Mon, 20 Jun 2022 07:45:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vzZctJI4bgWyaxQOGQncaatVEGGykGt0okIgkxRul9KR5geWw8jQ98Pzsib1CjhDCniuFu X-Received: by 2002:a05:6402:2741:b0:434:fe8a:1f96 with SMTP id z1-20020a056402274100b00434fe8a1f96mr29792073edd.331.1655736320663; Mon, 20 Jun 2022 07:45:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655736320; cv=none; d=google.com; s=arc-20160816; b=PtmuzcBisM0AGSYLZozTFC3Qarq6pXC4ypvBlmI/cE9ZCIXStXZMoOjKb0TQ7DvR09 IebHW6BuE0oqEvdSlt+X/93US9u8FqJBL1eV4K+HOmZa+Pj0UOjIrzLq0aIDM1nlyT0S pW9IWyuDoAiZXJtz415aNs+825w42tdRErq+qnTjxasFbr5v9aPUDlVLJGZytz9AoHQ/ HovkxbDstVUOCG3X2HtCl1TVMj1fDPUZLD+JKSYF906J6Oz8iu6ui8xbdDVPv4sMGBCQ OpUP29CEqrqp/B6X6MuxkVCz6nfHmri426XaMM8U7Bon/tUIk+Ho4uL++pt355+ata6e pV7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=sab9UPp8iFL0EN7em7h4p/a5YU7RJdh7NAzW8qSUoQI=; b=E1/zAFqb9jY+Gw0zcGIDQ78UCAyudzXOflcYW/xK6hnZO2HX5EKTqIjeaFjStm7fYP Tt3szw5G2XyDHvZSWCgVWxhk1J4kSq6DWlBN2zl/8msiFLW506/xBnsrh28FVS6rFWLB MXh59uHEc4rPoq1fB2aWDVx7vChSQgIMOWovr5Ny8iBX3EaMR1lhcQPXk63v9xMnJQYp tvupTWHl+hyt0qpqYGtIWBn68IZhAyIhHmHC/oJZwUVGXtWG9RSylV2TfNk+kwKV/BCo JOUwSaT2maaR0Whk1j4vKk8/vmF252HlLaGIQR6Lsjse6eA1LeFl57qHueeOrDRLSxZh 7p6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kaU4e+4Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp11-20020a1709073e0b00b006feb76dbd51si14122912ejc.289.2022.06.20.07.44.53; Mon, 20 Jun 2022 07:45:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kaU4e+4Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343611AbiFTNR5 (ORCPT + 99 others); Mon, 20 Jun 2022 09:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344192AbiFTNNf (ORCPT ); Mon, 20 Jun 2022 09:13:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3103E1EC63; Mon, 20 Jun 2022 06:06:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2FA9DB811D2; Mon, 20 Jun 2022 13:03:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6FAD3C3411B; Mon, 20 Jun 2022 13:03:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655730203; bh=OR3RQNyE27ZIpiYht6F5EFvIBUfv9fN4ckMXp3vcjGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kaU4e+4ZLSqgiqMrW/+QKolD3pGwNNuclywwC+0jw1JlMbmAoVW52gsWasTv8gU8x Bp8cUj25/PuJkP9kg0guwyAnspC65vFbKr4DBTU7GleWJ6y8VbsOIKwCByRcPSoGhg 2riE9AlVMXHqUb39UYIXX3aUWT8CGtqenxVQ6xHk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Marc Zyngier , Sasha Levin Subject: [PATCH 5.10 56/84] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Date: Mon, 20 Jun 2022 14:51:19 +0200 Message-Id: <20220620124722.549887296@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220620124720.882450983@linuxfoundation.org> References: <20220620124720.882450983@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit f4b98e314888cc51486421bcf6d52852452ea48b ] of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") Signed-off-by: Miaoqian Lin Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com Signed-off-by: Sasha Levin --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index b4c1924f0255..38fab02ffe9d 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent) /* The PB11MPCore GIC needs to be configured in the syscon */ map = syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET, -- 2.35.1