Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2935006iog; Mon, 20 Jun 2022 07:48:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tzg0cn9AmYQbbZXV2YNowyGdotQeFDM8bIXI0Pt0Q/XidT0v5ntxEyhkywMuadPKG9JWPD X-Received: by 2002:a05:6a00:1387:b0:51c:2712:7859 with SMTP id t7-20020a056a00138700b0051c27127859mr25292069pfg.38.1655736529950; Mon, 20 Jun 2022 07:48:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655736529; cv=none; d=google.com; s=arc-20160816; b=Xb3Jqu4b6PEYEyD9lvPsdHr44ibLiL3lUQaXiZQoM1TZrZaDetMq/jXvQX+bafrWNZ 2zbEbKdCIfB079zr0/i9An6tOhaKrHlVl/OxvYMenCGIx+tEQQky5b9wYzny6BB7Cbqq V8CFzPxzGHWAoT2Td91SiSSTfzTcjLFvpyW0Xu9VVCmuXk7LlQ53NUEOEWh8U0jNlbam boEwJPjNsAdn4u9BGfYblRR1nn6TznoMzx2drlmNats8q4cxwsaNhk+20/eV6fHHcdxa vVhgcAqbtL2A5gDby4cegyqOb366aRFtNAgtSP8OshoFg3ysUiIZRpZT40tJlyEdPJPu 6vIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PpdRNM3NmpCh9rGf999BxEuLp+Xy0lCtYsC7q95GjT0=; b=NxG/WupI41475Sh7JpO/nZHtFHggWnj5Rx+M6ORdqaFtcFE4RZkmTNnYngAg2XifmN xQO9iBWebI6eHjfEJObuBWd1XF+gZRelUju7u0EP4yHOQQ9TXaJviXX8MGVsT59mWt0X mzgqJZw71s6WN7SwA5hIyi+FuhBraCNKcYR+YfmwxCWfO7+ZSjOjn3/czSyadj2N1FDH vXVQu0pWWRvGmA/98nXHkxKcDz8d9cnz6oWlFBL+vrtDwLttQ5w+GEs/dxL2c3Bg7RtE WJq9Aa0z0YxzbRdvrufQZV6hcdHSX4c9JIXcaTjjV7PAXa4DGz2n6avu3dg514XeKMOv qhmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I8oPIB+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170902bd0900b0016763e0a6eesi8739799pls.486.2022.06.20.07.48.36; Mon, 20 Jun 2022 07:48:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=I8oPIB+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243221AbiFTOmF (ORCPT + 99 others); Mon, 20 Jun 2022 10:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242598AbiFTOli (ORCPT ); Mon, 20 Jun 2022 10:41:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CD4020BF8; Mon, 20 Jun 2022 07:01:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9AC7561554; Mon, 20 Jun 2022 14:01:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5E924C341D4; Mon, 20 Jun 2022 14:01:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655733687; bh=YUMrB+Vdzup5odUrd4n3f4Voh/iVMt/UvWkmdgl7bjw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I8oPIB+lsSO9Mtao44SoBnFSHRevd4oPy4WmK4q5iTeLWqh0u+xh+zNrrh5KAThpw i6lhhUrb7uatDl9f0fxeaSFZAW0MRmTQOPrH/TdspLVlLdBzS2Q/7bC4GDJ8KbV3hD lu1EV30hiusY4cFrlb+zCV1gqwJ5rkmZ6C0xLw3o= Date: Mon, 20 Jun 2022 16:01:23 +0200 From: Greg Kroah-Hartman To: Oliver Hartkopp Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel test robot , "David S. Miller" , Sasha Levin Subject: Re: [PATCH 5.18 081/141] net: remove noblock parameter from skb_recv_datagram() Message-ID: References: <20220620124729.509745706@linuxfoundation.org> <20220620124731.932460774@linuxfoundation.org> <04920243-e585-edf6-a849-cfa5a2ff6ba1@hartkopp.net> <4a53cf90-6ed9-c1b6-2974-3a0d1836c3b3@hartkopp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a53cf90-6ed9-c1b6-2974-3a0d1836c3b3@hartkopp.net> X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 20, 2022 at 03:56:08PM +0200, Oliver Hartkopp wrote: > > > On 6/20/22 15:54, Greg Kroah-Hartman wrote: > > On Mon, Jun 20, 2022 at 03:44:08PM +0200, Oliver Hartkopp wrote: > > > Hello Greg, > > > > > > as already answered to Sascha: > > > > > > --- > > > > > > Hello Sasha, > > > > > > this patch is some kind of improvement/simplification to reduce and clean up > > > the number of variables passed through skb_recv_datagram() call. > > > > > > There is no functional change and therefore no need to backport this patch > > > IMO. > > > > It is needed by a follow-on patch that fixes a real issue. > > Ah, ok! Wasn't aware of that follow-on patch. > > Sorry for the noise ;-) Not noise at all, thanks for the review,that's always appreciated. greg k-h