Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2935012iog; Mon, 20 Jun 2022 07:48:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vpM66aslmU01thWix6r+OJCrUcH4cByzCOrgek0JYuEgmLRgPLzGDdVqo/PWKFoZOJcTPW X-Received: by 2002:a17:906:3bd2:b0:711:ce53:5d5f with SMTP id v18-20020a1709063bd200b00711ce535d5fmr21296581ejf.500.1655736530727; Mon, 20 Jun 2022 07:48:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655736530; cv=none; d=google.com; s=arc-20160816; b=MLZ0qfO6ED99cCz7JpBW/gc6hdH20fBONqIHSK4SZ79MboGGXGtdPu5SfwSzXNsYSq zR9G6P3eSHsL9rNGBX8pxh/rMCikupL167Q9M/3E832mzK+hGJbSDEEvA+me+AihJnbH rh5fkAdHf8VQBbOE8YISiY0O06MqoH/VvnSTWtNcs4CsiwJUCqp6ZEhNMPe7N/oUE71A X1XKstANeavbOtvvmA2kcs0JacC89nGi8xx9q9wfcmVtaxubWjSrQZHqbKrdS1SMdfLa INsuUJ4Ps80+cy5zemvB5SOsIxneFOoEShtVnuIe2151cFFfXB26T1POOKlWmis6REs6 1EPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bhUFRGaa4qJTncT6xCgewkc5mgbT1kbjjI6kjuIlX3w=; b=wIU7VRacr+ij3+Q3m/+4FM6OL0A4HD+1jOoGdGU3xYRrEHlQyOse6Vy6eTDPbUtfuA hooemF5stJ0QH6qTb/lmstql2yVRP51kRy6mVyKr9rgEZ3NRN4GH+kOZS4RyZn1U/2ZL 1lfwHgxl4dGLpn2Vfceq17DhyJj5YBa4vEQWjDt8/B6+nTq2Vo8M/anHpW1F1D5GEeI8 yXzki7CZ7atARgW1oR1ATmHcRnjGvrPH0L9UwLa0KwFQbmk1yWPDAWCwyNwzoC714+jd Ooufnz+fWDw5d6s9j91T34IiyI0lkoYF7rxSSLrKQ17kd4yUGHpq6EKZ27Fh6cLTiqJX UUhA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Hnq3b069; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d4-20020a1709067a0400b0070bf25f1732si9059914ejo.155.2022.06.20.07.48.25; Mon, 20 Jun 2022 07:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Hnq3b069; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343860AbiFTNVW (ORCPT + 99 others); Mon, 20 Jun 2022 09:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343603AbiFTNQE (ORCPT ); Mon, 20 Jun 2022 09:16:04 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06EBF20BD0; Mon, 20 Jun 2022 06:07:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 10E56B811D7; Mon, 20 Jun 2022 13:07:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C5E0C3411C; Mon, 20 Jun 2022 13:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655730449; bh=G9sVT9BCC2t1SfzLQZXZjkGeZ3YE+zHFK85LE1yWtJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hnq3b069EHSpUWUZqmMRPn39aBNSVJe8EvaJGSOo6Rk2VpwypG7wJhxpx842PTdNc f4gT4mbvuVOJxJDpnQWGKyJUbbcvsIuvgnl7wqDndJ1z8R9Sz8m7Oscxv5+bTP+0GC xUrpw2eN1Gr/kRByxqVTcZwR6TsbtLUwSP4DqDzc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Claudiu Beznea , Miaoqian Lin , Sasha Levin Subject: [PATCH 5.15 056/106] misc: atmel-ssc: Fix IRQ check in ssc_probe Date: Mon, 20 Jun 2022 14:51:15 +0200 Message-Id: <20220620124726.063239415@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220620124724.380838401@linuxfoundation.org> References: <20220620124724.380838401@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit 1c245358ce0b13669f6d1625f7a4e05c41f28980 ] platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: eb1f2930609b ("Driver for the Atmel on-chip SSC on AT32AP and AT91") Reviewed-by: Claudiu Beznea Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220601123026.7119-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/atmel-ssc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index d6cd5537126c..69f9b0336410 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -232,9 +232,9 @@ static int ssc_probe(struct platform_device *pdev) clk_disable_unprepare(ssc->clk); ssc->irq = platform_get_irq(pdev, 0); - if (!ssc->irq) { + if (ssc->irq < 0) { dev_dbg(&pdev->dev, "could not get irq\n"); - return -ENXIO; + return ssc->irq; } mutex_lock(&user_lock); -- 2.35.1