Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2940210iog; Mon, 20 Jun 2022 07:56:15 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vi9NmK742iCdrILeBmUczyyZo+GXg6pOAd37ypomYBro060FsjpueV/VEwDYXf5BCv7IGh X-Received: by 2002:a17:90b:1651:b0:1e8:3e9c:801 with SMTP id il17-20020a17090b165100b001e83e9c0801mr37903828pjb.235.1655736975350; Mon, 20 Jun 2022 07:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655736975; cv=none; d=google.com; s=arc-20160816; b=wWWX/szPYXqABNEYkSCE5o8rM/Gz7CXKPjget9pVybCe6RmJDqYwZeT3ofFEBUiEdz EoF3vvHGJopBJYHGKaSAxsK0pXzNLfUCEcfMAo34fAMypvuO8zvnMMu0BolGrFXZ+8L7 fjdlKrC/1sDib0do3alnKN922BeHfbYe/4o/oEvSU7YEkhCy9PI10rOrbeqagUlPIqGB 3JmWY7JlL2PERCIRlfnydnrFeFQZVAR57JXBAkq+yK7MwfHZoI1kjF5U41BxnTTUKLsX asxQpjUmopE3pEpoQ7RUpol+8cP8C1vPaG4xvCt6ZI645zUFdC7R9f3Gdb8JhKe4OveK 9f3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=upTqRtUeF7LBmiXWhB2SEi4+1IWavq38D5x5P6zzd6c=; b=trd7MuKD3QtCWX0u3ZsvmrQFrO4oVLHtZ1X53P4YRV9HSO1WSfKIuf6BexOO9VFd8L gDK4vK3GngGY9LFSgCJGZ6VmY2KdvVQDBxVA9zQ1W2h3rzNjYvoDg5z21IJ1LvHpBnvc VheXiGDKTbqGnH75dBLZgk6pE2eaUM7bdY3yN+mjBbPChPNwNKD70aZT1ZE9Zu4n/INg y4qK7ms51KpZe0b0diDbpzOvf0JM2zWLyQQ0sds8wdmq6jOkekX07k/W3VslrbZhqd5K G55f/0kD/AYguws1ecgAqCVulszhf8CExYU6bi9dW77BaC00JEQ2JBBOxJrM5k6BNVay rE9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qz7kYYx1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a056a0014ce00b0051873a68dd2si18576796pfu.252.2022.06.20.07.56.03; Mon, 20 Jun 2022 07:56:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qz7kYYx1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244259AbiFTNYo (ORCPT + 99 others); Mon, 20 Jun 2022 09:24:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346102AbiFTNYW (ORCPT ); Mon, 20 Jun 2022 09:24:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1963C237E0; Mon, 20 Jun 2022 06:09:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3890A60A5F; Mon, 20 Jun 2022 13:08:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E24BC3411B; Mon, 20 Jun 2022 13:08:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655730532; bh=4n0Wzlr6YB1MgU7Df3hf9T2VUmmmf5Q3AuPkSwfTp6g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qz7kYYx1vGK5RJuaeUS5oymcJx4Bg4yf7k3t49fo7TnLbyLqTft/0srWhSXGR0Gzn RK763bKuodyLA46XLdyssucsPloydoPeldkEmPJ66WJj/FJVfytClCXh+1CKvS08Wm +oswDtRlH4OOxT7bgMdBIwG3H6b/hLut/5ZfQmNA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Ian Abbott Subject: [PATCH 5.15 083/106] comedi: vmk80xx: fix expression for tx buffer size Date: Mon, 20 Jun 2022 14:51:42 +0200 Message-Id: <20220620124726.847387907@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220620124724.380838401@linuxfoundation.org> References: <20220620124724.380838401@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ian Abbott commit 242439f7e279d86b3f73b5de724bc67b2f8aeb07 upstream. The expression for setting the size of the allocated bulk TX buffer (`devpriv->usb_tx_buf`) is calling `usb_endpoint_maxp(devpriv->ep_rx)`, which is using the wrong endpoint (should be `devpriv->ep_tx`). Fix it. Fixes: a23461c47482 ("comedi: vmk80xx: fix transfer-buffer overflow") Cc: Johan Hovold Cc: stable@vger.kernel.org # 4.9+ Reviewed-by: Johan Hovold Signed-off-by: Ian Abbott Link: https://lore.kernel.org/r/20220607171819.4121-1-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman --- drivers/comedi/drivers/vmk80xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/comedi/drivers/vmk80xx.c +++ b/drivers/comedi/drivers/vmk80xx.c @@ -685,7 +685,7 @@ static int vmk80xx_alloc_usb_buffers(str if (!devpriv->usb_rx_buf) return -ENOMEM; - size = max(usb_endpoint_maxp(devpriv->ep_rx), MIN_BUF_SIZE); + size = max(usb_endpoint_maxp(devpriv->ep_tx), MIN_BUF_SIZE); devpriv->usb_tx_buf = kzalloc(size, GFP_KERNEL); if (!devpriv->usb_tx_buf) return -ENOMEM;