Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2968780iog; Mon, 20 Jun 2022 08:28:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uf2KlMMX3kzEk7HL3RAVHKOgUofbVlMYvJP1ObpZeRdpPQald09YpfJVY14TRzTRCtTp5k X-Received: by 2002:a63:af1b:0:b0:40c:d257:7d9 with SMTP id w27-20020a63af1b000000b0040cd25707d9mr2145674pge.114.1655738905796; Mon, 20 Jun 2022 08:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655738905; cv=none; d=google.com; s=arc-20160816; b=Y0Pu8gmUsHvcprlemsdWnXm8rDwvAHmddPByVIZvdHo56QYbZRAqW/mCqLDkaynqp+ 75Zw5MZlI7ydiDzD+EPVcurSWUJCcv580DbKQtFd7ereRw6vvVuliv4aJMJ/PMz92UbD zDhmtN5VO1pYQOnOKWC9M6P0hlTNyQlDoiW3Dv0SSxsUEnBdziQacMs0HDrQ7qHrBXl8 ba63tbkyjXj6j4D7kjmLsB0XPGJ08tDb1t0qQthSmYVuKJfnHywCF0syMnBLM6FGThlr nB8WHn9z05YuWNDA8YgDxitcf486zZ2QtXE/3Ak2nPejQvBrw0YSHKE6Is8ac7FWVw9L b2wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iuHCJsCWRrFc8xRE1pPf353DnYJkGMJluzCFMW+Nr6Q=; b=0ZrKytXYqM83+aAPjL8iVgdqhJmmwFJBQ8ysqQttaGY0pyDT6GXdUtLPOMFeN2T8J/ Krj8e5w352iHgjhZe9EUeK/JuNz91g79AIHNHbyS9XFxFvhihjkRZhI1cKNFf6G9n8R7 tDD2PxfsbHL88vZfcZ9adYZHkcpdHFd5nzU086S9eWCri/rxIkI4Ymvox4mYZoNtWq62 4EX8hBweYEaLJz4NrjWwWsddmvw085h+cep06dfJbqLupiOb4X7qy8hDe0uuzbfdtQvr spiR9d34TLu3yVNR3CryC2S1pANTxqjmwwC4hWpUWxsN70AlCmLdqYL/Y8Ps7IhNvb78 YT8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Maa4UXxT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m9-20020a1709026bc900b001617b60e734si16097654plt.139.2022.06.20.08.28.13; Mon, 20 Jun 2022 08:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Maa4UXxT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242432AbiFTPKK (ORCPT + 99 others); Mon, 20 Jun 2022 11:10:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242897AbiFTPJ5 (ORCPT ); Mon, 20 Jun 2022 11:09:57 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCFF62497A; Mon, 20 Jun 2022 07:56:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 91BAEB811D5; Mon, 20 Jun 2022 14:56:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01640C3411B; Mon, 20 Jun 2022 14:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655736998; bh=iuHCJsCWRrFc8xRE1pPf353DnYJkGMJluzCFMW+Nr6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Maa4UXxTdt3KZpgrG3Bdx+W/MPuQawr5e4TNJJ861YViGUrJ0N5wel/7n6wsgIZ+g tyve74E9CTe/JKawsgozk5sAZfqVl+m9dsj9540Z2Pk9PYPSs5N96jM6yw/0Pe+5up OuZUE3yFNLH9+2PHOOjek94zMLsKyEejQEJyNFhwBOArVeI2YsY3FtieoN0W3VlY/Q t21P/3MIqx2FNfrkU7U/0+x90M3A4gAXtFQBemeNpRHXWUzOhzCfDvmM+OqmEYu7m5 XuoHD19cmutNfSdAPAdklL31pj7efFk1CWj0YORIyMzkVpwMpBAgpkThMdut9k67m7 30DSA9rk+tzYQ== Date: Mon, 20 Jun 2022 15:56:31 +0100 From: Mark Brown To: Pierluigi Passaro Cc: Alifer Willians de Moraes , "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , Eran Matityahu , "festevam@gmail.com" , "lgirdwood@gmail.com" , "linuxppc-dev@lists.ozlabs.org" , "nicoleotsuka@gmail.com" , "patches@opensource.cirrus.com" , "perex@perex.cz" , "robh+dt@kernel.org" , "shengjiu.wang@gmail.com" , "tiwai@suse.com" , "Xiubo.Lee@gmail.com" Subject: Re: [PATCH 4/4] ASoC: wm8904: add DMIC support Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AbQUs8uU3Zo5uRnw" Content-Disposition: inline In-Reply-To: X-Cookie: Good day to avoid cops. Crawl to work. X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --AbQUs8uU3Zo5uRnw Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2022 at 02:49:51PM +0000, Pierluigi Passaro wrote: > > > +static const char *cin_text[] =3D { > > > +=A0=A0=A0=A0 "ADC", "DMIC" > > > +}; > > > +static SOC_ENUM_SINGLE_DECL(cin_enum, > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0 WM8904_DIGITAL_MICROPHONE_0, 12, cin_text); > > Why would this be runtime selectable?=A0 I'd expect the decision to use > > an analogue or digital microphone to be made in the hardware design. > I agree that dedicated HW is required, but currently SW side there's no s= upport at all. > This patch is aiming to provide a way to enable DMIC on boards using it. > Is this supposed to be managed in a different way ? Via firmware description. --AbQUs8uU3Zo5uRnw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKwip4ACgkQJNaLcl1U h9COyQf/e1DSNnLS5C1cVLwYjiESEN2bZYjPBZvXZ/Nil+AvbRsE6mebr8M1RLAW 2Hhd0EnevkPtZygo8C0zz92XHbocSuNy15oYDIhYb7M3cG7VEOhqK8i2izZcs7CY pR4TpxfAncFHht0NaOPWauJOlapDytWDmSNKtmi0Y1EXbJi86winalwy//S7Q3nO Q/87q+YM253/joHhJK/cHMbz6ONqF1VodXrPX3SIJC40T3hW3mSqeNV/UFWkejdG ROH4DIdG6ydfG+Kiwsy6aAVVr9Fg2XqkoEQPZzHUv3Laujd6U2Z3HgRI4eDgsOJC hBOpo+Aw3wIT6Hjw5v4VY2YpcsD0YQ== =elfJ -----END PGP SIGNATURE----- --AbQUs8uU3Zo5uRnw--