Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 08:56:49 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     jdmason@kudzu.us
Cc:     patchwork-bot+netdevbpf@kernel.org,
        Wentao_Liang <Wentao_Liang_g@163.com>, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/ethernet/neterion/vxge: Fix a
 use-after-free bug in vxge-main.c
Message-ID: <20220620085649.79989775@kernel.org>
In-Reply-To: <165563641313.16837.10425130041626423819.git-patchwork-notify@kernel.org>
References: <20220619141454.3881-1-Wentao_Liang_g@163.com>
        <165563641313.16837.10425130041626423819.git-patchwork-notify@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 19 Jun 2022 11:00:13 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
> Hello:
>=20
> This patch was applied to netdev/net.git (master)
> by David S. Miller <davem@davemloft.net>:
>=20
> On Sun, 19 Jun 2022 22:14:54 +0800 you wrote:
> > The pointer vdev points to a memory region adjacent to a net_device
> > structure ndev, which is a field of hldev. At line 4740, the invocation
> > to vxge_device_unregister unregisters device hldev, and it also releases
> > the memory region pointed by vdev->bar0. At line 4743, the freed memory
> > region is referenced (i.e., iounmap(vdev->bar0)), resulting in a
> > use-after-free vulnerability. We can fix the bug by calling iounmap
> > before vxge_device_unregister.
> >=20
> > [...] =20
>=20
> Here is the summary with links:
>   - drivers/net/ethernet/neterion/vxge: Fix a use-after-free bug in vxge-=
main.c
>     https://git.kernel.org/netdev/net/c/8fc74d18639a
>=20
> You are awesome, thank you!

=F0=9F=98=AD=F0=9F=98=AD=F0=9F=98=AD

Jon, if you care about this driver staying upstream please send=20
a correct fix (on top of this change since it's already merged).