Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 10:55:41 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] dt-bindings: Arm CoreSight binding schema
 conversions
Message-ID: <20220620165541.GA1458883@p14s>
References: <20220603011933.3277315-1-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220603011933.3277315-1-robh@kernel.org>
Precedence: bulk

Hi Rob,

On Thu, Jun 02, 2022 at 08:19:30PM -0500, Rob Herring wrote:
> This series converts all the CoreSight debug bindings to DT schema
> format. These bindings are at the top of the list of occurrences of
> bindings without a schema. For arm64 dts files:
> 
>     702 ['arm,coresight-etm4x', 'arm,primecell']
>     536 ['arm,coresight-cpu-debug', 'arm,primecell']
>     509 ['arm,coresight-dynamic-funnel', 'arm,primecell']
>     213 ['arm,coresight-tmc', 'arm,primecell']
>     143 ['arm,coresight-dynamic-replicator', 'arm,primecell']
>      97 ['arm,coresight-stm', 'arm,primecell']
> 
> I'll send a reply to these with the errors in dts files that this
> causes. I've reviewed them and they all look legit. Xilinx Zynq though
> has 3 clocks instead of 2.
> 
> v2:
>  - Rename other Coresight bindings to use compatible string for filename
>  - Add missing arm,coresight-dynamic-replicator.yaml and
>    arm,coresight-static-funnel.yaml
>  - Update MAINTAINERS
>  - Fix coresight.txt references

What a massive undertaking... I have looked scrupulously and everything adds up.
Let me know if you were looking for me to pick this up.  Otherwise:

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Thanks,
Mathieu

> 
> Rob
> 
> Rob Herring (3):
>   dt-bindings: arm: Rename Coresight filenames to match compatible
>   dt-bindings: arm: Convert CoreSight bindings to DT schema
>   dt-bindings: arm: Convert CoreSight CPU debug to DT schema
> 
>  .../bindings/arm/arm,coresight-catu.yaml      | 101 +++++
>  .../bindings/arm/arm,coresight-cpu-debug.yaml |  81 ++++
>  ...esight-cti.yaml => arm,coresight-cti.yaml} |   5 +-
>  .../arm/arm,coresight-dynamic-funnel.yaml     | 126 ++++++
>  .../arm/arm,coresight-dynamic-replicator.yaml | 126 ++++++
>  .../bindings/arm/arm,coresight-etb10.yaml     |  92 ++++
>  .../bindings/arm/arm,coresight-etm.yaml       | 156 +++++++
>  .../arm/arm,coresight-static-funnel.yaml      |  89 ++++
>  .../arm/arm,coresight-static-replicator.yaml  |  90 ++++
>  .../bindings/arm/arm,coresight-stm.yaml       | 101 +++++
>  .../bindings/arm/arm,coresight-tmc.yaml       | 131 ++++++
>  .../bindings/arm/arm,coresight-tpiu.yaml      |  91 ++++
>  ...yaml => arm,embedded-trace-extension.yaml} |   3 +-
>  ...e.yaml => arm,trace-buffer-extension.yaml} |   2 +-
>  .../bindings/arm/coresight-cpu-debug.txt      |  49 ---
>  .../devicetree/bindings/arm/coresight.txt     | 402 ------------------
>  Documentation/trace/coresight/coresight.rst   |   2 +-
>  MAINTAINERS                                   |   8 +-
>  18 files changed, 1192 insertions(+), 463 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-catu.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-cpu-debug.yaml
>  rename Documentation/devicetree/bindings/arm/{coresight-cti.yaml => arm,coresight-cti.yaml} (98%)
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-funnel.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-dynamic-replicator.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etb10.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-etm.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-funnel.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-static-replicator.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-stm.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tmc.yaml
>  create mode 100644 Documentation/devicetree/bindings/arm/arm,coresight-tpiu.yaml
>  rename Documentation/devicetree/bindings/arm/{ete.yaml => arm,embedded-trace-extension.yaml} (95%)
>  rename Documentation/devicetree/bindings/arm/{trbe.yaml => arm,trace-buffer-extension.yaml} (94%)
>  delete mode 100644 Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt
>  delete mode 100644 Documentation/devicetree/bindings/arm/coresight.txt
> 
> --
> 2.34.1