Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 20:44:05 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marcin Wojtas <mw@semihalf.com>
Cc:     linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
        netdev@vger.kernel.org, rafael@kernel.org, lenb@kernel.org,
        andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
        hkallweit1@gmail.com, gjb@semihalf.com, jaz@semihalf.com,
        tn@semihalf.com, Samer.El-Haj-Mahmoud@arm.com,
        upstream@semihalf.com
Subject: Re: [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode
 pointer
Message-ID: <YrCx5SkADWBzRokM@smile.fi.intel.com>
References: <20220620150225.1307946-1-mw@semihalf.com>
 <20220620150225.1307946-5-mw@semihalf.com>
 <YrCxqDYg6OIdgmG1@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YrCxqDYg6OIdgmG1@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Jun 20, 2022 at 08:43:05PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 20, 2022 at 05:02:17PM +0200, Marcin Wojtas wrote:
> > As a preparation to switch the DSA subsystem from using
> > of_find_net_device_by_node() to its more generic fwnode_
> > equivalent, the port's device structure should be updated
> > with its fwnode pointer, similarly to of_node - see analogous
> > commit c4053ef32208 ("net: mvpp2: initialize port of_node pointer").
> > 
> > This patch is required to prevent a regression before updating
> > the DSA API on boards that connect the mvpp2 port to switch,
> > such as Clearfog GT-8K or CN913x CEx7 Evaluation Board.
> 
> ...
> 
> >  	dev->dev.of_node = port_node;
> > +	dev->dev.fwnode = port_fwnode;
> 
> device_set_node() ?

Ah, important remark to all device_set_node() comments. It assumes that you
replace _both_ assignments with _single_ call.

-- 
With Best Regards,
Andy Shevchenko