Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f7e75426-035b-bf0a-b565-bc816b4eeb23@gmx.de>
Date:   Mon, 20 Jun 2022 20:25:09 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] fbdev: simplefb: Check before clk_put() not needed
Content-Language: en-US
To:     Hans de Goede <hdegoede@redhat.com>, Yihao Han <hanyihao@vivo.com>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220602094219.13024-1-hanyihao@vivo.com>
 <84aa3225-d514-4c08-f6d3-ed8f0423e513@redhat.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <84aa3225-d514-4c08-f6d3-ed8f0423e513@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 6/2/22 12:50, Hans de Goede wrote:
> Hi,
>
> On 6/2/22 11:42, Yihao Han wrote:
>> clk_put() already checks the clk ptr using !clk and IS_ERR()
>> so there is no need to check it again before calling it.
>>
>> Signed-off-by: Yihao Han <hanyihao@vivo.com>
>> ---
>>  drivers/video/fbdev/simplefb.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simpl=
efb.c
>> index 2c198561c338..f96ce8801be4 100644
>> --- a/drivers/video/fbdev/simplefb.c
>> +++ b/drivers/video/fbdev/simplefb.c
>> @@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par =
*par,
>>  		if (IS_ERR(clock)) {
>>  			if (PTR_ERR(clock) =3D=3D -EPROBE_DEFER) {
>>  				while (--i >=3D 0) {
>> -					if (par->clks[i])
>> -						clk_put(par->clks[i]);
>> +					clk_put(par->clks[i]);
>>  				}
>>  				kfree(par->clks);
>>  				return -EPROBE_DEFER;
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

applied to fbdev tree.

Thanks!
Helge