Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 20 Jun 2022 21:52:44 +0200
From:   LABBE Corentin <clabbe@baylibre.com>
To:     heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org,
        robh+dt@kernel.org, m.reichl@fivetechno.de
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
        stable@kernel.org
Subject: Re: [PATCH] arm64: rockchip: rk3399-roc-pc: prevent fusb302 powering
 off the board during boot
Message-ID: <YrDQDLOXQKtPVgzU@Red>
References: <20220620110407.2393644-1-clabbe@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220620110407.2393644-1-clabbe@baylibre.com>
Precedence: bulk

Le Mon, Jun 20, 2022 at 11:04:07AM +0000, Corentin Labbe a ?crit :
> The rk3399-roc-pc never finish booting because it is powered off when probing
> fusb302.
> 
> The type c port is disabled because not present in DT as can seen in dmesg:
> OF: graph: no port node found in /i2c@ff3d0000/usb-typec@22
> 
> So adding the port in DT (as needed by the device tree schema of
> fusb302), permits the board to survive and finish booting.
> 
> CC: stable@kernel.org # 5.10+
> Fixes: 8bb878cf20ae ("arm64: dts: rockchip: add support for ROC-RK3399-PC board")
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> This patch is tested on 5.10.123, 5.15.48 and next-20220614
> 

Please ignore this for now, it fixes the issue but
[   31.653778] typec_fusb302 7-0022: cannot register tcpm port, ret=-22
[   31.659415] typec_fusb302: probe of 7-0022 failed with error -22

So while having a board which boot fine is better, having everything well probed will be better.

For fixing the probe error, adding the following is sufficiant:
@@ -558,6 +559,9 @@ connector {
                        data-role = "host";
                        label = "USB-C";
                        power-role = "dual";
+                       op-sink-microwatt = <1000000>;
+                       sink-pdos = <PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
+                       source-pdos = <PDO_FIXED(5000, 1400, PDO_FIXED_USB_COMM)>;
 
                        ports {
                                #address-cells = <1>;
But this bring the initial issue, the board is still dont booting...