Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3202628iog; Mon, 20 Jun 2022 13:55:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v/CNIZxeRoCmpmkIisjd6IcwAIEJ1UR2SwOnW+4xIyeoeddYP58Lhyanp90T9Y8Nnr/n4Q X-Received: by 2002:a65:464a:0:b0:408:b022:877a with SMTP id k10-20020a65464a000000b00408b022877amr22902822pgr.78.1655758531869; Mon, 20 Jun 2022 13:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655758531; cv=none; d=google.com; s=arc-20160816; b=sFYw782dJ3TSdU8CsRRUHjOBwqIw0BbDpniOnKHrPvsdFm6qLu/4+HxPyRJ+1ogmBj bUJ1hrBD79uWnJSs/UOJIE7GbFtoDTrLdnH8rdjeRbrp+7dOD6e3l7mzz7sLG+3ZqJ7a Y9MFC2rUpJnjdTydL6ML7gjy1v90PLE72ZA3FRRBz/qm1v+9/D5ukM20QieXvaGbqew6 7WrT+FS05L5wXQu0awHkRY3D6ZHEKdPgduiSxZmxynKEHdO2y3SHfb3vPw3iY+fT69CA cDeXcZ900XWYnf4gVWjz9/y5T6Fpd6hpTjVnY7Gfa16mFHYcqefAz+5Cw4eRL1uCwI4W I/aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rFP2epvfooKrZpPFT8BKKDNI28ulsq6H0dBYSPgFoyk=; b=oHmb67qFDBY4Qn/naywlN9tCtExjx6QHhGp2bp5pig5AZgveRYnXplVjpmHbmagerL k6v+iucjPCmhOB4/7tCz9k++8OxVTNaGbkuxZE0CjI3+Y5utKfDPEG04VAn/pFTkcCqv rfAHG5k3XpHAOoA9B7/kCN+TLuKiIc5XQ3PWrm3TZC7W0+1wwWAuz2UjU7CtVDmq07Fy Tqo03qn9kJhsLpzN5DDW2K95vXMn5aMuSrXkV7rQrCe2qUUAHIllHUJ9hLAgRzeJEQwg 8+DssxruhNg/Ekl3A5LKJSz4/+PXNXXObPcDCe2amaiFn5sXHDbAIz8agpVU7UGkw8Ms voXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AjebCnrC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r15-20020a63514f000000b003fc6a2458b6si19155224pgl.350.2022.06.20.13.55.20; Mon, 20 Jun 2022 13:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AjebCnrC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343677AbiFTULd (ORCPT + 99 others); Mon, 20 Jun 2022 16:11:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344282AbiFTUJA (ORCPT ); Mon, 20 Jun 2022 16:09:00 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 537DF21E16; Mon, 20 Jun 2022 13:07:33 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id o8so16104302wro.3; Mon, 20 Jun 2022 13:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rFP2epvfooKrZpPFT8BKKDNI28ulsq6H0dBYSPgFoyk=; b=AjebCnrCn0roYHEXtZUSrMTMzWgreVkEMmGmWHB4aW5MqCKA4G4WAtMmLhSH/wSD9O hErB+wW/nmuyZcj6VsVAhDUiCzXy1A0InOSiMOhVg1zOo944NV//bnCbQ2Nfq/Wvm/4X gHuja0BV7C29XQ21FTvJ66Q4m2HHGHfjAfbDNfzOus4oL46kEV7W/Ut/DNWQxw6A0wN3 MaclksZzjz+wgvfYM3RiCRmGkMi+n+Veo8oqESntYKECZMRtvsRVSUdWqg/UzoMptmRp DOSCYB+7UcRMW3szUyAX5e47sGuNfYYpbyhUPLebUPzr6yz1Frjd0ZNrD8flYUO0+4T7 n+iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rFP2epvfooKrZpPFT8BKKDNI28ulsq6H0dBYSPgFoyk=; b=m2PZwAKxSBFM29cdZs60Qvi1i/8UCO/KbK7InycUNlGZtaiD17J9ovFjPWph5VAF6Q blWNzyx1nWQpTl0LsKsQE0xcG4ioZHg67VfIVu6YzYDAR6mqKYp6Phi9c/b2nOPn/zhx QEt7m6pBAB3eLsDSNI8UWWNbrKY2zqZwnLn4QBl2G9zq2UcGcazBk89+y594Ax+EzEfn vj3/1j3wxAIbO6si80Rj6g180SzFyrHd2CuV8R3VW0NU8Hts7VhqBySe1cYvJ3o3jsjs rcP7g48NVPAJjTNwXoQ6de0cZyWE7fWL9Imal1u+N85WIx970TkJ0YDU1Y2Au3aAPoQx B7Qg== X-Gm-Message-State: AJIora/62Qns/+mRDfFxNahq3W0E/MMMhNvMLTxm8trSibQzG0ALov3y wP+2qmbRW88yMZ+w9820p7k= X-Received: by 2002:a05:6000:10d0:b0:21b:8ffb:80ad with SMTP id b16-20020a05600010d000b0021b8ffb80admr6433209wrx.444.1655755644354; Mon, 20 Jun 2022 13:07:24 -0700 (PDT) Received: from localhost (92.40.169.63.threembb.co.uk. [92.40.169.63]) by smtp.gmail.com with ESMTPSA id o20-20020a1c7514000000b0039c4ec6fdacsm15898561wmc.40.2022.06.20.13.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jun 2022 13:07:23 -0700 (PDT) From: Aidan MacDonald To: broonie@kernel.org Cc: agross@kernel.org, bjorn.andersson@linaro.org, srinivas.kandagatla@linaro.org, bgoswami@codeaurora.org, gregkh@linuxfoundation.org, rafael@kernel.org, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, b.zolnierkie@samsung.com, myungjoo.ham@samsung.com, michael@walle.cc, linus.walleij@linaro.org, brgl@bgdev.pl, tglx@linutronix.de, maz@kernel.org, lee.jones@linaro.org, mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, rjones@gateworks.com, mazziesaccount@gmail.com, orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, alsa-devel@alsa-project.org Subject: [PATCH 43/49] mfd: qcom-pm8008: Enable mask_writeonly flag for irq chip Date: Mon, 20 Jun 2022 21:06:38 +0100 Message-Id: <20220620200644.1961936-44-aidanmacdonald.0x0@gmail.com> In-Reply-To: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> References: <20220620200644.1961936-1-aidanmacdonald.0x0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PM8008 has separate set and clear registers for controlling its interrupt masks. These are likely volatile registers which read as 0, and writing a '1' bit sets or clears the corresponding bit in the mask register. The PM8008's regmap config doesn't enable a cache, so all register access is already volatile. Adding the mask_writeonly flag should reduce bus traffic by avoiding a read-modify-write on the mask set/clear registers. Signed-off-by: Aidan MacDonald --- drivers/mfd/qcom-pm8008.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index 7bc6becfe7f4..c778f2f87a17 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -141,6 +141,7 @@ static struct regmap_irq_chip pm8008_irq_chip = { .status_base = PM8008_STATUS_BASE, .mask_base = PM8008_MASK_BASE, .unmask_base = PM8008_UNMASK_BASE, + .mask_writeonly = true, .ack_base = PM8008_ACK_BASE, .config_base = pm8008_config_regs, .num_config_bases = ARRAY_SIZE(pm8008_config_regs), -- 2.35.1