Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751737AbXEXQYS (ORCPT ); Thu, 24 May 2007 12:24:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750754AbXEXQYK (ORCPT ); Thu, 24 May 2007 12:24:10 -0400 Received: from smtp1.linux-foundation.org ([207.189.120.13]:50637 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbXEXQYI (ORCPT ); Thu, 24 May 2007 12:24:08 -0400 Date: Thu, 24 May 2007 09:23:36 -0700 From: Andrew Morton To: Ingo Molnar Cc: righiandr@users.sourceforge.net, Bernd Eckenfels , linux-kernel@vger.kernel.org, Rik van Riel , linux-mm@kvack.org Subject: Re: [PATCH 1/2] limit print_fatal_signal() rate (was: [RFC] log out-of-virtual-memory events) Message-Id: <20070524092336.b0b8cd8d.akpm@linux-foundation.org> In-Reply-To: <20070524095503.GA14783@elte.hu> References: <464ED258.2010903@users.sourceforge.net> <20070520203123.5cde3224.akpm@linux-foundation.org> <20070524075835.GC21138@elte.hu> <20070524011551.3d72a6e8.akpm@linux-foundation.org> <20070524095503.GA14783@elte.hu> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1284 Lines: 34 On Thu, 24 May 2007 11:55:03 +0200 Ingo Molnar wrote: > > * Andrew Morton wrote: > > > On Thu, 24 May 2007 09:58:35 +0200 Ingo Molnar wrote: > > > > > > > > * Andrew Morton wrote: > > > > > > > Well OK. But vdso-print-fatal-signals.patch is designated > > > > not-for-mainline anyway. > > > > > > btw., why? > > > > err, because that's what I decided a year ago. I wonder why ;) > > > > Perhaps because of the DoS thing, but it has a /proc knob and defaults > > to off, so it should be OK. > > yeah. There's also a boot option. To address the DoS angle, should i > make it optionally printk_ratelimit() perhaps? (although often the > messages come in streams and skipping a message can be annoying) I don't think so, really. It takes a deliberate act to turn the thing on, after all. I we _were_ concerned about the logspam then it might be better to make the feature turn itself off after 100 messages, rather than ratelimiting it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/